Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

rust-cssparser: new implementation of css3-syntax

74 views
Skip to first unread message

Simon Sapin

unread,
Jan 25, 2013, 4:20:17 AM1/25/13
to dev-...@lists.mozilla.org
Hi dev-servo,

I started a rust implementation of the css3-syntax editor’s draft:

https://github.com/SimonSapin/rust-cssparser/
http://dev.w3.org/csswg/css3-syntax/

This is very much work in progress (right now it only has the tokenizer)
but I hope it will be useful to servo eventually.

I’m learning rust along the way, so any feedback is welcome.

Have fun,
--
Simon Sapin

Brian Anderson

unread,
Jan 25, 2013, 2:53:11 PM1/25/13
to dev-...@lists.mozilla.org
Hi Simon,

I'm super excited about this! Good luck.

I took a quick peek and noticed that you have both a `cssparser.rc` and
`cssparser.rs`. This pattern is more or less deprecated, a relic from a
time when `rc` files had a special syntax (I'm assuming you copied this
pattern from some of the other servo submodules that were ported forward
from older language revisions). I would recommend putting the content of
`cssparser.rs` directly in `cssparser.rc`. Some background on this
topic: https://mail.mozilla.org/pipermail/rust-dev/2012-December/002679.html

Regards,
Brian

Simon Sapin

unread,
Jan 25, 2013, 5:34:15 PM1/25/13
to Brian Anderson, dev-...@lists.mozilla.org
Le 25/01/2013 20:53, Brian Anderson a écrit :
> Hi Simon,
>
> I'm super excited about this! Good luck.

Thanks!


> I took a quick peek and noticed that you have both a `cssparser.rc` and
> `cssparser.rs`. This pattern is more or less deprecated, a relic from a
> time when `rc` files had a special syntax (I'm assuming you copied this
> pattern from some of the other servo submodules that were ported forward
> from older language revisions). I would recommend putting the content of
> `cssparser.rs` directly in `cssparser.rc`. Some background on this
> topic:https://mail.mozilla.org/pipermail/rust-dev/2012-December/002679.html

Indeed, I probably copied this pattern from another library. Good to know.

--
Simon Sapin
0 new messages