FYI: Mozilla Add-ons: MozMill 1.3
Aakash Desai
-- Aakash
----- Forwarded Message -----
From: "Clint Talbert" <ctal...@mozilla.com>
To: "MozMill Developers" <mozmi...@googlegroups.com>
Sent: Monday, November 23, 2009 8:48:28 AM GMT -08:00 US/Canada Pacific
Subject: Fwd: Mozilla Add-ons: MozMill 1.3
Hey Mozmill Folks,
First, off, Mozmill 1.3 has been released on AMO. :)
We got some feedback from the AMO Reviewer (it's below), and it sounds like something we ought to look into. I've filed bug 530546 for that, so if anyone out there is looking to get started with Mozmill development, here's a great opportunity.
Thanks so much to everyone that made 1.3 a reality, especially Gordon McRight, Henrik Skupin, Heather Arthur, and Mikeal Rogers.
Cheers!
Clint
-------- Original Message --------
Subject: Mozilla Add-ons: MozMill 1.3
Date: Sat, 21 Nov 2009 06:01:55 -0800
From: Mozilla Add-ons <nob...@mozilla.org>
Reply-To: Mozilla Add-ons <nob...@mozilla.org>
To: ctal...@mozilla.com
The following files of MozMill 1.3 have been made public by a Mozilla Add-ons editor:
MozMill 1.3 - ALL
Review Information:
Reviewer: Nils Maier
Tested on Windows with Firefox 3.5
Comments: Approving update based on diffs.
In many places the use of setTimeout/eval() seems unnecessary.
Like:
eval("parent."+this.settings["save_callback"]+"('"+ this.id +"', editArea.textarea.value);");
Could be rewritten as:
parent[this.settings["save_callback"]](this.id, editArea.textarea.value);
Please also have a look at Funtion.apply/.call.
If you have questions about this review, please e-mail amo-e...@mozilla.org or join #addons on irc.mozilla.org.
Mozilla Add-ons http://addons.mozilla.org
-- You received this message because you are subscribed to the Google Groups "MozMill Developers" group.
To post to this group, send email to mozmi...@googlegroups.com.
To unsubscribe from this group, send email to mozmill-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mozmill-dev?hl=.
Henrik Skupin
> First, off, Mozmill 1.3 has been released on AMO. :)
I have setup a blog post:
http://www.hskupin.info/2009/11/23/mozmill-1-3-release/
--
Henrik Skupin
QA Execution Engineer
Mozilla Corporation