Re: Improving accesskey handling
Simon Bünzli
> the bug
> that Alt+Shift currently triggers accesskeys as well (making Alt+Shift
> shortcuts as worthless as Alt shortcuts).
That's https://bugzilla.mozilla.org/show_bug.cgi?id=332365 and it
currently makes all modifier combos containing Alt (resp. Ctrl on
Mac/Unix) act unreliably because content accesskeys are prioritized over
chrome accesskeys.
Simon Bünzli
ui.key.generalAccessKey is now read first and the new prefs will only be
used when it's set to -1. It will however default to -1 so that it will
only be used when it's been manually changed.
The new prefs default to Alt for chrome and Alt+Shift for content which
seems to be the most favored solution suggested in bugs 128452, 179816,
207510 and 303192.
If there's no further discussion on this, I'd like to check in the patch
on the trunk as soon as it's been reviewed to have it bake for a week or
two and get some tester feedback.
Or is there any reason not to?
Cheers,
Simon
Simon Bünzli schrieb am 25.06.06 11:27:
> Thread started over at m.d.a.firefox:
> http://groups.google.com/group/mozilla.dev.apps.firefox/browse_thread/thread/22cf7d4596b89173/8dea031713186d4f
>
> I'd like to improve accesskey handling so that I don't get bitten any
> longer by Alt+D not working in BugZilla.
>
> There has been much debate over how to solve this problem best and an
> acceptable solution is still missing. Until we can decide on one, I
> propose to make the following change to alleviate the situation:
>
>> Introduce two new preferences (ui.key.contentAccess and
> ui.key.chromeAccess) which allow to (optionally) overwrite the current
> ui.key.generalAccessKey for only content resp. chrome access keys.
>
> These two prefs would additionally allow modifier combos making it
> possible to have e.g. Alt+Shift as content accesskey and fixing the bug
> that Alt+Shift currently triggers accesskeys as well (making Alt+Shift
> shortcuts as worthless as Alt shortcuts).
>
> The proposed patch to bug 340902 has only little impact on the current
> code, doesn't force Gecko embedders to make any changes and would still
> be a very convenient help for all those affected by bug 128452.
>
> I'd appreciate your feedback in the hope to get this issue at least
> partially resolved for Gecko 1.8.1.
>
> Cheers,
> Simon
>
>
> References:
> * Original bug: https://bugzilla.mozilla.org/show_bug.cgi?id=128452
> * Allow [Shift] as accesskey:
> https://bugzilla.mozilla.org/show_bug.cgi?id=179816
> * Accesskeys should require a key combination first:
> https://bugzilla.mozilla.org/show_bug.cgi?id=303192
> * Split ui.key.generalAccessKey in two prefs:
> https://bugzilla.mozilla.org/show_bug.cgi?id=340902