The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
Mike Shaver <mike.sha...@gmail.com> wrote:For what it's worth, Ben Newman, over in bug 559962 asked for review on a 54kb
> Yes, and we should be trying to avoid such patches. Decomposing into
> stages (mq helps a lot here) and doing piecemeal landings is
> worthwhile. I don't know very many people who can actually review a
> non-mechanical 1000-line patch across modules with high confidence
patch. Fortunately, he had broken the patch up into easily reviewable mq
patches, each of which I could review in a matter of minutes with a high
degree of confidence. The overall patch in the bug would have taken me
significantly longer to review and I would have trusted my own review a lot
If more people did this, I believe the world would be a much better place.
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.