Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Message from discussion Speeding up reviews
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Blake Kaplan  
View profile  
 More options Apr 21 2010, 8:51 pm
Newsgroups: mozilla.dev.planning
From: Blake Kaplan <mrb...@gmail.com>
Date: Wed, 21 Apr 2010 19:51:47 -0500
Local: Wed, Apr 21 2010 8:51 pm
Subject: Re: Speeding up reviews

Mike Shaver <mike.sha...@gmail.com> wrote:
> Yes, and we should be trying to avoid such patches.  Decomposing into
> stages (mq helps a lot here) and doing piecemeal landings is
> worthwhile.  I don't know very many people who can actually review a
> non-mechanical 1000-line patch across modules with high confidence
> anyway.

For what it's worth, Ben Newman, over in bug 559962 asked for review on a 54kb
patch. Fortunately, he had broken the patch up into easily reviewable mq
patches, each of which I could review in a matter of minutes with a high
degree of confidence. The overall patch in the bug would have taken me
significantly longer to review and I would have trusted my own review a lot
less.

If more people did this, I believe the world would be a much better place.
--
Blake Kaplan


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.