Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

nsCAutoString -> nsAutoCString - mass change

37 views
Skip to first unread message

Randell Jesup

unread,
Aug 29, 2012, 9:52:15 AM8/29/12
to
[ This is largely a repeat of an earlier posting, with some updates ]
[ duplicate of what I posted on m.d.platform ]

See bug 773151

After seeing some discussion on #developers about how we should bring
the naming of nsCAutoString in line with other classes, I threw together
a patch (using the wonders of 'sed') and now I'm stuck shepherding
it. :-) (roc, dbaron, gavin, njn, jlebar, etc were all involved or
agree, and bsmedberg has r+'d).

Note that to ease life initially for external codebases, we're including
a "typedef nsCAutoString nsAutoCString" in nsStringAPI.h in the
deprecated section. We plan to convert comm-central at the same time,
as it uses the internal API. The actual patch that will land is
generated by a script.

We're preparing to land it this weekend, but I wanted to give people a
little warning, and detail how to adapt any in-progress patches that
touch code near an instance of the string "nsCAutoString".

To unbitrot any patches you have in patch queues after this lands,
please run the script in
https://bug773151.bugzilla.mozilla.org/attachment.cgi?id=655673 in each
repo you have cloned locally. This will correct the patches in every
patch queue in the directory. You will need to make sure your changes
are committed or in a hg queue patch, and all patches are popped (the
script checks that they're popped).

We'll put links to the script in the title of #developers for a while.

Thanks!

--
Randell Jesup, Mozilla Corp
remove ".news" for personal email

Randell Jesup

unread,
Sep 2, 2012, 2:00:39 AM9/2/12
to
See bug 773151

We landed a renaming patch to m-c, inbound and comm-central to change
nsCAutoString to nsAutoCString, to make the API naming make sense.

Note that to ease life initially for external codebases, we're including
a "typedef nsCAutoString nsAutoCString" in nsStringAPI.h in the
deprecated section.

NOTE:
0 new messages