Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Fwd: [ANNOUNCE] Search Plugins landed for Thunderbird and the associated policy

12 views
Skip to first unread message

flod

unread,
Nov 15, 2011, 1:28:31 AM11/15/11
to dev-...@lists.mozilla.org
Not sure why but this message never reached Google Groups (both l10n and
l10n.announce) :-\
Forwarding in case other Thunderbird localizers (like our own) missed this.

Francesco

-------- Messaggio originale --------
Oggetto: [ANNOUNCE] Search Plugins landed for Thunderbird and the
associated policy
Data: Wed, 09 Nov 2011 12:49:37 +0000
Mittente: Mark Banner <mba...@mozilla.com>
A: dev-...@lists.mozilla.org
Gruppi di discussione: mozilla.dev.l10n.announce,mozilla.dev.l10n
Inoltra a:: mozilla.dev.l10n.announce



[posted to m.d.l10n as well as m.d.l10n.announce to ensure everyone sees
this, future posts will just go to m.d.l10n.announce]

As you will have most likely have seen, we've just landed the capability
to search the web (this had been codenamed OpenSearch) directly within
Thunderbird. This is now on the Aurora channel.

*The important part*
--------------------

Just like Firefox, we are going to require that you file a bug [1] with
your proposed changes/additions and put them up for review (currently
from myself).

You'll need review for any changes in the mail/searchplugins and to
mail/chrome/messenger-region/region-properties.

Sign-off requests which include unreviewed changes may be rejected.

This is so we can ensure consistency and that we have the right
parameters for Thunderbird.

Please be patient with the first round of requests - we are still
getting this set up - we will get to all of them as soon as we can and
before the end of the cycle. However, if you have concerns/issues,
please feel free to raise them.

The detailed policy
-------------------

I'm currently writing this up, I apologise for not having found time to
write and communicate it earlier. For guidance as to what to add, follow
the Firefox policy for now:

https://wiki.mozilla.org/L10n:Firefox/Productization#Search

To test:
--------
Once you've got a build with it, you can access it by selecting some
text in an email, right-clicking and selecting "Search the web for". You
can also access it from the global search box in the toolbar by typing
some text, and explicitly selecting the option.

Regards
Mark.


[1]
https://bugzilla.mozilla.org/enter_bug.cgi?bug_severity=normal&bug_status=NEW&cc=mbanner%40mozilla.com&form_name=enter_bug&keywords=productization&product=Mozilla%20Localizations&short_desc=%5Bab-CD%5D%20Search%20Engine%20modification%20for%20Thunderbird
_______________________________________________
dev-l10n mailing list
dev-...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-l10n

flod

unread,
Nov 28, 2011, 1:58:32 AM11/28/11
to Mozilla l10n Mailing List, Mark Banner
Hi Mark, can you give us an update on this? I think the situation is going
a bit out of control ;-)

6 bugs filed and waiting
https://bugzilla.mozilla.org/buglist.cgi?quicksearch=Search%20Engine%20modification%20for%20Thunderbird&list_id=1782869

15 locales have already committed changes to mail/searchplugins
http://mxr.mozilla.org/l10n-mozilla-aurora/find?string=mail/searchplugins/list.txt

Francesco

Pavel Franc

unread,
Nov 28, 2011, 2:07:20 PM11/28/11
to
Dne 28.11.2011 7:58, flod napsal(a):
But most of them just copied the list from en-US.

Pavel Franc
Mozilla.cz

flod

unread,
Nov 28, 2011, 2:20:31 PM11/28/11
to dev-...@lists.mozilla.org
As far as I understand you shouldn't land anything there, not even a copy
of en-US files, without patch+approval.

Francesco

Ricardo Palomares Martí­nez

unread,
Nov 28, 2011, 5:16:29 PM11/28/11
to
El 28/11/11 20:20, flod escribió:
> As far as I understand you shouldn't land anything there, not even a copy
> of en-US files, without patch+approval.


I beg to differ. Patch and approval have been required for Firefox to
change the en-US defaults, but you *need* to land searchplugins.txt to
have a complete localization (the XML searchplugin files are the ones
that can, and need to, be omitted if the locale defaults to en-US files).

--
Ricardo Palomares (RickieES)
http://www.mozilla-hispano.org/
http://www.proyectonave.es/
https://diasp.eu/u/rickiees


Axel Hecht

unread,
Nov 29, 2011, 2:50:35 AM11/29/11
to
On 28.11.11 23:16, Ricardo Palomares Martí­nez wrote:
> El 28/11/11 20:20, flod escribió:
>> As far as I understand you shouldn't land anything there, not even a copy
>> of en-US files, without patch+approval.
>
>
> I beg to differ. Patch and approval have been required for Firefox to
> change the en-US defaults, but you *need* to land searchplugins.txt to
> have a complete localization (the XML searchplugin files are the ones
> that can, and need to, be omitted if the locale defaults to en-US files).
>

The current l10n-merge algorithm and build logic only requires
toolkit/defines.inc, all other files are optional to get a working
Firefox build :-)

Not sure what tb does, though.

Axel

smo

unread,
Nov 29, 2011, 3:18:44 PM11/29/11
to
On 15 Nov., 07:28, flod <f...@lodolo.net> wrote:
> Not sure why but this message never reached Google Groups (both l10n and
> l10n.announce) :-\
> Forwarding in case other Thunderbird localizers (like our own) missed this.
>
> Francesco
>
> -------- Messaggio originale --------
> Oggetto:        [ANNOUNCE] Search Plugins landed for Thunderbird and the
> associated policy
> Data:   Wed, 09 Nov 2011 12:49:37 +0000
> Mittente:       Mark Banner <mban...@mozilla.com>
> A:      dev-l...@lists.mozilla.org
> [1]https://bugzilla.mozilla.org/enter_bug.cgi?bug_severity=normal&bug_st...
> _______________________________________________
> dev-l10n mailing list
> dev-l...@lists.mozilla.orghttps://lists.mozilla.org/listinfo/dev-l10n

Dear Mark:

as the mail:netError.dtd:securityOverride.getMeOutOfHereButton
says: Get me out of here!

Before I "process" some more china in bugzilla store, could you
just copycat FX patch for SL - I can gladly sign off on this step.

If this is not workable, then I need more info - adding the
mail/searchplugins/list.txt to mail that I am about to do,
evidently does not cut it.

TiA

smo

PS: crimson ears alert: I am just one of those learning by doing
TiA

Ricardo Palomares Martí­nez

unread,
Nov 29, 2011, 6:03:42 PM11/29/11
to
El 29/11/11 08:50, Axel Hecht escribió:
> The current l10n-merge algorithm and build logic only requires
> toolkit/defines.inc, all other files are optional to get a working
> Firefox build :-)
>
> Not sure what tb does, though.


Yes, but would that build qualify as official without a non-default
searchplugins.txt? Just wondering, as I thought that branding required
at least that file. :-?

TIA

Axel Hecht

unread,
Nov 30, 2011, 5:26:58 AM11/30/11
to
On 30.11.11 00:03, Ricardo Palomares Martí­nez wrote:
> El 29/11/11 08:50, Axel Hecht escribió:
>> The current l10n-merge algorithm and build logic only requires
>> toolkit/defines.inc, all other files are optional to get a working
>> Firefox build :-)
>>
>> Not sure what tb does, though.
>
>
> Yes, but would that build qualify as official without a non-default
> searchplugins.txt? Just wondering, as I thought that branding required
> at least that file. :-?
>
> TIA
>

We'd put such a build out to the beta audience for Firefox, but we're
derailing a bit here.

The bugs need traction, and you shouldn't land stuff without patches in
bugs. Bugs for post-landing review aren't the same thing, too.

Axel

Mark Banner

unread,
Nov 30, 2011, 11:14:48 AM11/30/11
to
On 28/11/2011 06:58, flod wrote:
> Hi Mark, can you give us an update on this? I think the situation is going
> a bit out of control ;-)

Sorry, I was delaying a bit so that I could get a general idea of the
shape of the suggestions so far and then raise the questions with people
at my end about them.

I was taking a detailed look yesterday, and hope to look at actually
reviewing some today, if not tomorrow.

Mark.

Ricardo Palomares Martí­nez

unread,
Dec 1, 2011, 4:55:53 PM12/1/11
to
El 30/11/11 11:26, Axel Hecht escribió:
> The bugs need traction, and you shouldn't land stuff without patches
> in bugs. Bugs for post-landing review aren't the same thing, too.


Not sure if that "you" was referring specifically to me (that landed
in es-ES an unmodified searchplugins.txt so localization is complete)
or to people trying to change default searchplugins in their
localizations. :-?

Axel Hecht

unread,
Dec 2, 2011, 10:34:41 AM12/2/11
to
On 01.12.11 22:55, Ricardo Palomares Martí­nez wrote:
> El 30/11/11 11:26, Axel Hecht escribió:
>> The bugs need traction, and you shouldn't land stuff without patches
>> in bugs. Bugs for post-landing review aren't the same thing, too.
>
>
> Not sure if that "you" was referring specifically to me (that landed
> in es-ES an unmodified searchplugins.txt so localization is complete)
> or to people trying to change default searchplugins in their
> localizations. :-?

I'm looking at localizers in general, triggered by
https://bugzilla.mozilla.org/show_bug.cgi?id=702562, though.

Axel

flod

unread,
Dec 10, 2011, 11:32:43 PM12/10/11
to dev-...@lists.mozilla.org
Il 30/11/11 17.14, Mark Banner ha scritto:
> I was taking a detailed look yesterday, and hope to look at actually
> reviewing some today, if not tomorrow.
Any news on this? We're almost one week from the move to beta (IIRC Dec
20th).

Francesco

Mark Banner

unread,
Dec 12, 2011, 5:38:54 AM12/12/11
to
I got through quite a few bits last week, but it isn't quite as fast as
I'd like to be. I'm hoping to get through the remaining outstanding
requests today.

Mark.

Joaquim Perez

unread,
Jan 4, 2012, 4:45:42 AM1/4/12
to Mark Banner, dev-...@lists.mozilla.org
Hi Mark,

I'm sorry we were late filling the bug before Aurora sign-off. The bug is
still open [1] and the sign-off in aurora is still pending [2].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=712268
[2] https://l10n-stage-sj.mozilla.org/shipping/dashboard?locale=ca )

Joaquim
ca-locale

Sander Lepik

unread,
Jan 4, 2012, 5:18:42 AM1/4/12
to dev-...@lists.mozilla.org
> _______________________________________________
> dev-l10n mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-l10n
Same thing for Estonian (et):
https://bugzilla.mozilla.org/show_bug.cgi?id=712734

(OT: when did Thunderbird become a searching machine that can't handle
simple emails anymore
(https://bugzilla.mozilla.org/show_bug.cgi?id=685794)? Yes, i'm
frustrated. And the new BOGUS "create a paid account" dialog didn't help
either. Next time finish your development, review it and then submit it
for translating. We have already an application that does web, mail,
etc, etc - it's called Seamonkey. Why ruin simple mail client with such
a fuzz? If developers have nothing to do, just fix the code and make it
better. At some point Thunderbird is now using more memory than Firefox
- WTF? I see no reason to create more bogus features and at the same
time not fix the old mess..)

--
Sander

Mark Banner

unread,
Jan 4, 2012, 7:25:05 AM1/4/12
to
Hi guys,

On 04/01/2012 10:18, Sander Lepik wrote:
> 04.01.2012 11:45, Joaquim Perez kirjutas:
>> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=712268

> Same thing for Estonian (et):
> https://bugzilla.mozilla.org/show_bug.cgi?id=712734

I was away all over Christmas until after the new year, hence I haven't
progressed these yet.

I'm still catching up on email and everything, I should be processing
these tomorrow.

(for the OT issues I'll respond in a private email, being OT).

Mark.

Rimas Kudelis

unread,
Jan 5, 2012, 3:15:11 AM1/5/12
to
2012.01.04 14:25, Mark Banner rašė:
> Hi guys,
>
> On 04/01/2012 10:18, Sander Lepik wrote:
>> 04.01.2012 11:45, Joaquim Perez kirjutas:
>>> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=712268
>
>> Same thing for Estonian (et):
>> https://bugzilla.mozilla.org/show_bug.cgi?id=712734

Same for lt (bug 714381). It kinda makes me wonder what you would do if
I wouldn't file that bug – would you just accept the signoff, or make my
locale unsupported, or keep using the old signed off revision which
lacks more than just searchplugins. The only sane option IMO is still #1. :P

> I was away all over Christmas until after the new year, hence I haven't
> progressed these yet.
>
> I'm still catching up on email and everything, I should be processing
> these tomorrow.
>
> (for the OT issues I'll respond in a private email, being OT).

Can you please also cc me on your reply? I have similar OT concerns. Thanks!

Rimas

smo

unread,
Jan 5, 2012, 3:36:32 PM1/5/12
to

> Same for lt (bug 714381). It kinda makes me wonder what you would do if
> I wouldn't file that bug – would you just accept the signoff, or make my
> locale unsupported, or keep using the old signed off revision which
> lacks more than just searchplugins. The only sane option IMO is still #1. :P
>
I have not opened the bug (on time) for SL, so #3 alternative was
taken...

https://l10n-stage-sj.mozilla.org/shipping/signoffs/sl/tb-aurora

... "which lacks more than just searchplugins".

Regards

smo

PS: deleted some lines, describing how it felt. I guess
it would not be anything new to the majority of readers
here

smo

unread,
Jan 5, 2012, 3:43:35 PM1/5/12
to
....
>
> TiA
>
> smo
>
> PS: crimson ears alert: I am just one of those learning by doing
> TiA

however, worth mentioning:

i) I played with an idea to have a cake and NOT eat it too by patching
omni.jar in the release
ii) when this turned out practically impossible (while at the same as
dangerous as hell) I
started to call for volunteers, who would be ready to write some add-
on or whatever
to cover up the omissions

Rimas Kudelis

unread,
Jan 6, 2012, 1:47:36 AM1/6/12
to
2012.01.05 22:36, smo rašė:
>
>> Same for lt (bug 714381). It kinda makes me wonder what you would do if
>> I wouldn't file that bug – would you just accept the signoff, or make my
>> locale unsupported, or keep using the old signed off revision which
>> lacks more than just searchplugins. The only sane option IMO is still #1. :P
>>
> I have not opened the bug (on time) for SL, so #3 alternative was
> taken...
>
> https://l10n-stage-sj.mozilla.org/shipping/signoffs/sl/tb-aurora
>
> ... "which lacks more than just searchplugins".

Same happened for me in Aurora, that's why I filed that bug I was
secretly hoping to avoid filing. But I was talking more about the
release channel above, where appropriate quality is expected.

> PS: deleted some lines, describing how it felt. I guess
> it would not be anything new to the majority of readers
> here

That's something I too should exercise more often... :) Anyway, I'm sure
we'll be fine by the time searchplugins get to the release repos, since
the bugs are in place now.

Best regards and happy new year! ;)
Rimas

0 new messages