possible prod hotfix needed - some users cannot sign out of sites

[Shane Tomlinson]

Issue 3386 [1] was filed yesterday under the title "Users cannot log out".

This is due to an error on my part in PR 3350 [2].

In PR 3350, my aim was to consolidate the way we store site specific
information in localStorage. We had some information under the
'siteInfo' namespace, some information under the 'loggedIn' namespace. I
consolidated the two.

To make sure that users were still logged in after the consolidation, I
wrote a bit of code [3] to automatically update localStorage. When the
update was complete, I should have removed the original information. I
did not.

The effect is that if a user was signed in before the push to prod, they
visit a site that uses the .watch API and click on that site's signout
button, the user is marked as signed in again as soon as they refresh
the page.

Users who clear localStorage do not see the problem. Users who only
signed in to the site after the push to prod do not see the problem.
Users who sign out of Persona should not see the problem.

I have issued a PR that needs further consideration [4]. Seanmonstar has
given an r+, jrgm and Gene, is this hotfix material?

Shane

=====

[1] - https://github.com/mozilla/browserid/issues/3386
[2] - https://github.com/mozilla/browserid/pull/3150
[3] - https://github.com/mozilla/browserid/pull/3150/files#L0R43
[4] - https://github.com/mozilla/browserid/pull/3398

[John Morrison]

I'm not sure why this didn't happen to me, since I was signed in before
the prod push to several RPs. But anyways.

This seems like something we need to do. Unfortunately Gene is on PTO,
but he did phone me about this, and perhaps between bobm and mostlygeek
we have a way to get this done.

John

> _______________________________________________
> dev-identity mailing list
> dev-id...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-identity

[pe...@psantoro.net]

I believe I may have run into this issue, too. I posted this earlier today:

https://groups.google.com/forum/?fromgroups=#!topic/pylons-discuss/FMpCKZoTGNA

I'll try clearing localStorage as a workaround tomorrow when I get back to work.

Peter