Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Persona CSS selector changes
10 views
Skip to first unread message
Shane Tomlinson
May 15, 2013, 9:28:17 AM5/15/13
to Zac Campbell, Stephen Donner, Jedediah Parsons, dev-id...@lists.mozilla.org
For Zach, Stephen, Jed and anybody doing Selenium tests with Persona.
Today I issued a PR that is going to change the CSS selector of the
"cancel" button on all screens whose cancel button goes to the previous
state. The PR has yet to be reviewed and may need to be updated.
This change is necessary because of the drastic layout differences
between mobile and desktop - plain old CSS fu is not enough to
reposition the buttons. I had to add a second "cancel" button, one
button to is visible to desktop users, one is visible to mobile users.
When testing using a desktop browser, the cancel button is available
with the ".isDesktop.cancel" selector.
When testing using a mobile (B2G) browser, the cancel button is
available with the ".isMobile.cancel" selector.
3 screens are affected:
* Enter password after selecting a secondary email address from the
email picker screen
* Set password screen
* Add email screen
The pull request is https://github.com/mozilla/browserid/pull/3408.
Jed will be (tag, your it Jed!) the reviewer. I imagine the timeline to
merge into dev is before the end of the day on Friday.
Shane
Today I issued a PR that is going to change the CSS selector of the
"cancel" button on all screens whose cancel button goes to the previous
state. The PR has yet to be reviewed and may need to be updated.
This change is necessary because of the drastic layout differences
between mobile and desktop - plain old CSS fu is not enough to
reposition the buttons. I had to add a second "cancel" button, one
button to is visible to desktop users, one is visible to mobile users.
When testing using a desktop browser, the cancel button is available
with the ".isDesktop.cancel" selector.
When testing using a mobile (B2G) browser, the cancel button is
available with the ".isMobile.cancel" selector.
3 screens are affected:
* Enter password after selecting a secondary email address from the
email picker screen
* Set password screen
* Add email screen
The pull request is https://github.com/mozilla/browserid/pull/3408.
Jed will be (tag, your it Jed!) the reviewer. I imagine the timeline to
merge into dev is before the end of the day on Friday.
Shane
0 new messages