Maybe we should try to resurrect the interest for that problem, Thai
line-breaking, in the i18n group.
When you say your patch, do you mean the latest patch in bug 7969 ?
While we wait for a better solution in order to be able integrate thai
line breaking inside moz without too much overhead for the people who
don't need it, the dynamic loading of libthai option seems adequate, but
there should be a better way than what is done in that patch.
NSPR dynamic library loading is one possible direction :
http://www.mozilla.org/projects/nspr/reference/html/prlink.html
I can't run the binary there. But I've tried
firefox-1.6a1.en-US.rtl-v4.12.win32.installer.exe
at http://blacksapphire.com/firefox-rtl/ .
It still doesn't break lines correctly for Thai. Maybe this is not in
their specification.
--
_/|\_ Samphan Raruenrom. http://www.osdev.co.th/
Interesting.
Well I linked to the 'latest trunk' version so it might be broken from
time to time. But still I'm sure the cairo team would be interested in
such report.
> But I've tried
> firefox-1.6a1.en-US.rtl-v4.12.win32.installer.exe
> at http://blacksapphire.com/firefox-rtl/ .
If you read carefully the page, you will see that this version is based
on the standard graphic engine, not Thebes. One big hint is that the
author talks about running it in win98. There's no Thebes for win9x.
The Thebes effort of the author seems to be only available in the form
of the patch inside http://blacksapphire.com/firefox-rtl/thebes/, not as
downloadable binaries.
> It still doesn't break lines correctly for Thai. Maybe this is not in
> their specification.
It seems from the page firefox-1.6a1.en-US.rtl-v4.12 should do Thai.
I think you should ask the author about that problem.
I'm cross-posting this message to the mozilla.dev.tech.gfx groups where
Thebes discussing should happens.
Follow-up only about Thebes or about i18n problems not in Thebes should
restricted to only one of the two groups.
> Jean-Marc Desperrier wrote:
> > Samphan Raruenrom wrote:
> >> It is based on Mozilla Firefox 1.5, includes Thai translation,
> >> modification of preferences for Thai, Thai search plug-in and
> >> my patch to add Thai line-breaking using ICU.
> > Maybe we should try to resurrect the interest for that problem, Thai
> > line-breaking, in the i18n group.
>
> OK.
>
> > When you say your patch, do you mean the latest patch in bug 7969 ?
>
> Mine is the ICU patch, not the libthai patch.
>
> > While we wait for a better solution in order to be able integrate thai
> > line breaking inside moz without too much overhead for the people who
> > don't need it, the dynamic loading of libthai option seems adequate,
> but
> > there should be a better way than what is done in that patch.
> > NSPR dynamic library loading is one possible direction :
> > http://www.mozilla.org/projects/nspr/reference/html/prlink.html
>
> Interesting. Maybe a simple rewrite using the API will do.
While we are waiting for the Cairo/Thebe/Pango solution, I have updated
the patch to use NSPR (PR_LoadLibrary and stuff) instead of dlopen().
Please comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=7969
https://bugzilla.mozilla.org/attachment.cgi?id=211242&action=view
Cheers,
Ott
ps1:
I tried firefox-1.6a1.en-US.rtl-v4.12 already, word breaking is not working.
ps2:
I tried the firefox-1.6a1.en-US.linux-i686.tar.bz2 one without success.
I don't see all buttons, menus and URL location bar.
http://linux.thai.net/~ott/tmp/cairo-firefox.png
Debian unstable with following packages:
ii libpango1.0-0 1.8.1-1
ii pango-libthai 0.1.4-1
ii libcairo2 1.0.2-3
Not sure if I miss anything...
Samphan Raruenrom wrote:
> Jean-Marc Desperrier wrote:
> > Samphan Raruenrom wrote:
> >> It is based on Mozilla Firefox 1.5, includes Thai translation,
> >> modification of preferences for Thai, Thai search plug-in and
> >> my patch to add Thai line-breaking using ICU.
> > Maybe we should try to resurrect the interest for that problem, Thai
> > line-breaking, in the i18n group.
>
> OK.
>
> > When you say your patch, do you mean the latest patch in bug 7969 ?
>
> Mine is the ICU patch, not the libthai patch.
>
> > While we wait for a better solution in order to be able integrate thai
> > line breaking inside moz without too much overhead for the people who
> > don't need it, the dynamic loading of libthai option seems adequate,
> but
> > there should be a better way than what is done in that patch.
> > NSPR dynamic library loading is one possible direction :
> > http://www.mozilla.org/projects/nspr/reference/html/prlink.html
I have updated the patch to use NSPR (PR_LoadLibrary and stuff) instead
of dlopen().
Please have a look:
https://bugzilla.mozilla.org/show_bug.cgi?id=7969
https://bugzilla.mozilla.org/attachment.cgi?id=211242&action=view
Cheers,
Ott Pattara
>
> Interesting. Maybe a simple rewrite using the API will do.
> Libthai is available on Linux, maybe I should use Win32 API for
> line breaking on Windows? (which require #ifdef :-( )
>
> Samphan Raruenrom wrote:
>
>> Jean-Marc Desperrier wrote:
>> > Samphan Raruenrom wrote:
>> >> It is based on Mozilla Firefox 1.5, includes Thai translation,
>> >> modification of preferences for Thai, Thai search plug-in and
>> >> my patch to add Thai line-breaking using ICU.
>> > Maybe we should try to resurrect the interest for that problem, Thai
>> > line-breaking, in the i18n group.
>>
>> OK.
>
>
> I realized something recently. Cairo/Thebes based Firefox 3.0 will use
> Uniscribe (pango/gtk2 on linux). That should means it will gain thai
> word breaking at the same time.
> Maybe you should try one of the test cairo build to see what it gives ?
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/experimental/cairo/latest-trunk/
>
I've tried the firefox-1.6a1.en-US.linux-i686.tar.bz2 one without
success. I don't see all buttons, menus and URL location bar.
http://linux.thai.net/~ott/tmp/cairo-firefox.png
Debian unstable with following packages:
ii libpango1.0-0 1.8.1-1
ii pango-libthai 0.1.4-1
ii libcairo2 1.0.2-3
Cheers,
Ott
>
> Check what's in store here :
> http://wiki.mozilla.org/FutureGfxWhiteboard
> _______________________________________________
> dev-i18n mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-i18n
>
>
Any reason why you reacted on a four years old message ?
Firefox now, and since I believe 3.0, handles properly the line breaking
of thai through the use of the proper OS-level libraries.