CUSTOMIZE environment variable for Gaia Makefile & dedicated customization directory

[Tim Chien]

Dears,

With Yuren's timely help, we have landed bug 838110, and will land related
bug on the said feature.

The idea is as follows: We would like to centralize all the customization
needs, e.g. settings, preload apps, wallpapers, ringtones, bookmarks, home
screen positions, into one dedicated customization directory. With that,
our partners will be able to put their customization recipe into their own
private repo, and specify the path during build time, i.e.

CUSTOMIZE=/my/customized-build-for-carrier-x make install-gaia

and the Gaia build script will pick up files/lists/configs within, blend it
with the defaults, and build the phone with special favor.

The works involved generally are
-- rewrite hard-coded config/assets, have them being specified during build
time.
-- for some customization already implemented with a gitignore
customization file, make the build script also pick up the same file from
CUSTOMIZE dir.

There are many things to be done. Yuren could provide the detail. He is
looking to support urgent items we need for v1.0.0.0 customization, and
will continue work on the same direction afterward.

With everyone's consent, we hope to remove the legacy customized support
one all the items are centralized. That means configs should not be pick up
from current locations like build/custom-settings.json.

The app source directive (GAIA_APP_SRCDIRS) should be reviewed too -- in
light of the controversy involving moving calculator from apps to
showcase_apps -- a list-of-apps-to-build approach might be better than
having physically move the files within the repo.

Please raise your concern if you have questions on the direction we are
heading.

--
Tim Guan-tin Chien, Senior Front-end Dev., Mozilla Corp. (Taiwan)

[Fabrice Desre]

On 02/26/2013 10:45 PM, Tim Chien wrote:
>
> Please raise your concern if you have questions on the direction we are
> heading.

That's very nice! My only objection is about the name of the environment
variables. Can we use only GAIA_XXX names? And in this case, we usually
call these customizations "brandind", so GAIA_BRANDING_PATH would be my
preferred name.

Fabrice
--
Fabrice Desré
b2g team
Mozilla Corporation

[Tim Chien]

That make sense, thanks! Yuren, could you change the variable?

[Kevin Hu]

How about GAIA_CUSTOMIZE_PATH?
I am fine either way, just a suggestion.


Best regards,
Kevin Hu

> _______________________________________________
> dev-gaia mailing list
> dev-...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-gaia
>

[Josh Carpenter]

Sounds fantastic! I'm currently working on future-versions customization requirements, and it would be fantastic to get some of these new use cases baked into this new architecture. What's the best way to work with you guys on this? I'm happy to start by walking you through our current concepts and we can begin to work out what's possible. It's clear from MWC that customization and extension is a very important part of Firefox OS' future, so we should think carefully about how we go about this.

—
Josh Carpenter
UX Designer
Mozilla

[Yuren Ju]

Personally I prefer GAIA_CUSTOMIZE_PATH

and I will open a bug to modify CUSTOMIZE variable name when we decide.

Josh, could you explain more detail for future customization work? it would
be helpful if we know that as early as possible :)

[Staś Małolepszy]

On 02/27/2013 07:45 AM, Tim Chien wrote:
> Dears,
>
> With Yuren's timely help, we have landed bug 838110, and will land related
> bug on the said feature.
>
> The idea is as follows: We would like to centralize all the customization
> needs, e.g. settings, preload apps, wallpapers, ringtones, bookmarks, home
> screen positions, into one dedicated customization directory. With that,
> our partners will be able to put their customization recipe into their own
> private repo, and specify the path during build time, i.e.

What is the planned scope of the customizations wrt localization? Note
that localizations are perpendicular to partners and shared among all of
them.

Take bookmarks for example. Will there be a way for a partner to create
a multilocale build in which every locale has a different set of bookmarks?

For instance, assume X and Y are locale names, and we provide
localizations with Firefox OS into these languages.

Partner A wishes to add bookmarks to their builds. They'd like to link
to partnerA.com.xx for X and to partnerA.com.yy for Y.

Can they define per-locale customizations, or will they need to create
separate builds for each of their target locales?

> The app source directive (GAIA_APP_SRCDIRS) should be reviewed too -- in
> light of the controversy involving moving calculator from apps to
> showcase_apps -- a list-of-apps-to-build approach might be better than
> having physically move the files within the repo.

Just a note -- GAIA_APP_SRCDIRS is used to define GAIA_LOCALE_SRCDIRS:

GAIA_LOCALE_SRCDIRS=shared $(GAIA_APP_SRCDIRS)
https://github.com/mozilla-b2g/gaia/blob/master/Makefile#L98

GAIA_LOCALE_SRCDIRS is a list of directories to copy l10n files into
when doing | make multilocale |.

-stas

[Fabrice Desre]

On 02/27/2013 06:44 AM, Yuren Ju wrote:
> Personally I prefer GAIA_CUSTOMIZE_PATH

I understand why, but we use "branding" in other Mozilla products so we
should really stick to that. See for instance
https://mxr.mozilla.org/mozilla-central/source/b2g/branding/

[Kevin Hu]

Hi, Josh,

Exactly! Customization is the final & an important key to launch Firefox OS, IMO.
Thanks.

Best regards,
Kevin Hu

----- Original Message -----

> From: "Josh Carpenter" <jcarp...@mozilla.com>
> To: "Kevin Hu" <k...@mozilla.com>
> Cc: timd...@mozilla.com, "Yuren Ju" <y...@mozilla.com>, "Fabrice
> Desre" <fab...@mozilla.com>, dev-...@lists.mozilla.org
> Sent: 2013年2月27日 星期三 21:39:16
> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile &
> dedicated customization directory

> Sounds fantastic! I'm currently working on future-versions
> customization requirements, and it would be fantastic to get some of
> these new use cases baked into this new architecture. What's the
> best way to work with you guys on this? I'm happy to start by
> walking you through our current concepts and we can begin to work
> out what's possible. It's clear from MWC that customization and
> extension is a very important part of Firefox OS' future, so we
> should think carefully about how we go about this.

> —
> Josh Carpenter
> UX Designer
> Mozilla

> > > > Fabrice
> > >
> >
>
> > > > --
> > >
> >
>
> > > > Fabrice Desré
> > >
> >
>
> > > > b2g team
> > >
> >
>
> > > > Mozilla Corporation
> > >
> >
>

[Kevin Hu]

Hi, Fabrice,

Thanks for your information.
I did not know that. Thanks for your sharing. I am fine either way, if it's clear for all of us. :)

Best regards,
Kevin Hu

----- Original Message -----
> From: "Fabrice Desre" <fab...@mozilla.com>
> To: "Yuren Ju" <y...@mozilla.com>
> Cc: "Kevin Hu" <k...@mozilla.com>, "Tim Guan-tin Chien" <timd...@mozilla.com>, dev-...@lists.mozilla.org
> Sent: 2013年2月28日 星期四 0:07:30
> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile & dedicated customization directory
>

> On 02/27/2013 06:44 AM, Yuren Ju wrote:
> > Personally I prefer GAIA_CUSTOMIZE_PATH
>
> I understand why, but we use "branding" in other Mozilla products so
> we
> should really stick to that. See for instance
> https://mxr.mozilla.org/mozilla-central/source/b2g/branding/
>

[Kevin Hu]

Hi, Josh,

Maybe we can have a call next week to align the concepts among all of us.
How is that?

Best regards,
Kevin Hu

----- Original Message -----
> From: "Kevin Hu" <k...@mozilla.com>
> To: "Josh Carpenter" <jcarp...@mozilla.com>
> Cc: "Yuren Ju" <y...@mozilla.com>, "Fabrice Desre" <fab...@mozilla.com>, dev-...@lists.mozilla.org,
> timd...@mozilla.com
> Sent: 2013年2月28日 星期四 1:03:20
> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile & dedicated customization directory
>

> Hi, Josh,
>
> Exactly! Customization is the final & an important key to launch
> Firefox OS, IMO.
> Thanks.
>

> Best regards,
> Kevin Hu
>
> ----- Original Message -----
>

> > From: "Josh Carpenter" <jcarp...@mozilla.com>
> > To: "Kevin Hu" <k...@mozilla.com>
> > Cc: timd...@mozilla.com, "Yuren Ju" <y...@mozilla.com>, "Fabrice
> > Desre" <fab...@mozilla.com>, dev-...@lists.mozilla.org
> > Sent: 2013年2月27日 星期三 21:39:16

> > Subject: Re: CUSTOMIZE environment variable for Gaia Makefile &
> > dedicated customization directory
>

> > Sounds fantastic! I'm currently working on future-versions
> > customization requirements, and it would be fantastic to get some
> > of
> > these new use cases baked into this new architecture. What's the
> > best way to work with you guys on this? I'm happy to start by
> > walking you through our current concepts and we can begin to work
> > out what's possible. It's clear from MWC that customization and
> > extension is a very important part of Firefox OS' future, so we
> > should think carefully about how we go about this.
>
> > —
> > Josh Carpenter
> > UX Designer
> > Mozilla
>
> > On Feb 27, 2013, at 9:19 AM, Kevin Hu < k...@mozilla.com > wrote:
>
> > > How about GAIA_CUSTOMIZE_PATH?
> >

> > > I am fine either way, just a suggestion.

> >
>
> > > Best regards,
> >
> > > Kevin Hu
> >
>
> > > ----- Original Message -----
> >
>

> > > > From: "Tim Chien" < timd...@mozilla.com >
> > >
> >
> > > > To: "Fabrice Desre" < fab...@mozilla.com >
> > >
> >
> > > > Cc: "Yuren Ju" < y...@mozilla.com >, dev-...@lists.mozilla.org
> > >
> >
> > > > Sent: 2013年2月27日 星期三 15:21:14
> > >
> >

> > > > Subject: Re: CUSTOMIZE environment variable for Gaia Makefile &
> > > > dedicated customization directory
> > >
> >
>

> > > > That make sense, thanks! Yuren, could you change the variable?
> > >
> >
>
> > > > On Wed, Feb 27, 2013 at 3:12 PM, Fabrice Desre <
> > > > fab...@mozilla.com
> > > > >
> > >
> >
> > > > wrote:
> > >
> >
>
> > > > > On 02/26/2013 10:45 PM, Tim Chien wrote:
> > > >
> > >
> >
>
> > > > > > Please raise your concern if you have questions on the
> > > > > > direction
> > > > >
> > > >
> > >
> >
> > > > > > we are
> > > > >
> > > >
> > >
> >
> > > > > > heading.
> > > > >
> > > >
> > >
> >
>
> > > > > That's very nice! My only objection is about the name of the
> > > >
> > >
> >
> > > > > environment
> > > >
> > >
> >
> > > > > variables. Can we use only GAIA_XXX names? And in this case,
> > > > > we
> > > >
> > >
> >
> > > > > usually
> > > >
> > >
> >
> > > > > call these customizations "brandind", so GAIA_BRANDING_PATH
> > > > > would
> > > >
> > >
> >
> > > > > be my
> > > >
> > >
> >
> > > > > preferred name.
> > > >
> > >
> >
>

> > > > > Fabrice
> > > >
> > >
> >
> > > > > --
> > > >
> > >
> >
> > > > > Fabrice Desré
> > > >
> > >
> >
> > > > > b2g team
> > > >
> > >
> >
> > > > > Mozilla Corporation
> > > >
> > >
> >
>

[Fabrice Desre]

On 02/27/2013 09:07 AM, Kevin Hu wrote:
> Hi, Josh,
>
> Maybe we can have a call next week to align the concepts among all of us.
> How is that?

Phone calls limit people participation in general. Can we please keep
that discussion on a public mailing list?

thanks,

[Josh Carpenter]

That sounds great, Kevin. I may be in Paris next week, FYI, so it will have to be a Euro-friendly time, if that works for you?

—
Josh Carpenter
UX Designer
Mozilla

On Feb 27, 2013, at 6:07 PM, Kevin Hu <k...@mozilla.com> wrote:

> Hi, Josh,
>
> Maybe we can have a call next week to align the concepts among all of us.
> How is that?
>
>

>>>>>> Fabrice
>>>>>
>>>>
>>>
>>>>>> --
>>>>>
>>>>
>>>
>>>>>> Fabrice Desré
>>>>>
>>>>
>>>
>>>>>> b2g team
>>>>>
>>>>
>>>
>>>>>> Mozilla Corporation
>>>>>
>>>>
>>>
>>

[Josh Carpenter]

Absolutely, I'd suggest we use both tools. Calls when needed to sync on issues like partner requirements, but everything else captured on the mailing list, from discussion requirements to architecture.

[Tim Chien]

Fabrice,

I thought "branding" is only about official Mozilla branding, which is
being dealt with the variable "MOZILLA_OFFICIAL".
As we are not touching that part of the build script, calling partner
customization "branding" might cause some confusion among two?

Anyway, this is too specific to be discussed on the list. Yuren, would you
post the bug # to the thread so we could continue the discussion there?

On Thu, Feb 28, 2013 at 12:07 AM, Fabrice Desre <fab...@mozilla.com> wrote:

> On 02/27/2013 06:44 AM, Yuren Ju wrote:
> > Personally I prefer GAIA_CUSTOMIZE_PATH
>
> I understand why, but we use "branding" in other Mozilla products so we
> should really stick to that. See for instance
> https://mxr.mozilla.org/mozilla-central/source/b2g/branding/
>

[Fabrice Desre]

On 02/28/2013 04:19 AM, Tim Chien wrote:
> Fabrice,
>
> I thought "branding" is only about official Mozilla branding, which is
> being dealt with the variable "MOZILLA_OFFICIAL".
> As we are not touching that part of the build script, calling partner
> customization "branding" might cause some confusion among two?

In gecko, we have MOZILLA_OFFICIAL, MOZILLA_BRANDING_DIRECTORY and
MOZILLA_OFFICIAL_BRANDING. This allows to accomodate various
combinations of official builds and 3rd party customizations.

I think we should use the same pattern in gaia.

> Anyway, this is too specific to be discussed on the list. Yuren, would
> you post the bug # to the thread so we could continue the discussion there?

We should discuss how to do things in bugs, not what to do...

[Tim Chien]

Right, let me get back to you once I figured out what exactly all these
variables do.

If they do what I think they do, supporting them would involving centralize
default prefs that scattered everywhere in the repo currently (sigh).

[Kevin Hu]

Hi, Josh,

How about 5pm Taipei Time = 10am Paris Time, next week?
Is there any other regions would like to join the call as well?

Yuren is the major owner to implement all the customization works.
I believe we can get good feedback from him. I will join the call as well.

Thanks.

Best regards,
Kevin Hu

----- Original Message -----

> From: "Josh Carpenter" <jcarp...@mozilla.com>
> To: "Kevin Hu" <k...@mozilla.com>
> Cc: "Yuren Ju" <y...@mozilla.com>, "Fabrice Desre"
> <fab...@mozilla.com>, dev-...@lists.mozilla.org,
> timd...@mozilla.com
> Sent: Thursday, February 28, 2013 3:43:08 AM
> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile &
> dedicated customization directory

> That sounds great, Kevin. I may be in Paris next week, FYI, so it
> will have to be a Euro-friendly time, if that works for you?

> —

> > > > > > On Wed, Feb 27, 2013 at 3:12 PM, Fabrice Desre <
> > > > >
> > > >
> > >
> >
>
> > > > > > fab...@mozilla.com

> > > > >
> > > >
> > >
> >
>

> > > > > > wrote:
> > > > >
> > > >
> > >
> >
>

> > > > > > > On 02/26/2013 10:45 PM, Tim Chien wrote:
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > > Please raise your concern if you have questions on the
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
> > > > > > > > direction
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > > we are
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > > heading.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > That's very nice! My only objection is about the name of
> > > > > > > the
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > environment
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > variables. Can we use only GAIA_XXX names? And in this
> > > > > > > case,
> > > > > >
> > > > >
> > > >
> > >
> >
>
> > > > > > > we
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > usually
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > call these customizations "brandind", so
> > > > > > > GAIA_BRANDING_PATH
> > > > > >
> > > > >
> > > >
> > >
> >
>
> > > > > > > would
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > be my
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > preferred name.
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > Fabrice
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > --
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > Fabrice Desré
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > b2g team
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > > Mozilla Corporation
> > > > > >
> > > > >
> > > >
> > >
> >
>

> > > > > > --
> > > > >
> > > >
> > >
> >
>

> > > > > > Tim Guan-tin Chien, Senior Front-end Dev., Mozilla Corp.
> > > > >
> > > >
> > >
> >
>
> > > > > > (Taiwan)
> > > > >
> > > >
> > >
> >
>

[Kevin Hu]

Maybe we can talk with Josh briefly, and we, of course, can continue discussing in mails.
We could have our conclusion in Wiki or etherpad, or any kind of documents, IMO.

Best regards,
Kevin Hu

----- Original Message -----
> From: "Fabrice Desre" <fab...@mozilla.com>
> To: "Kevin Hu" <k...@mozilla.com>
> Cc: "Josh Carpenter" <jcarp...@mozilla.com>, "Yuren Ju" <y...@mozilla.com>, dev-...@lists.mozilla.org,
> timd...@mozilla.com
> Sent: Thursday, February 28, 2013 1:23:04 AM
> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile & dedicated customization directory
>

> On 02/27/2013 09:07 AM, Kevin Hu wrote:
> > Hi, Josh,
> >
> > Maybe we can have a call next week to align the concepts among all
> > of us.
> > How is that?
>

> Phone calls limit people participation in general. Can we please keep
> that discussion on a public mailing list?
>
> thanks,
>

[Josh Carpenter]

Sounds good, Kevin. I will follow up on Monday once we know what the schedule for the week is.

—
Josh Carpenter
UX Designer
Mozilla

On Mar 1, 2013, at 8:45 AM, Kevin Hu <k...@mozilla.com> wrote:

> Hi, Josh,
>
> How about 5pm Taipei Time = 10am Paris Time, next week?
> Is there any other regions would like to join the call as well?
>
> Yuren is the major owner to implement all the customization works.
> I believe we can get good feedback from him. I will join the call as well.
>
> Thanks.
>
>
>
> Best regards,
> Kevin Hu
>

> From: "Josh Carpenter" <jcarp...@mozilla.com>
> To: "Kevin Hu" <k...@mozilla.com>
> Cc: "Yuren Ju" <y...@mozilla.com>, "Fabrice Desre" <fab...@mozilla.com>, dev-...@lists.mozilla.org, timd...@mozilla.com
> Sent: Thursday, February 28, 2013 3:43:08 AM
> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile & dedicated customization directory
>

> That sounds great, Kevin. I may be in Paris next week, FYI, so it will have to be a Euro-friendly time, if that works for you?
>
> —
> Josh Carpenter
> UX Designer
> Mozilla
>

> On Feb 27, 2013, at 6:07 PM, Kevin Hu <k...@mozilla.com> wrote:
>
> Hi, Josh,
>
> Maybe we can have a call next week to align the concepts among all of us.
> How is that?
>
>

> Best regards,
> Kevin Hu
>
> ----- Original Message -----

> From: "Kevin Hu" <k...@mozilla.com>
> To: "Josh Carpenter" <jcarp...@mozilla.com>
> Cc: "Yuren Ju" <y...@mozilla.com>, "Fabrice Desre" <fab...@mozilla.com>, dev-...@lists.mozilla.org,
> timd...@mozilla.com
> Sent: 2013年2月28日 星期四 1:03:20

> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile & dedicated customization directory
>

> Hi, Josh,
>
> Exactly! Customization is the final & an important key to launch
> Firefox OS, IMO.
> Thanks.
>

> Best regards,
> Kevin Hu
>
> ----- Original Message -----
>

> From: "Josh Carpenter" <jcarp...@mozilla.com>
> To: "Kevin Hu" <k...@mozilla.com>

> Cc: timd...@mozilla.com, "Yuren Ju" <y...@mozilla.com>, "Fabrice
> Desre" <fab...@mozilla.com>, dev-...@lists.mozilla.org
> Sent: 2013年2月27日 星期三 21:39:16

> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile &
> dedicated customization directory
>

> Sounds fantastic! I'm currently working on future-versions
> customization requirements, and it would be fantastic to get some
> of
> these new use cases baked into this new architecture. What's the
> best way to work with you guys on this? I'm happy to start by
> walking you through our current concepts and we can begin to work
> out what's possible. It's clear from MWC that customization and
> extension is a very important part of Firefox OS' future, so we
> should think carefully about how we go about this.
>
> —
> Josh Carpenter
> UX Designer
> Mozilla
>
> On Feb 27, 2013, at 9:19 AM, Kevin Hu < k...@mozilla.com > wrote:
>
> How about GAIA_CUSTOMIZE_PATH?
>
> I am fine either way, just a suggestion.
>
>

> Best regards,
>
> Kevin Hu
>
>
> ----- Original Message -----
>
>

> From: "Tim Chien" < timd...@mozilla.com >
>
>
> To: "Fabrice Desre" < fab...@mozilla.com >
>
>
> Cc: "Yuren Ju" < y...@mozilla.com >, dev-...@lists.mozilla.org
>
>
> Sent: 2013年2月27日 星期三 15:21:14
>
>

> Subject: Re: CUSTOMIZE environment variable for Gaia Makefile &
> dedicated customization directory
>
>
>

> That make sense, thanks! Yuren, could you change the variable?
>
>
>
> On Wed, Feb 27, 2013 at 3:12 PM, Fabrice Desre <
> fab...@mozilla.com
>
>
>
> wrote:
>
>
>
> On 02/26/2013 10:45 PM, Tim Chien wrote:
>
>
>
>
> Please raise your concern if you have questions on the
> direction
>
>
>
>
> we are
>
>
>
>
> heading.
>
>
>
>
>
> That's very nice! My only objection is about the name of the
>
>
>
> environment
>
>
>
> variables. Can we use only GAIA_XXX names? And in this case,
> we
>
>
>
> usually
>
>
>
> call these customizations "brandind", so GAIA_BRANDING_PATH
> would
>
>
>
> be my
>
>
>
> preferred name.
>
>
>
>

> Fabrice
>
>
>
> --
>
>
>
> Fabrice Desré
>
>
>
> b2g team
>
>
>
> Mozilla Corporation
>
>
>
>

[Yuren Ju]

I found fennec used /distribution/distribution.json for bookmarks and
preference customization.
https://wiki.mozilla.org/Mobile/Distribution_Files

and Firefox used /distribution/distribution.ini

we can use the same way on gaia, and keep MOZILLA_OFFICIAL,
MOZILLA_BRANDING_DIRECTORY and
MOZILLA_OFFICIAL_BRANDING only for branding.

On Fri, Mar 1, 2013 at 11:39 AM, Tim Chien <timd...@mozilla.com> wrote:

> Right, let me get back to you once I figured out what exactly all these
> variables do.
>
> If they do what I think they do, supporting them would involving
> centralize default prefs that scattered everywhere in the repo currently
> (sigh).
>
>
> On Fri, Mar 1, 2013 at 12:59 AM, Fabrice Desre <fab...@mozilla.com>wrote:
>
>> On 02/28/2013 04:19 AM, Tim Chien wrote:
>> > Fabrice,
>> >
>> > I thought "branding" is only about official Mozilla branding, which is
>> > being dealt with the variable "MOZILLA_OFFICIAL".
>> > As we are not touching that part of the build script, calling partner
>> > customization "branding" might cause some confusion among two?
>>
>> In gecko, we have MOZILLA_OFFICIAL, MOZILLA_BRANDING_DIRECTORY and
>> MOZILLA_OFFICIAL_BRANDING. This allows to accomodate various
>> combinations of official builds and 3rd party customizations.
>>
>> I think we should use the same pattern in gaia.
>>
>> > Anyway, this is too specific to be discussed on the list. Yuren, would
>> > you post the bug # to the thread so we could continue the discussion
>> there?
>>
>> We should discuss how to do things in bugs, not what to do...
>>