Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

PageInfo Bugs triage (part 3)

3 views
Skip to first unread message

Philip Chee

unread,
Jun 18, 2009, 6:05:54 AM6/18/09
to
<https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&product=SeaMonkey&component=Page+Info&bug_status=NEW&cmdtype=doit>

I plan to WONTFIX the following unless there are objections.

117353 Show underlying frames as hyperlinks in "Page Info"
** Extension fodder (there is an extension that does this).

131080 Request font and style and pt size to be added to page info
187354 column order cannot be changed on any tab
301835 Make title line similar to other lines

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

David E. Ross

unread,
Jun 18, 2009, 12:04:39 PM6/18/09
to
On 6/18/2009 3:05 AM, Philip Chee wrote:
> <https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&product=SeaMonkey&component=Page+Info&bug_status=NEW&cmdtype=doit>
>
> I plan to WONTFIX the following unless there are objections.
>
> 117353 Show underlying frames as hyperlinks in "Page Info"
> ** Extension fodder (there is an extension that does this).
>
> 131080 Request font and style and pt size to be added to page info
> 187354 column order cannot be changed on any tab
> 301835 Make title line similar to other lines
>
> Phil
>

301835: This merely requests the elimination of the colon (:) at the
end of the page title in the General tab.

For any other item in that tab, I can sweep my cursor across the entire
text to mark it and then copy it. Alternatively, I can triple-click on
the text to mark it.

For the page title, triple-clicking on the page title will include the
colon in the marked text. Instead, I must carefully sweep the cursor up
to -- but not including -- the colon before copying. With my old and
tired hands and eyes, this is not always easy. Sometimes, I stop the
sweep before the last non-colon character and must manually type it in;
other times, the sweep still includes the colon.

As pointed out in the bug report, this is an issue of consistency in the
tab's display. None of the other items on the tab end in colons. I
almost submitted this bug report with Severity as Minor or Trivial
instead of Enhancement because I really think this is a discrepancy in
the composition of the display and not a request for an enhancement.

Is it really so hard to fix?

--
David E. Ross
<http://www.rossde.com/>

Go to Mozdev at <http://www.mozdev.org/> for quick access to
extensions for Firefox, Thunderbird, SeaMonkey, and other
Mozilla-related applications. You can access Mozdev much
more quickly than you can Mozilla Add-Ons.

Philip Chee

unread,
Jun 18, 2009, 1:53:02 PM6/18/09
to
On Thu, 18 Jun 2009 09:04:39 -0700, David E. Ross wrote:

> 301835: This merely requests the elimination of the colon (:) at the
> end of the page title in the General tab.
>
> For any other item in that tab, I can sweep my cursor across the entire
> text to mark it and then copy it. Alternatively, I can triple-click on
> the text to mark it.
>
> For the page title, triple-clicking on the page title will include the
> colon in the marked text. Instead, I must carefully sweep the cursor up
> to -- but not including -- the colon before copying. With my old and
> tired hands and eyes, this is not always easy. Sometimes, I stop the
> sweep before the last non-colon character and must manually type it in;
> other times, the sweep still includes the colon.
>
> As pointed out in the bug report, this is an issue of consistency in the
> tab's display. None of the other items on the tab end in colons. I
> almost submitted this bug report with Severity as Minor or Trivial
> instead of Enhancement because I really think this is a discrepancy in
> the composition of the display and not a request for an enhancement.

"Patches welcome!"

> Is it really so hard to fix?

In fact this is trivially easy to fix. Since as you say you are "a
software professional for over 40 years (over 30 years as a software
test engineer)" This should be well within your capabilities. You don't
even need to learn javascript.

<http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/chrome/browser/pageInfo.properties#44>

Line #44 is:

pageTitle=%S:

Fire up your favourite text editor (must use unix newlines) remove the
trailing colon, create and submit a patch (preferred switches -U8p) and
ask for the patch to be reviewed.

By the way, we are all volunteers here. My free time is limited so I
have to prioritize. Currently I am working my way through this Page Info
bug:

<https://bugzilla.mozilla.org/show_bug.cgi?id=491310>

What about you?

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

[ ]You can lead a man to ponder; you cannot make him think!
* TagZilla 0.066.6

David E. Ross

unread,
Jun 18, 2009, 2:33:26 PM6/18/09
to

I've been retired for six years. As a test engineer, I wrote very
little code. The code that I did write mostly used interpretive
languages that required no compiling or linking (e.g., REXX, UNIX).
Also, the code I wrote was "disposable" (e.g., generators of test data)
without any configuration control.

Fixing code today (other than perhaps a UNIX script) would be quite
daunting. I definitely have no idea how to check-in a patch in your
system.

I am planning on getting broad-band service sometime this year. Perhaps
then I can help by testing because then I will be willing to download
nightlies, alphas, and betas.

Neil

unread,
Jun 18, 2009, 5:13:22 PM6/18/09
to
David E. Ross wrote:

>I've been retired for six years. As a test engineer, I wrote very little code. The code that I did write mostly used interpretive languages that required no compiling or linking (e.g., REXX, UNIX).
>

A useful part of the browser, the chrome, is effectively interpreted
(there is some caching and intermediate code generation). Chrome files
come in a few basic sorts; JavaScript, XUL, XBL, CSS, DTD and
properties, plus images (originally mostly GIF, but nowadays PNG). My
first patch appears to have also been a change to a properties file:

https://bugzilla.mozilla.org/attachment.cgi?id=42367

although as I grew more familiar with the technologies involved I
progressed to writing more complex patches including some in C++ where
necessary.

--
Warning: May contain traces of nuts.

Philip Chee

unread,
Jun 19, 2009, 12:24:15 AM6/19/09
to
On Thu, 18 Jun 2009 11:33:26 -0700, David E. Ross wrote:

> I've been retired for six years. As a test engineer, I wrote very
> little code. The code that I did write mostly used interpretive
> languages that required no compiling or linking (e.g., REXX, UNIX).

Javascript is an interpreted language that requires no compiling or linking.

> Also, the code I wrote was "disposable" (e.g., generators of test data)
> without any configuration control.

We definitely need more unit tests (mostly written in JS but might
involve (x)html, xul, and/or CSS.

> Fixing code today (other than perhaps a UNIX script) would be quite
> daunting. I definitely have no idea how to check-in a patch in your
> system.

Do what I do. Attach a patch to a bug. Ask for reviews. If approved I
set a keyword "checkin-needed" and then pray to Murphy that some kind
soul will come past and commit the patch into the tree.

> I am planning on getting broad-band service sometime this year. Perhaps
> then I can help by testing because then I will be willing to download
> nightlies, alphas, and betas.

Help with QA is always welcome!

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

[ ]I'm a programmer, I don't do COBOL.
* TagZilla 0.066.6

0 new messages