Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Firefox 3 RC - Lightbox / Modal Window Issue

1 view
Skip to first unread message

Clarky

unread,
Jun 16, 2008, 1:51:52 AM6/16/08
to
Hi, I had a look at the known issues in the Firefox release document
and I couldn't see anything listed there. Firefox 3 RC is not handling
Light Boxes / Modal Windows correctly on a new site we are developing.
The windows work fine in IE 6,7 and FF 2.X.

An example can be seen here: http://www.ahgsa.com.au/challenger_ford.php
if you click the map icon the modal window opens in full view, however
the same link works in the above browsers.

Is this something that is likely to be fixed with the final release,
or will we need to make some form of code change in order to have this
function correctly on the site?

Any help would be appreciated.

Thanks!

Question

unread,
Jun 16, 2008, 2:29:54 AM6/16/08
to Clarky, dev-apps...@lists.mozilla.org

> _______________________________________________
>

document.getElementsByClassName('modal1').each(function(link){
new Control.Modal(link,{
iframe: true,
width: 760,
height: 550
});
});

Maybe it's not work here. Debug your app, I think it must be some browser
sniffer codes doesn't work here.
& That's not a real modal window. It's an iframe.


--
Henny Youngman - "When I told my doctor I couldn't afford an operation, he
offered to touch-up my X-rays."

Philip Chee

unread,
Jun 16, 2008, 6:35:58 AM6/16/08
to
On Mon, 16 Jun 2008 14:29:54 +0800, Question wrote:
> On Mon, Jun 16, 2008 at 1:51 PM, Clarky <acl...@ahg.com.au> wrote:

>> Hi, I had a look at the known issues in the Firefox release document
>> and I couldn't see anything listed there. Firefox 3 RC is not handling
>> Light Boxes / Modal Windows correctly on a new site we are developing.
>> The windows work fine in IE 6,7 and FF 2.X.
>>
>> An example can be seen here: http://www.ahgsa.com.au/challenger_ford.php
>> if you click the map icon the modal window opens in full view, however
>> the same link works in the above browsers.
>

> document.getElementsByClassName('modal1').each(function(link){
> new Control.Modal(link,{
> iframe: true,
> width: 760,
> height: 550
> });
> });

I get these errors in the Error Console:

Error: document.getElementsByClassName("modal1").each is not a function
Source file: http://www.ahgsa.com.au/challenger_ford.php
Line: 370

Error: handler is undefined
Source file: http://www.ahgsa.com.au/includes/javascript/prototype.js
Line: 3877

For the first error, please note that .each() doesn't work on a nodeList
which is what getElementsByClassName() returns. Firefox now implements
this natively so the version provided by Prototype.js is ignored.

For the second it looks like an error coming from the prototype library
you are using. Perhaps you should upgrade to a newer version of
Prototype.js that works with Firefox 3?

Phil

--
Philip Chee <phi...@aleytys.pc.my>, <phili...@gmail.com>
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.

Mike Beltzner

unread,
Jun 16, 2008, 8:22:27 AM6/16/08
to Philip Chee, dev-apps...@lists.mozilla.org
On 16-Jun-08, at 6:35 AM, Philip Chee wrote:

> For the second it looks like an error coming from the prototype
> library
> you are using. Perhaps you should upgrade to a newer version of
> Prototype.js that works with Firefox 3?

Please note https://bugzilla.mozilla.org/show_bug.cgi?id=405903 and http://ejohn.org/blog/getelementsbyclassname-pre-prototype-16/

cheers,
mike

Clarky

unread,
Jun 16, 2008, 6:38:46 PM6/16/08
to
Thanks to everyone who replied! I will get our developer to make your
changes today and see how we go. Your help is appreciated.
0 new messages