Reload button should have middle click support (open same URL in new tab, clone tab)
Klaas Heidstra
functionality proposed in: https://bugzilla.mozilla.org/show_bug.cgi?id=263942
I will start it by repeating comment #12 from that bug:
Before Firefox 3 you could clone the current tab by middle-clicking
the url-bar
go-button. In Firefox 3 however the go-button doesn't appear until you
edit the
url, which makes it impossible to clone the current tab in a single
middle-click (because of that this could be called a regression
compared to
Firefox 2). This can be solved by making middle-click possible on the
reload-button.
What the patch from bug 263942 does is:
Shift+Reload-button reload page in current tab/window
bypassing the cache (just as before)
Ctrl+Reload-button current page in new tab,
selected*
Ctrl+Shift+Reload-button current page in new tab, in
background*
Middle on Reload-button same as Ctrl+Reload-button
Shift+Middle on Reload-button same as Ctrl+Shift+Reload-button
(*) This is reversed when you set the pref to load bookmark tabs in
the
background.
The question here is, do we want this to work in this way for Firefox.
Ido Beeri
to implant it.
Klaas Heidstra
the right-click context menu, but Gavin Sharp thinks that middle-click
on menuitems is undesirable. Currently when you middle/ctrl-click on
"View Background" in that menu it already opens in a new tab so I
think it would be consistent to do the same thing for "Reload"(and
Back/Forward see: bug 440702). What do people here think about this
functionality?
Shawn Wilsher
click on a context menuitem, so I think that'd be a bit weird to do.
Cheers,
Shawn
Mike Beltzner
So I'm pretty supportive of this generally, and it seems to be a good match for other ctrl+ accelerators we have in the product, but wanted to have a bit of discussion before we do it.
Also, another interesting thing to note is that nightlies will soon (or already?) allow us to do full tab re-parenting between windows, so now it's possible to:
- clone a tab
- clone a tab in a new window
One wonders if a shortcut for clone tab in new window might be appropriate, yet shift+ is taken. :)
cheers,
mike
> _______________________________________________
> dev-apps-firefox mailing list
> dev-apps...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-apps-firefox
Klaas Heidstra
> I don't believe I've ever seen any application that lets you middle
> click on a context menuitem, so I think that'd be a bit weird to do.
I agree that it is strange to support middle-clicking menuitems, but
it already works in that way for the history menu, back/forward
dropdown menu, bookmarks menu, the view bg image context item and
maybe more. Because of that I thought it was logical to do the same
for reload/back/forward items. Also middle-clicking the reload-context-
menuitem(what a word) makes it very easy to duplicate the current tab,
so the question I would like to ask: what are the disadvantages of
allowing this middle-clicking?
Klaas Heidstra
> Hey,
>
> So I'm pretty supportive of this generally, and it seems to be a good match for other ctrl+ accelerators we have in the product, but wanted to have a bit of discussion before we do it.
>
> Also, another interesting thing to note is that nightlies will soon (or already?) allow us to do full tab re-parenting between windows, so now it's possible to:
>
> - clone a tab
> - clone a tab in a new window
>
> One wonders if a shortcut for clone tab in new window might be appropriate, yet shift+ is taken. :)
>
> cheers,
> mike
I assume you mean this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=113934
, that only makes it possible to move a tab to another window not
clone it. In https://bugzilla.mozilla.org/show_bug.cgi?id=448546 I
have a (currently not so very nice) patch, which first clones the
current tab and then reloads or goes back/forward (depends on whether
you middle/ctrl-click the reload button or the back/forward buttons)
using the duplicateTab method.
When tab re-parenting gets checked in it can be used to solve bug
22568(Ability to detach/tear off tabs (Open a tab in a new window)),
for that you could use shortcuts like:
Ctrl+Shift+C - to clone a tab
Ctrl+Shift+N - to clone a tab in a new window
Ctrl+Shift+M - to move a tab to a new window(detach tab)
Ido Beeri
Cloning has nothing to do with reloading, plus cloning a tab should
also clone (besides scroll position, etc.) the tab's history. It'd
make more sense to clone the tab by dragging the tab on the Tab Bar
while pressing Ctrl.
About middle clocking the menu item, absolutely. Why not? Middle
clicking menu items already exist in Firefox, and it makes tab
browsing a lot more comfortable. It's pro-intuitive, and the only
reason it might look weird is because most programs don't support it.
Klaas Heidstra
On 5 aug, 19:09, Ido Beeri <fis...@gmail.com> wrote:
> The Reload button doesn't go well with simply cloning the tab IMO.
> ...
> reason it might look weird is because most programs don't support it.
What my patch in bug 448546 does is first clone the current tab when
you middle-click reload(yes with scroll position, history, form
contents etc..), and after it has cloned the current tab it will
reload the duplicated tab. This is possible because I use the
duplicateTab() method from nsISessionStore. For more information see:
https://bugzilla.mozilla.org/show_bug.cgi?id=448546
Cloning the tab by dragging the tab on the Tab Bar while pressing Ctrl
already works in Firefox and it also uses duplicateTab().
Klaas Heidstra
using alt together with clicking the reload, home or back/forward
button to save that page as... So I think maybe that behavior should
not apply to any UI links, what are the opinions here about that?
Klaas Heidstra
questions for the people here about middle/ctrl-clicking on the reload
button and the back/forward buttons:
1. When doing so, should the history from the original tab be
duplicated to the new tab?
2. When middlle/ctrl-clicking the reload button, should it reload the
duplicated tab after it is duplicated?
Mike Beltzner
> After some discussing in bug 448546 with Dão Gottwald I have some
> questions for the people here about middle/ctrl-clicking on the reload
> button and the back/forward buttons:
Whoa - who said anything about the back and forward buttons? Feature-
creep seems to be setting in here, and I don't think we need to try to
optimize the entire browser around a use case of wanting to duplicate
a tab.
> 1. When doing so, should the history from the original tab be
> duplicated to the new tab?
Mapping the control to reload, to me, doesn't imply that the tab is
being duplicated, it implies that the page/URL is being reloaded in a
new tab. The key there is "new" tab, which would not carry forward any
history or form content, IMO.
If we were to make the control to a "Duplicate Tab" function, I think
we'd want that to be on the context menu of the tab itself, and in
that case a new tab complete with history and form content should be
created.
> 2. When middlle/ctrl-clicking the reload button, should it reload the
> duplicated tab after it is duplicated?
Again, since we're mapping the command to the reload button, I would
think that middle clicking the reload button should:
- open a tab
- put the URL from the source tab into this new tab
- load that page
cheers,
mike
Mike Beltzner
> Whoa - who said anything about the back and forward buttons? Feature-
> creep seems to be setting in here, and I don't think we need to try to
> optimize the entire browser around a use case of wanting to duplicate
> a tab.
Of course, it's already in there, anyway ;) My responses below apply
to both middle click on reload and back/forward, though.
cheers,
mike
>
>
>> 1. When doing so, should the history from the original tab be
>> duplicated to the new tab?
>
> Mapping the control to reload, to me, doesn't imply that the tab is
> being duplicated, it implies that the page/URL is being reloaded in a
> new tab. The key there is "new" tab, which would not carry forward any
> history or form content, IMO.
>
> If we were to make the control to a "Duplicate Tab" function, I think
> we'd want that to be on the context menu of the tab itself, and in
> that case a new tab complete with history and form content should be
> created.
>
>> 2. When middlle/ctrl-clicking the reload button, should it reload the
>> duplicated tab after it is duplicated?
>
> Again, since we're mapping the command to the reload button, I would
> think that middle clicking the reload button should:
> - open a tab
> - put the URL from the source tab into this new tab
> - load that page
>
> cheers,
> mike
Klaas Heidstra
> On 6-Aug-08, at 9:13 AM, Klaas Heidstra wrote:
>
> > After some discussing in bug 448546 with Dão Gottwald I have some
> > questions for the people here about middle/ctrl-clicking on the reload
> > button and the back/forward buttons:
>
> Whoa - who said anything about the back and forward buttons? Feature-
> creep seems to be setting in here, and I don't think we need to try to
> optimize the entire browser around a use case of wanting to duplicate
> a tab.
buttons to duplicate it, the first reaction is: "too bad it doesn't
have the same history", that's why opened bug 448546.
> Again, since we're mapping the command to the reload button, I would
> think that middle clicking the reload button should:
> - open a tab
> - put the URL from the source tab into this new tab
> - load that page
Okay, this is exactly what the current patch in bug 263942 does.
Klaas Heidstra
only remaining issue about it is middle-clicking on reload in the
context menu to open a new tab.
Mike do you think this should be possible or not?