SMTP authentication for Bugzilla

[Frédéric Buclin]

Hi all,

I attached a patch to bug 304005 which implements SMTP authentication
support for Bugzilla:

https://bugzilla.mozilla.org/show_bug.cgi?id=304005

As I don't use SMTP auth myself, I have no way to test it. If that's a
feature you expected for a long time, I suggest you test my patch and
give me your feedback in the bug itself.

To have it work, apply the patch (-p0) to a recent development snapshot
(e.g. Bugzilla 3.1.3 or better. The patch won't work on Bugzilla 3.0.x
as is; you will have to backport it), run checksetup.pl and go to the
"Email" panel in the "Parameters" page. You will see two new fields for
the username and password required by the SMTP server.

LpSolit
-
To view or change your list settings, click here:
<http://bugzilla.org/cgi-bin/mj_wwwusr?user=dev-apps...@lists.mozilla.org>

[Frédéric Buclin]

newbug a écrit :
> thanx LpSolit,
> I hope this will work, but I am little confused about how to apply the
> patch. will you please detail the steps for applying the patch? I hope
> you'll help me out.

Did you manage to apply the patch following vladd's instructions?

[Frédéric Buclin]

newbug a écrit :
> 'patch' is not recognized as an internal or external command, operable
> program or batch file.

Did you download and install patch.exe first?

http://gnuwin32.sourceforge.net/packages/patch.htm

You can install it in WINNT or WINNT/system32 or whatever the name on XP is.

LpSolit

[Guy Pyrzak]

Vlad's instructions mention if you're on windows you'll need to download a
patch utility:

If you're on a Windows platform and don't have access to the "patch"
executable, you can get it from here:
http://gnuwin32.sourceforge.net/
( http://getgnuwin32.sourceforge.net/ )

On Wed, Mar 12, 2008 at 1:59 AM, newbug <shab...@hotmail.com> wrote:

>
> I have downloaded the patch file. i.e. bug1289-cvs.diff, on widowsXP. but
> when I give the command in Bugzilla directory
>
> patch -p0 < bug1289-cvs.diff
>
> I get the following message

>
> 'patch' is not recognized as an internal or external command, operable
> program or batch file.
>

> moreover, I could not find "patch" file or utility in Bugzilla directory.
>
> Plz guide me to resolve this issue. Im using WindowsXP professional.
>
>
>
> --
> View this message in context:
> http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16000143.html
> Sent from the Bugzilla - Dev mailing list archive at Nabble.com.

>
> -
> To view or change your list settings, click here:

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=guy.p...@gmail.com>
>

[Frédéric Buclin]

Just so that you know, I checked in the "SMTP authentication support"
patch a few minutes ago, and so Bugzilla will support it in its coming
3.1.4 release (a development snapshot, not ready yet for production).
There is no plan to backport it on 3.0.x as it's an enhancement, not a
bugfix.

LpSolit

-
To view or change your list settings, click here:

<http://bugzilla.org/cgi-bin/mj_wwwusr?user=dev-apps...@lists.mozilla.org>

[Atsushi Shimono]

hi,,

On Fri, Mar 14, 2008 at 9:14 AM, Frédéric Buclin <lps...@gmail.com> wrote:
> Just so that you know, I checked in the "SMTP authentication support"
> patch a few minutes ago, and so Bugzilla will support it in its coming
> 3.1.4 release (a development snapshot, not ready yet for production).
> There is no plan to backport it on 3.0.x as it's an enhancement, not a
> bugfix.

sorry for my too late responce.. :p
# as asked on irc.

so, it's ok to knock or postpone my test?

regards,,
--
Atsushi Shimono - shi...@mozilla.gr.jp
http://www.mozilla.gr.jp/~shimono/blog/

[Frédéric Buclin]

newbug a écrit :
> now plz tell me what to do? I'll be thankful to you guys if you make me
> through it

The problem is that my patch has the LF line endings used on *nix while
patch.exe on Windows needs to have a patch using CRLF as line endings,
else it's unable to read the patch correctly (it sees everything as a
single line, AFAIK). So either convert my patch to DOS format (i.e. with
CRLF line endings) or upgrade your installation using CVS to get the
SMTP auth support.

If you don't know how to do this, I can send you an unofficial
bugzilla-CVS.tar.bz2 tarball per email (940 Kb), for testing.

LpSolit

[Max Kanat-Alexander]

On Fri, 14 Mar 2008 11:51:51 +0100 Frédéric Buclin <lps...@gmail.com>
wrote:

> So either convert my patch to
> DOS format (i.e. with CRLF line endings) or upgrade your installation
> using CVS to get the SMTP auth support.

Or use the --binary switch to the Windows "patch" command,
which will make it work with LF line endings.

-Max
--
http://www.everythingsolved.com/
Competent, Friendly Bugzilla and Perl Services. Everything Else, too.

[Max Kanat-Alexander]

On Sat, 15 Mar 2008 00:27:54 -0700 (PDT) newbug <shab...@hotmail.com>
wrote:
> are you saying that I use the command in this format:
> patch -p0 -binary < bug1289-cvs.diff

Yes. Although I think it might be --binary, not -binary.

[newbug]

thanx LpSolit,
I hope this will work, but I am little confused about how to apply the
patch. will you please detail the steps for applying the patch? I hope
you'll help me out.

Regards

Frédéric Buclin wrote:
>
> Hi all,
>
> I attached a patch to bug 304005 which implements SMTP authentication
> support for Bugzilla:
>
> https://bugzilla.mozilla.org/show_bug.cgi?id=304005
>
> As I don't use SMTP auth myself, I have no way to test it. If that's a
> feature you expected for a long time, I suggest you test my patch and
> give me your feedback in the bug itself.
>
> To have it work, apply the patch (-p0) to a recent development snapshot
> (e.g. Bugzilla 3.1.3 or better. The patch won't work on Bugzilla 3.0.x
> as is; you will have to backport it), run checksetup.pl and go to the
> "Email" panel in the "Parameters" page. You will see two new fields for
> the username and password required by the SMTP server.
>
> LpSolit

> -
> To view or change your list settings, click here:

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=li...@nabble.com>
>
>

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p15975860.html

Sent from the Bugzilla - Dev mailing list archive at Nabble.com.

-

[newbug]

I have downloaded the patch file. i.e. bug1289-cvs.diff, on widowsXP. but
when I give the command in Bugzilla directory

patch -p0 < bug1289-cvs.diff

I get the following message

'patch' is not recognized as an internal or external command, operable
program or batch file.

moreover, I could not find "patch" file or utility in Bugzilla directory.

Plz guide me to resolve this issue. Im using WindowsXP professional.

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16000143.html

[newbug]

Hello Max,

are you saying that I use the command in this format:
patch -p0 -binary < bug1289-cvs.diff

or what, plz explain.

Max Kanat-Alexander wrote:
>
> On Fri, 14 Mar 2008 11:51:51 +0100 Frédéric Buclin <lps...@gmail.com>
> wrote:
>> So either convert my patch to
>> DOS format (i.e. with CRLF line endings) or upgrade your installation
>> using CVS to get the SMTP auth support.
>
> Or use the --binary switch to the Windows "patch" command,
> which will make it work with LF line endings.
>

> -Max
> --
> http://www.everythingsolved.com/
> Competent, Friendly Bugzilla and Perl Services. Everything Else, too.

> -
> To view or change your list settings, click here:

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=li...@nabble.com>
>
>

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16065383.html

[newbug]

thanx, I got downloaded the patch utility but when I applied the patch, it
accepted 2 files but when I entered third file it gave the following message
and patch could not run successfully...

File to patch: c:/bugzilla/bugzilla/config/common.pm
patching file c:/bugzilla/bugzilla/config/common.pm
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file
c:/bugzilla/bugzilla/config/com
mon.pm.rej
missing header for unified diff at line 67 of patch
can't find file to patch at input line 67
Perhaps you used the wrong -p or --strip option?
File to patch: c:/bugzilla/bugzilla/Config/common.pm
patching file c:/bugzilla/bugzilla/Config/common.pm
Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354

This application has requested the Runtime to terminate it in an unusual
way.
Please contact the application's support team for more information.

now plz tell me what to do? I'll be thankful to you guys if you make me
through it

Regards

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16044732.html

[newbug]

Dear Frederic Buclin,
can you kindly tell me how to convert the patch to DOS format(ie. with CRLF
line endings). although I have updated from CVS but SMTP auth could not be
updated or I was missing something in update commond for SMTP auth, that you
can point out.
if your unofficial version is okay i.e. I can use it for my office
environment, then my email address is sha...@uffaq.com
but plz do confirm me how to combine the tarball files in one bugzilla,
shall I extract all the files to one bugzilla folder ? as you said that
you'll send in parts.
I'll be happy to hear any guidelines from you.

Regards

Frédéric Buclin wrote:
>
> newbug a écrit :

>> now plz tell me what to do? I'll be thankful to you guys if you make me
>> through it
>

> The problem is that my patch has the LF line endings used on *nix while
> patch.exe on Windows needs to have a patch using CRLF as line endings,
> else it's unable to read the patch correctly (it sees everything as a

> single line, AFAIK). So either convert my patch to DOS format (i.e. with

> CRLF line endings) or upgrade your installation using CVS to get the
> SMTP auth support.
>

> If you don't know how to do this, I can send you an unofficial
> bugzilla-CVS.tar.bz2 tarball per email (940 Kb), for testing.
>
> LpSolit

> -
> To view or change your list settings, click here:

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=li...@nabble.com>
>
>

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16065362.html

[Tosh, Michael J]

newbug wrote:
> Dear Frederic Buclin,
> can you kindly tell me how to convert the patch to DOS format(ie.
> with CRLF line endings).

One hack is to open the file with WinWord, then save/as and change the
format to MS-DOS. That will add the \r to your \n's.

[newbug]

hi Fredric,
perhaps you were too busy to reply my post, anyway I download your second
patch and applied it after having converted it in DOS format. but when I run
the commond
perl checksetup.pl

I get the following message

...........................
Subroutine check_notification redefined at Bugzilla/Config/common.pm line
323.
Subroutine check_timezone redefined at Bugzilla/Config/common.pm line 336.
Subroutine check_smtp_auth redefined at Bugzilla/Config/common.pm line 344.
Subroutine get_param_list redefined at Bugzilla/Config/common.pm line 412.
Can't locate object method "get_param_list" via package
"Bugzilla::Config::commo
n" at Bugzilla/Config.pm line 58.

and that's why when I click the "parameters" link on bugzilla interface, I
get the following error:
Software error:
Can't locate object method "get_param_list" via package
"Bugzilla::Config::common" at C:/Bugzilla/editparams.cgi line 60.

now plz tell me what to do, as Im unable to work with the patch.

Regards

Frédéric Buclin wrote:
>
> newbug a écrit :
>> now plz tell me what to do? I'll be thankful to you guys if you make me
>> through it
>
> The problem is that my patch has the LF line endings used on *nix while
> patch.exe on Windows needs to have a patch using CRLF as line endings,
> else it's unable to read the patch correctly (it sees everything as a
> single line, AFAIK). So either convert my patch to DOS format (i.e. with
> CRLF line endings) or upgrade your installation using CVS to get the
> SMTP auth support.
>
> If you don't know how to do this, I can send you an unofficial
> bugzilla-CVS.tar.bz2 tarball per email (940 Kb), for testing.
>
> LpSolit

> -
> To view or change your list settings, click here:

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=li...@nabble.com>
>
>

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16114454.html

Sent from the Bugzilla - Dev mailing list archive at Nabble.com.

-

[Frédéric Buclin]

If you downloaded my patch but you run Bugzilla 3.0.3, this would
explain why you get errors. As I said, my patch won't work with Bugzilla
3.0.3; you have to backport it.

Now if you use current CVS HEAD code (3.1.3+), you don't need to apply
my patch anymore. It's already in the Bugzilla code. All you have to do
is to run checksetup.pl again and you will then see the two new parameters.

If you have more questions, I suggest you join us on IRC in the
#mozwebtools channel on irc.mozilla.org. It will be much easier to help
you and won't spam other members of this mailing-list. I'm there for the
next 2-3 hours and most of the days this week.

(I note your email has been in the queue for one week, explaining this
long delay to respond.)

LpSolit
-
To view or change your list settings, click here:

<http://bugzilla.org/cgi-bin/mj_wwwusr?user=dev-apps...@lists.mozilla.org>

[Balin...@gmail.com]

I already patched this fill,but program throw exception in
post_bug.cgi.

Bugzilla has suffered an internal error. Please save this page and
send it to f...@tsingsoft.com.cn with details of what you were doing at
the time this message appeared.

URL: http://192.168.0.203/bugzilla/post_bug.cgi

undef error - Wide character in syswrite at /usr/lib/perl5/5.8.5/Net/
Cmd.pm line 436.

I input the chinese in body.

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=dev-apps-bugzi...@lists.mozilla.org>

[newbug]

hi Buclin,
no, I downloaded bugzilla 3.1.3 and used your patch but it failed, Im trying
to come on your IRC but its not opening...perhaps your IRC server is down or
else ?
can you plz tell me how to get 3.1.4 or how to upgrade from 3.1.3 as I used
the following commond to upgrade
C:\Bugzilla>cvs update -R -d -rBugzilla_Stable

but it did not make any change in Email interface, there was no
smtp_username or smtp_password entry in the browser.
I'll try to contact you on IRC, if the page gets opened.

Frédéric Buclin wrote:
>
> If you downloaded my patch but you run Bugzilla 3.0.3, this would
> explain why you get errors. As I said, my patch won't work with Bugzilla
> 3.0.3; you have to backport it.
>
> Now if you use current CVS HEAD code (3.1.3+), you don't need to apply
> my patch anymore. It's already in the Bugzilla code. All you have to do
> is to run checksetup.pl again and you will then see the two new
> parameters.
>
> If you have more questions, I suggest you join us on IRC in the
> #mozwebtools channel on irc.mozilla.org. It will be much easier to help
> you and won't spam other members of this mailing-list. I'm there for the
> next 2-3 hours and most of the days this week.
>
> (I note your email has been in the queue for one week, explaining this
> long delay to respond.)
>
> LpSolit
> -
> To view or change your list settings, click here:

> <http://bugzilla.org/cgi-bin/mj_wwwusr?user=li...@nabble.com>
>
>

--
View this message in context: http://www.nabble.com/SMTP-authentication-for-Bugzilla-tp15969908p16274115.html

Sent from the Bugzilla - Dev mailing list archive at Nabble.com.

-

To view or change your list settings, click here:

<http://bugzilla.org/cgi-bin/mj_wwwusr?user=dev-apps...@lists.mozilla.org>

[Frédéric Buclin]

newbug a écrit :

> C:\Bugzilla>cvs update -R -d -rBugzilla_Stable

Type:

cvs -q checkout -AP Bugzilla

Bugzilla_Stable will point to the 3.0 branch, which is not what you want.