widget causing addon bar to show for new windows

12 views
Skip to first unread message

Dan

unread,
May 5, 2011, 10:59:07 AM5/5/11
to mozilla-labs-jetpack
My widget is causing the addon bar to appear every time a new window
is opened even if it is closed in all existing windows. Is there any
way to prevent that?

KWierso

unread,
May 5, 2011, 11:16:52 AM5/5/11
to mozilla-labs-jetpack
I believe once SDK 1.0b5 comes out, if you repackage your addon with
that SDK release, this should be fixed and work as you expect it to.

Hernan Rodriguez Colmeiro

unread,
May 5, 2011, 5:59:13 PM5/5/11
to mozilla-la...@googlegroups.com
Yes, as KWierso says, it was a known bug in a previous SDK release
that is now fixed.

Hernán

> --
> You received this message because you are subscribed to the Google Groups "mozilla-labs-jetpack" group.
> To post to this group, send email to mozilla-la...@googlegroups.com.
> To unsubscribe from this group, send email to mozilla-labs-jet...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/mozilla-labs-jetpack?hl=en.
>
>

KWierso

unread,
May 5, 2011, 7:21:59 PM5/5/11
to mozilla-labs-jetpack
And as it so happens, 1.0b5 is out today. So if you re-build your
addon with the new SDK, it should pick up the fixes for widgets.

On May 5, 4:59 pm, Hernan Rodriguez Colmeiro <colme...@gmail.com>
wrote:

Dan

unread,
May 8, 2011, 9:54:04 PM5/8/11
to mozilla-la...@googlegroups.com
Thanks.  Just tried with 1.0b5 and unfortunately I'm still seeing the issue.  The add on bar is always shown with every new window.

Hernan Rodriguez Colmeiro

unread,
May 9, 2011, 2:36:05 PM5/9/11
to mozilla-la...@googlegroups.com
On Sun, May 8, 2011 at 18:54, Dan <mr.dan....@gmail.com> wrote:
> Thanks.  Just tried with 1.0b5 and unfortunately I'm still seeing the
> issue.  The add on bar is always shown with every new window.
>

Did you try installing the addon in a clean profile or with all the
other addons disabled? Maybe you have another addon built with an old
SDK that is triggering the issue.

Hernán

Alexandre poirot

unread,
May 9, 2011, 3:15:09 PM5/9/11
to mozilla-la...@googlegroups.com
Something appears to be wrong with the addon-bar, again.
We have a lot of unit test checking that critical point but in real world,
I'm not able to hide the addon bar.

Hernán: are you able to hide it definitively in some way ?

Dan: Thanks for the report, I'm going to dig into this and keep you in touch.


2011/5/9 Hernan Rodriguez Colmeiro <colm...@gmail.com>

Hernan Rodriguez Colmeiro

unread,
May 9, 2011, 3:25:38 PM5/9/11
to mozilla-la...@googlegroups.com
On Mon, May 9, 2011 at 12:15, Alexandre poirot <poiro...@gmail.com> wrote:
> Something appears to be wrong with the addon-bar, again.
> We have a lot of unit test checking that critical point but in real world,
> I'm not able to hide the addon bar.
>
> Hernán: are you able to hide it definitively in some way ?
>

I think I was able to do so. At least I have no bug reports on my main
addon that uses the addon bar. I'll try to test it better tonight.

Hernán

Dan

unread,
May 9, 2011, 3:29:46 PM5/9/11
to mozilla-la...@googlegroups.com
Thanks Alexandre.

Hernán, to answer your question, I am seeing the issue when using "cfx run", which uses a clean profile.

Hernan Rodriguez Colmeiro

unread,
May 9, 2011, 3:31:51 PM5/9/11
to mozilla-la...@googlegroups.com
On Mon, May 9, 2011 at 12:29, Dan <mr.dan....@gmail.com> wrote:
> Hernán, to answer your question, I am seeing the issue when using "cfx run",
> which uses a clean profile.
>

Great to know that, now we might be facing a nice new regression!

Hernán

Alexandre poirot

unread,
May 11, 2011, 11:05:47 AM5/11/11
to mozilla-la...@googlegroups.com
I've just sent a patch to fix this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=656298

You can apply this patch or wait for the 1.0 release that is coming in late June.


2011/5/9 Hernan Rodriguez Colmeiro <colm...@gmail.com>
On Mon, May 9, 2011 at 12:29, Dan <mr.dan....@gmail.com> wrote:

Dan

unread,
May 11, 2011, 12:22:41 PM5/11/11
to mozilla-la...@googlegroups.com
Yep.  That fixed it.  Thanks.

Alexandre poirot

unread,
May 16, 2011, 12:52:54 PM5/16/11
to mozilla-la...@googlegroups.com
A quick followup to say that this bug has been reviewed and commited,
so it is going to be fixed in 1.0 release.


2011/5/11 Dan <mr.dan....@gmail.com>
Yep.  That fixed it.  Thanks.

--
Reply all
Reply to author
Forward
0 new messages