Website update

[Thomas Bassetto]

Hi,

It's nice to see Jetpack 0.6 alive, but now it's time to update
https://jetpack.mozillalabs.com :)
It is still written "Latest News » Jetpack 0.4 is now out!". On the
trunk it's written "Jetpack 0.5 has lifted off!"!

So, I have updated the website/ folder on my Jetpack repository clone.
What I've done:
-updated index.html to make it W3C-compliant and updated the link to
Jetpack 0.6 announcement.
-updated css/screen.css to add "img {border: 0;}" and 2 more rules
-updated graph.js => line 34, "170" is much better on my screen than
"175". Otherwise, I see a white border on the right. What about you?
I'm using Mac OS 10.5 in French.
-updated gmail-checker.js => once more "width: 16" work better than
"width: 20" on my machine.
-updated trim.js => once more "width: 38" work better than "width: 50"
on my machine.
-updated notepack.js => the time was not managed neatly for non-US
operating system.
-updated quicktab.js => Since Jetpack 0.5, .hide() doesn't work as
expected on this jetpack. The fadeIn(500) command is not applied so
the hidden elements remain hidden... Therefore, I removed the .hide()
command. Unfortunately a new bug appeared with .offest() so the
jetpack still not work... =>
https://bugzilla.mozilla.org/show_bug.cgi?id=527294
-updated page-mod-blacklist-sites.js to work with the new sandbox.

What's next? Should I create a bug for each modified file (I hope
not). Which tool use in order to create a patch? The diff command
line?

Regards,
Thomas

[Paul O’Shannessy]

On Nov 8, 10:59 am, Thomas Bassetto <tbasse...@gmail.com> wrote:
> Hi,
>

> It's nice to see Jetpack 0.6 alive, but now it's time to updatehttps://jetpack.mozillalabs.com:)

> It is still written "Latest News »  Jetpack 0.4 is now out!". On the
> trunk it's written "Jetpack 0.5 has lifted off!"!
>
> So, I have updated the website/ folder on my Jetpack repository clone.
> What I've done:
> -updated index.html to make it W3C-compliant and updated the link to
> Jetpack 0.6 announcement.
> -updated css/screen.css to add "img {border: 0;}" and 2 more rules
> -updated graph.js => line 34, "170" is much better on my screen than
> "175". Otherwise, I see a white border on the right. What about you?
> I'm using Mac OS 10.5 in French.
> -updated gmail-checker.js => once more "width: 16" work better than
> "width: 20" on my machine.
> -updated trim.js => once more "width: 38" work better than "width: 50"
> on my machine.
> -updated notepack.js => the time was not managed neatly for non-US
> operating system.
> -updated quicktab.js => Since Jetpack 0.5, .hide() doesn't work as
> expected on this jetpack. The fadeIn(500) command is not applied so
> the hidden elements remain hidden... Therefore, I removed the .hide()
> command. Unfortunately a new bug appeared with .offest() so the
> jetpack still not work... =>https://bugzilla.mozilla.org/show_bug.cgi?id=527294
> -updated page-mod-blacklist-sites.js to work with the new sandbox.

Great work!

> What's next? Should I create a bug for each modified file (I hope
> not). Which tool use in order to create a patch? The diff command
> line?

So the "Firefox" workflow would involve bugs for each modification
(not necessarily each file, we could lump a bunch of those together as
"fix jetpack sizes"). The "Labs" workflow is a bit less rigorous.
Publishing your hg repository somewhere (perhaps bitbucket.org) where
you've hopefully committed each above item separately and letting us
know will should be good enough. We'll pull in the changesets to the
main repository. Just let us know where you've published your branch.
This is how hg handles named branches - similar to the concept of
forking. It's not quite as sexy as Github's forking, but it works.

Alternatively yes, you could just do a diff (either "diff", or "hg
diff"). Make sure you followup here. Even better would be to talk to
us on IRC (irc.mozilla.org in #jetpack). Most of the people who work
on Jetpack hang out there and those with commit access can help to
make sure things go smoothly.

Thanks for taking the initiative to fix these things!

[Thomas Bassetto]

I see that the site is now up to date (with a link to Jetpack 0.6)!
However, some demos are still broken with 0.6. I tried to use
bitbucket to release my (small) fixes:
http://bitbucket.org/tbassetto/jetpack-clone/overview/

Maybe I should have clone the entire Jetpack repository and create a branch?!

Regards,
Thomas

2009/11/9 Paul O’Shannessy <pa...@oshannessy.com>:

--
Thomas Bassetto — tb4.fr
Élève-ingénieur de l'INSA de Rouen en Architecture des Systèmes
d'Information — 5ème année

[Aza]

Hi Thomas,

Are these fixes up-to-date? If so, I'd love to import/patch them. I've never done an import like this before (from a live tree), but I do know how to do a patch file import.

-- aza | ɐzɐ --

[Thomas Bassetto]

Hi,

I've tested again all demos with the Jetpack trunk.

Status bar bugs seem to have disappeared. However, notepack.js,
quicktab.js and page-mod-blacklist-sites.js are still broken.

I made two more commits: I commented a line on quicktab.js (.offset()
is still broken). Without it, the script works.
And I fixed a typo introduced by a previous comit on notepack.js.

Regards,
Thomas

2009/11/16 Aza <aza...@gmail.com>:

[Aza]

Thanks to Edi Lee, these changes have been commited!

http://hg.mozilla.org/labs/jetpack/

In the future, please make a full clone of the repo, as it was a lot of extra work to merge from a copy of part of the repo. Thanks, Thomas.

-- aza | ɐzɐ --