Gmail Calendar Documents Reader Web more »
Recently Visited Groups | Help | Sign in
Google Groups Home
Fx.accordion Error When using alwaysHide: true
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  12 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Jeremy B  
View profile  
 More options Oct 21, 10:00 am
From: Jeremy B <jbue...@gmail.com>
Date: Wed, 21 Oct 2009 07:00:39 -0700
Local: Wed, Oct 21 2009 10:00 am
Subject: Fx.accordion Error When using alwaysHide: true

I am getting an error when trying to create a nested accordion and trying to
make it so you can close all of the accordion panels.

I have posted a sample on mooshell:
http://mooshell.net/kxYpt/

This is the error I am getting in firebug:

el is undefined
file:///mootools-1.2.4.1-more.js
Line 221

This is line 221 in my mootoos-more.js file
221 el.setStyle('height', 'auto');

It seems like it may be a bug, but I am not entirely sure, perhaps is it due
to me trying to nest accordions?
Any help is greatly appreciated,
Jeremy


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Piotr Zalewa  
View profile  
 More options Oct 23, 9:32 am
From: Piotr Zalewa <zal...@gmail.com>
Date: Fri, 23 Oct 2009 14:32:14 +0100
Local: Fri, Oct 23 2009 9:32 am
Subject: Re: [Moo] Fx.accordion Error When using alwaysHide: true

code simplified a bit
the problem is with the display: -1
don't even know if it is the right usage - it's working if commented out
http://mooshell.net/kxYpt/1

zalun
--
London, UK


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Oskar Krawczyk  
View profile  
 More options Oct 23, 10:44 am
From: Oskar Krawczyk <oskar.krawc...@gmail.com>
Date: Fri, 23 Oct 2009 15:44:52 +0100
Local: Fri, Oct 23 2009 10:44 am
Subject: Re: [Moo] Fx.accordion Error When using alwaysHide: true

Yup, a bug inside the .display method:

if (this.options.returnHeightToAuto) {
        var el = this.elements[index];
        el.setStyle('height', 'auto');

};

Needs to be changed to:

if (this.options.returnHeightToAuto && index >= 0) {
        var el = this.elements[index];
        el.setStyle('height', 'auto');

};

On 21 Oct 2009, at 15:00, Jeremy B wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Aaron Newton  
View profile  
 More options Oct 23, 3:45 pm
From: Aaron Newton <aa...@iminta.com>
Date: Fri, 23 Oct 2009 12:45:09 -0700
Local: Fri, Oct 23 2009 3:45 pm
Subject: Re: [Moo] Re: Fx.accordion Error When using alwaysHide: true

will fix for next release. hopefully monday.

On Fri, Oct 23, 2009 at 7:44 AM, Oskar Krawczyk <oskar.krawc...@gmail.com>wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Oskar Krawczyk  
View profile  
 More options Oct 23, 3:51 pm
From: Oskar Krawczyk <oskar.krawc...@gmail.com>
Date: Fri, 23 Oct 2009 20:51:57 +0100
Local: Fri, Oct 23 2009 3:51 pm
Subject: Re: [Moo] Re: Fx.accordion Error When using alwaysHide: true

I've already requested a pull with the fix...

On 23 Oct 2009, at 20:45, Aaron Newton wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Aaron Newton  
View profile  
 More options Oct 23, 3:55 pm
From: Aaron Newton <aa...@iminta.com>
Date: Fri, 23 Oct 2009 12:55:21 -0700
Local: Fri, Oct 23 2009 3:55 pm
Subject: Re: [Moo] Re: Fx.accordion Error When using alwaysHide: true

dangit. I didn't see it. I just implemented it. I'll resolve it.

On Fri, Oct 23, 2009 at 12:51 PM, Oskar Krawczyk
<oskar.krawc...@gmail.com>wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Steve Onnis  
View profile  
 More options Oct 23, 7:15 pm
From: "Steve Onnis" <st...@cfcentral.com.au>
Date: Sat, 24 Oct 2009 10:15:04 +1100
Local: Fri, Oct 23 2009 7:15 pm
Subject: RE: [Moo] Re: Fx.accordion Error When using alwaysHide: true
I use

display : null


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
soundseller  
View profile  
 More options Oct 24, 8:19 am
From: soundseller <soundsel...@googlemail.com>
Date: Sat, 24 Oct 2009 05:19:09 -0700 (PDT)
Local: Sat, Oct 24 2009 8:19 am
Subject: Re: Fx.accordion Error When using alwaysHide: true
@oscar I tried your fix but
 it still does not work as expected.
If I try to close all elements, the accordion snaps open again.
Any ideas?
I use following code:
var accordion = new Accordion($$('.toggler'),$$('.element'), {
                opacity: 0,
                alwaysHide: true,
                onActive: function(toggler) { toggler.setStyle('color',
'#000000'); },
                onBackground: function(toggler) { toggler.setStyle('color',
'#666666'); }
        });

On Oct 24, 3:15 am, "Steve Onnis" <st...@cfcentral.com.au> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jeremy B  
View profile  
 More options Oct 24, 11:34 am
From: Jeremy B <jbue...@gmail.com>
Date: Sat, 24 Oct 2009 08:34:13 -0700
Local: Sat, Oct 24 2009 11:34 am
Subject: Re: [Moo] Re: Fx.accordion Error When using alwaysHide: true

Yeah I put the fix into my mootools-more and the JS error is gone, but the
accordion does snap back open after it closes.

Jeremy Bueler
www.jbueler.com

On Sat, Oct 24, 2009 at 5:19 AM, soundseller <soundsel...@googlemail.com>wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
davidck  
View profile  
 More options Oct 24, 1:08 pm
From: davidck <davi...@gmail.com>
Date: Sat, 24 Oct 2009 10:08:35 -0700 (PDT)
Local: Sat, Oct 24 2009 1:08 pm
Subject: Re: Fx.accordion Error When using alwaysHide: true
Jeremy, I noticed the issue you pointed out as well.

I fixed it by setting the new option returnHeightToAuto to true or
false. Forgot which one, basically the opposite of the default boolean
value.

On Oct 24, 11:34 am, Jeremy B <jbue...@gmail.com> wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Oskar Krawczyk  
View profile  
 More options Oct 24, 1:34 pm
From: Oskar Krawczyk <oskar.krawc...@gmail.com>
Date: Sat, 24 Oct 2009 18:34:20 +0100
Local: Sat, Oct 24 2009 1:34 pm
Subject: Re: [Moo] Re: Fx.accordion Error When using alwaysHide: true

Indeed, setting it to FALSE will fix the issue you're experiencing  
(it's basically, keeping height: 0 instead of applying height: auto).

It's odd to me that after some extensive re-facotring of the Accordion  
class, no one actually tested it thoroughly.

On 24 Oct 2009, at 18:08, davidck wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Aaron Newton  
View profile  
 More options Oct 24, 3:04 pm
From: Aaron Newton <aa...@iminta.com>
Date: Sat, 24 Oct 2009 12:04:09 -0700
Local: Sat, Oct 24 2009 3:04 pm
Subject: Re: [Moo] Re: Fx.accordion Error When using alwaysHide: true

we tested all the unit tests that were written, but we obviously didn't have
one written for this particular option. I'll put some work into it this
weekend so that it works as expected.

On Sat, Oct 24, 2009 at 10:34 AM, Oskar Krawczyk
<oskar.krawc...@gmail.com>wrote:


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google