command enhancements

[orefalo]

Cheeaun,

Could you please commit the changes from Ryan regarding the button
enhancements ?
I've been waiting for those during the past few days. We are talking
about 5-6 lines of code max.

Ryan added 3 methods to the button:

build: is a method used to build the toolbar button, note that not all
plugins may have a button so it's important to leave the button
insertion decision to the logic of this command. The combobutton I
used to pick the forecolor inserts 2 buttons in the toolbar.

toggle: is called when the user click the HTML button.

checkState: is called when the user edits text. Also intensively used
in my forecolor extension.


Please give us directions as to when these changes will be applied to
the source code. If you want to come up with something better, fine...
but please give us the flexibility we need to enhance mooeditable.

Thank you
Olivier

[cheeaun]

Uh, well.. I already gave the flexibility, which is by forking the
project on GitHub. :)
That's the whole concept of forking.

[orefalo]

Well you are right about forking... but there is no need to fork if
you don't merge some of the changes from contributors.
Do you think the linux kernel would be what it is today if Linus
didn't commit some of the 3rd party changes ?

Dude, you make me feel so bad explaining these kind of things.

Your role as the project owner is to protect the boundaries of the
changes, enhance code flexibility so that your project can reach more
developers.

I am actually reading another, quite interesting thread on the topic.
http://www.mooforum.net/scripts12/mooinline-textbox-rte-inline-wysiwyg-editor-t1168.html

plz read it, because it seems to me that you are missing the point.

It's momentum that we need for mooeditable, not fragmentation.

[cheeaun]

On Feb 13, 3:06 am, orefalo <oref...@yahoo.com> wrote:
> Well you are right about forking... but there is no need to fork if
> you don't merge some of the changes from contributors.
> Do you think the linux kernel would be what it is today if Linus
> didn't commit some of the 3rd party changes ?
>
> Dude, you make me feel so bad explaining these kind of things.
>
> Your role as the project owner is to protect the boundaries of the
> changes, enhance code flexibility so that your project can reach more
> developers.
>

> I am actually reading another, quite interesting thread on the topic.http://www.mooforum.net/scripts12/mooinline-textbox-rte-inline-wysiwy...

>
> plz read it, because it seems to me that you are missing the point.
>
> It's momentum that we need for mooeditable, not fragmentation.

I didn't mean that I won't be commiting contributor changes. I've
looked through the fork queue again and again and was thinking "this
commit is pretty useful, perhaps I should pull this one, but wait, I
need to do this and that first... ". I myself prefer to just focus
just on the Core code. That's the reason I want you guys to continue
forking and developing as your own repo, as I'm afraid what I do will
break your commits. I rather don't want to be distracted, like say, if
I commit this, will I break your plugin and etc?

I did some rather 'big' changes last few days and will probably rename
and add/remove functions here and there, so what I expect is you guys
could probably keep up with the core changes as often as possible and
update your previous commits, to see if it breaks. When I think the
core is stable is enough, I'll start to pull your commits, but I wont
pull those which are not updated with my current repo.

In other words, I'll be keeping the momentum in writing a more
flexible and extensible core, as you guys keep the the momentum of
keeping up with core changes and update your plugins along the way, as
for now.

Everyone's ideas mentioned in this group are not 'rejected' but has
always been in my todo list, as I'll think of a much better
implementation of your idea.

By the way, thanks for linking to SamGoody's editor! I see the my
project sort of 'inspired' him to create another editor, as how other
editors inspired me to create mine. :)