Need to close OutputStream when write file in GridFSDBFile.java(java driver, version 2.7.2)

[gen liu]

In java driver, I saw it has not close the OutputStream before return, here is the code(GridFSDBFile.java, line 66, version 2.7.2):

    public long writeTo( File f ) throws IOException {
        return writeTo( new FileOutputStream( f ) );
    }

    /**
     * Writes the file's data to an OutputStream
     * @param out the OutputStream
     * @return
     * @throws IOException
     */
    public long writeTo( OutputStream out )
        throws IOException {
        final int nc = numChunks();
        for ( int i=0; i<nc; i++ ){
            out.write( getChunk( i ) );
        }
        return _length; // is need to close out before return ? or the destructor function will close it?
    }

[Scott Hernandez]

You can use the writeTo(OutputStream stream) method if you want
control over this:
http://api.mongodb.org/java/2.8.0/com/mongodb/gridfs/GridFSDBFile.html#writeTo(java.io.OutputStream)

The garbage collector will clean it up, but it is better to do it
sooner than later on high volume servers.

> --
> You received this message because you are subscribed to the Google
> Groups "mongodb-user" group.
> To post to this group, send email to mongod...@googlegroups.com
> To unsubscribe from this group, send email to
> mongodb-user...@googlegroups.com
> See also the IRC channel -- freenode.net#mongodb

[Jeff Yemin]

This was fixed in the 2.8.0 release:

   https://github.com/mongodb/mongo-java-driver/blob/6ae5baa424c3e515b851390f2b7d34c67b8fdec9/src/main/com/mongodb/gridfs/GridFSDBFile.java#L66

Jeff

[gavinliu]

Thanks a lot.