Received: by 10.50.189.199 with SMTP id gk7mr530412igc.3.1347672565622;
        Fri, 14 Sep 2012 18:29:25 -0700 (PDT)
X-BeenThere: mongodb-dev@googlegroups.com
Received: by 10.50.160.202 with SMTP id xm10ls946963igb.3.gmail; Fri, 14 Sep
 2012 18:29:24 -0700 (PDT)
Received: by 10.50.161.165 with SMTP id xt5mr2059854igb.1.1347672564525;
        Fri, 14 Sep 2012 18:29:24 -0700 (PDT)
Received: by 10.50.161.165 with SMTP id xt5mr2059853igb.1.1347672564511;
        Fri, 14 Sep 2012 18:29:24 -0700 (PDT)
Return-Path: <aler...@10gen.com>
Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180])
        by gmr-mx.google.com with ESMTPS id ba5si118170igb.3.2012.09.14.18.29.24
        (version=TLSv1/SSLv3 cipher=OTHER);
        Fri, 14 Sep 2012 18:29:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of aler...@10gen.com designates 209.85.210.180 as permitted sender) client-ip=209.85.210.180;
Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of aler...@10gen.com designates 209.85.210.180 as permitted sender) smtp.mail=aler...@10gen.com
Received: by mail-iy0-f180.google.com with SMTP id j25so5406399iaf.39
        for <mongodb-dev@googlegroups.com>; Fri, 14 Sep 2012 18:29:24 -0700 (PDT)
        d=google.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding:x-gm-message-state;
        bh=cQ0snUkQbg7Pi+6S7XOx4r/AUZdsrEKc2af44SV4hmA=;
        b=XNb58Dks2mW8DMTYVaXeRSscISZTUIYq+TZAKG9c86UbSh/IHimh7WY6KTxrCJNub/
         P9j6rCjxxCjOAzcohVO7Z/w2+zXKNGUF39k7OSRDYNYnm1E3M8pcQN8C9R2gTg0/CofM
         0fDI4dTBTVynXXZjqrRoftVIwYT6S60523iP64r40qV596fg9dR3Yx0Tlj0NQXRsrVuw
         /uUdbpPB45WERVfSTUSFzuS9yUI9DYKTR+J+nSxOGcGXc7VQa6qf/tZQzSMQTlMUtY/K
         eLA1NhJU6IicyoTptyIND6VOKGn6twGHUlgRzDquRD5GMusgm1Gbs9p5x6CDiw1sF5yo
         wbDw==
MIME-Version: 1.0
Received: by 10.50.186.132 with SMTP id fk4mr267140igc.41.1347672564142; Fri,
 14 Sep 2012 18:29:24 -0700 (PDT)
Received: by 10.64.101.226 with HTTP; Fri, 14 Sep 2012 18:29:24 -0700 (PDT)
In-Reply-To: <639be5fc-f0d2-4ce2-b5fb-0ec626a2bcea@googlegroups.com>
References: <-4521224718412482476@unknownmsgid>
	<639be5fc-f0d2-4ce2-b5fb-0ec626a2bcea@googlegroups.com>
Date: Fri, 14 Sep 2012 21:29:24 -0400
Message-ID: <CAHPC_hXd03EC1t8NS349eQ2s1nMgkRNoP9vAaq6Xah6AwQp...@mail.gmail.com>
Subject: Re: [mongodb-dev] Re: Pull request feedback
From: Alberto Lerner <aler...@10gen.com>
To: mongodb-dev@googlegroups.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Gm-Message-State: ALoCoQnNqJSnOeBAtM9LNbph0YVYxEYq+nmhdWK6WeqK5ZMlb4sQvKcseVLs7D0hs7pmVClP+AC4

Erich,

This list is a good forum to discuss changes, so feel free to use it.

Performance instrumentation, in particular on the level that you
suggested, is something very useful. It is very helpful to know how a
given platform can support performance counters. However, besides
Win32/64, we support a number of other platforms. A feature at this
level should consider how the same functionality could be ported. It's
very helpful that you have a solid implementation for Win32/64 that we
can look at.

One concern about this implementation, though, is upgrade caveats. We
go the extra mile to make these easy and it seems that, even if very
well documented in your README, there are quite some pitfalls here.

Alberto.

On Fri, Sep 14, 2012 at 8:59 PM, e-siedler <erich.sied...@gmail.com> wrote:
>
> I was about to ask the same thing. I've implemented windows performance
> counters.
>
> https://github.com/mongodb/mongo/pull/275
> https://jira.mongodb.org/browse/SERVER-2541
>
> The pull request queue isn't very encouraging.
>
> Best regards.
>
>
> On Thursday, September 13, 2012 6:50:26 PM UTC-3, Samuel Garc=EDa Mart=ED=
nez
> wrote:
>>
>> Hi,
>> I wrote a patch for the issue
>> https://jira.mongodb.org/browse/SERVER-5477 two weeks ago and i never
>> got feedback about it. Is there any way to get feedback and know if it
>> will be merged?
>>
>> The related pull request: https://github.com/mongodb/mongo/pull/294
>>
>> Thanks in advance.
>
> --
> You received this message because you are subscribed to the Google Groups
> "mongodb-dev" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/mongodb-dev/-/TE5NdKG1k70J.
>
> To post to this group, send email to mongodb-dev@googlegroups.com.
> To unsubscribe from this group, send email to
> mongodb-dev+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/mongodb-dev?hl=3Den.