BOOST_FILESYSTEM_VERSION leaking to 'userland' from pch.h

69 views
Skip to first unread message

Pedro Larroy

unread,
Apr 10, 2012, 9:02:38 AM4/10/12
to mongo...@googlegroups.com
Hi

The redefinition of BOOST_FILESYSTEM_VERSION 2 in pch.h makes it problematic if you are using version 3 in userland code.

Is there a reason not to use the default and leave the macro undefined, or maybe there's a way to prevent the macro from being exposed?

/home/piotr/devel/mmcc/3rd-party/mongo-cxx-driver/src/mongo/pch.h:72:0: error: "BOOST_FILESYSTEM_VERSION" redefined [-Werror]
/home/piotr/devel/mmcc/3rd-party/boost/boost/filesystem/convenience.hpp:24:0: note: this is the location of the previous definition
In file included from /home/piotr/devel/mmcc/3rd-party/mongo-cxx-driver/src/mongo/client/dbclient.h:30:0,

Regards.

Andy Schwerin

unread,
Apr 10, 2012, 9:32:48 AM4/10/12
to mongo...@googlegroups.com
Pedro,

I've created a tracking ticket in the mongodb issue tracker for this request.  https://jira.mongodb.org/browse/SERVER-5561.

It's a small change, and should be easy enough to incorporate into the 2.2 release of mongod and the c++ driver.

-Andy


--
You received this message because you are subscribed to the Google Groups "mongodb-dev" group.
To view this discussion on the web visit https://groups.google.com/d/msg/mongodb-dev/-/1uCDqwgd3xgJ.
To post to this group, send email to mongo...@googlegroups.com.
To unsubscribe from this group, send email to mongodb-dev...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mongodb-dev?hl=en.

Pedro Larroy

unread,
Apr 10, 2012, 11:30:15 AM4/10/12
to mongo...@googlegroups.com
I will send a pull request after running the tests.


Pedro.
-Andy

To unsubscribe from this group, send email to mongodb-dev+unsubscribe@googlegroups.com.
-Andy

To unsubscribe from this group, send email to mongodb-dev+unsubscribe@googlegroups.com.
-Andy

To unsubscribe from this group, send email to mongodb-dev+unsubscribe@googlegroups.com.

Pedro Larroy

unread,
Apr 10, 2012, 12:38:13 PM4/10/12
to mongo...@googlegroups.com
Hi

I created a pull request for this.
Reply all
Reply to author
Forward
0 new messages