Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
mongodb-dev
Home
+ new post
About this group
Join this group
perl driver patch
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   7 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Graham Barr  
View profile  
 More options Sep 20 2010, 6:34 pm
From: Graham Barr <gmb...@gmail.com>
Date: Mon, 20 Sep 2010 17:34:20 -0500
Local: Mon, Sep 20 2010 6:34 pm
Subject: perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author
What is the preferred way to submit patches ?

A few days ago I submitted a pull request on github, but I am unsure who gets those as there has been no response.

The commit it at http://github.com/gbarr/mongo-perl-driver/tree/bson_to_sv

The patch allows perl level access to perl_mongo_bson_to_sv

I am currently writing an AnyEvent::MongoDB driver with a traditional AE callback API.
Exposing this function to perl allows me to reuse the work already done and not
have to duplicate.

Graham.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Kristina Chodorow  
View profile  
 More options Sep 20 2010, 6:50 pm
From: Kristina Chodorow <krist...@10gen.com>
Date: Mon, 20 Sep 2010 18:50:41 -0400
Local: Mon, Sep 20 2010 6:50 pm
Subject: Re: [mongodb-dev] perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author

Thanks for the commit, I've merged it in!

Sorry about that, Github only sends the pull request to the MongoDB user, so
no one sees them.  The best way is to do a pull request, then CC a developer
or open a bug (either at jira.mongodb.org or CPAN).

Also, nightsailer has been working on an AnyEvent driver, you might want to
check that out, too: http://jira.mongodb.org/browse/PERL-83.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Graham Barr  
View profile  
 More options Sep 20 2010, 6:59 pm
From: Graham Barr <gmb...@gmail.com>
Date: Mon, 20 Sep 2010 17:59:47 -0500
Local: Mon, Sep 20 2010 6:59 pm
Subject: Re: [mongodb-dev] perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author

On Sep 20, 2010, at 17:50 , Kristina Chodorow wrote:

> Thanks for the commit, I've merged it in!

> Sorry about that, Github only sends the pull request to the MongoDB user, so no one sees them.  The best way is to do a pull request, then CC a developer or open a bug (either at jira.mongodb.org or CPAN).

github has made recent changes to the pull request form. it seems very difficult now to CC people of the pull. unless I am missing something.

> Also, nightsailer has been working on an AnyEvent driver, you might want to check that out, too: http://jira.mongodb.org/browse/PERL-83.

I have talked with nightsailor. His main module is Any::Mongo and tries to follow the same API as MongoDB itself.

He did also take the AnyEvent::MongoDB namespace on CPAN, but has freed that and assigned co-maint to me so my module can use that space as mine uses a callback API similar to many other AE modules.

Graham.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Kristina Chodorow  
View profile  
 More options Sep 20 2010, 8:40 pm
From: Kristina Chodorow <krist...@10gen.com>
Date: Mon, 20 Sep 2010 20:40:51 -0400
Local: Mon, Sep 20 2010 8:40 pm
Subject: Re: [mongodb-dev] perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author

> github has made recent changes to the pull request form. it seems very
> difficult now to CC people of the pull. unless I am missing something.

That's too bad, most people didn't even CC before they made it hard.  Well,
just make sure someone with commit rights knows about it, we definitely
don't mean to ignore patches!

He did also take the AnyEvent::MongoDB namespace on CPAN, but has freed that

> and assigned co-maint to me so my module can use that space as mine uses a
> callback API similar to many other AE modules.

 Cool, I'd love to try it out when you have it working!


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
nightsailer  
View profile  
 More options Sep 21 2010, 1:05 pm
From: nightsailer <nightsai...@gmail.com>
Date: Tue, 21 Sep 2010 10:05:01 -0700 (PDT)
Local: Tues, Sep 21 2010 1:05 pm
Subject: Re: perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author
Oh, cool.

I had to copy & paste most mongoDB XS into AnyMongo before this
patch ;-(

BTW, I've write extras bson_decode and bson_encode into BSON package,
do you want to merge?

SV*
bson_encode(SV *sv)
    INIT:
        buffer buf;
    CODE:
        CREATE_BUF(INITIAL_BUF_SIZE);
        perl_mongo_sv_to_bson(&buf,sv,NO_PREP);
        RETVAL = newSVpvn(buf.start, buf.pos-buf.start);
        Safefree(buf.start);
    OUTPUT:
        RETVAL

SV *
bson_decode(char *bson)
    INIT:
        buffer buf;
    CODE:
        buf.start = bson;
        buf.end = bson+strlen(bson);
        buf.pos = bson;
        RETVAL = perl_mongo_bson_to_sv(&buf);
    OUTPUT:
        RETVAL

AlSO see:

http://github.com/nightsailer/any-mongo/blob/master/AnyMongo.xs

I think it useful to write some BSON related stuff future, like Ruby
driver.

Good job, Graham!

I'm working on traditional AE callback API too,  his work is helpful
to me ;-)
But, I still try to keep same or compatible API with MongoDB meantime,
with power of Coro::AnyEvent, we can write code clear,easy and
"normal",
help us port our old application to Coro/AE environment much quickly.

On 9月21日, 上午6时50分, Kristina Chodorow <krist...@10gen.com> wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Graham Barr  
View profile  
 More options Sep 21 2010, 1:13 pm
From: Graham Barr <gmb...@gmail.com>
Date: Tue, 21 Sep 2010 12:13:43 -0500
Local: Tues, Sep 21 2010 1:13 pm
Subject: Re: [mongodb-dev] perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author

On Sep 20, 2010, at 19:40 , Kristina Chodorow wrote:

> github has made recent changes to the pull request form. it seems very difficult now to CC people of the pull. unless I am missing something.

> That's too bad, most people didn't even CC before they made it hard.  Well, just make sure someone with commit rights knows about it, we definitely don't mean to ignore patches!

I wrote to github support and they replied with

   We recently rolled out a fairly large overhaul of pull requests:

   http://github.com/blog/712-pull-requests-2-0

   Notifications are now sent to everyone with push access to the destination repository. We'll be adding support for targeted notifications in the future.

But your obviously have push access to the repository, so maybe there is a bug somewhere.

Graham.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Kristina Chodorow  
View profile  
 More options Sep 21 2010, 2:38 pm
From: Kristina Chodorow <krist...@10gen.com>
Date: Tue, 21 Sep 2010 14:38:36 -0400
Local: Tues, Sep 21 2010 2:38 pm
Subject: Re: [mongodb-dev] perl driver patch
Print | Individual message | Show original | Report this message | Find messages by this author

> BTW, I've write extras bson_decode and bson_encode into BSON package,
> do you want to merge?

Sure!  Want to send a pull request? :)

Also, making a separate BSON package would be useful (if anyone's interested
in working on that).

But your obviously have push access to the repository, so maybe there is a

> bug somewhere.

Must be, the last pull request I got was a month ago.  I'll contact their
support.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google