Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
mongodb-dev
Home
+ new post
About this group
Join this group
Pull request feedback
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   5 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Samuel García Martínez  
View profile  
 More options Sep 13 2012, 5:50 pm
From: Samuel García Martínez <samuelgmarti...@gmail.com>
Date: Thu, 13 Sep 2012 23:50:24 +0200
Local: Thurs, Sep 13 2012 5:50 pm
Subject: Pull request feedback
Print | Individual message | Show original | Report this message | Find messages by this author
Hi,
I wrote a patch for the issue
https://jira.mongodb.org/browse/SERVER-5477 two weeks ago and i never
got feedback about it. Is there any way to get feedback and know if it
will be merged?

The related pull request: https://github.com/mongodb/mongo/pull/294

Thanks in advance.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
e-siedler  
View profile  
 More options Sep 14 2012, 8:59 pm
From: e-siedler <erich.sied...@gmail.com>
Date: Fri, 14 Sep 2012 17:59:35 -0700 (PDT)
Local: Fri, Sep 14 2012 8:59 pm
Subject: Re: Pull request feedback
Print | Individual message | Show original | Report this message | Find messages by this author

I was about to ask the same thing. I've implemented windows performance
counters.

https://github.com/mongodb/mongo/pull/275
https://jira.mongodb.org/browse/SERVER-2541

The pull request queue isn't very encouraging.

Best regards.

On Thursday, September 13, 2012 6:50:26 PM UTC-3, Samuel García Martínez
wrote:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alberto Lerner  
View profile  
 More options Sep 14 2012, 9:09 pm
From: Alberto Lerner <aler...@10gen.com>
Date: Fri, 14 Sep 2012 21:09:30 -0400
Local: Fri, Sep 14 2012 9:09 pm
Subject: Re: [mongodb-dev] Pull request feedback
Print | Individual message | Show original | Report this message | Find messages by this author
Samuel,

Thank you for your contribution and sorry for the late feedback.

The router (mongos) and the aggregation framework aspects that concern
it are undergoing a few changes so the code region this patches
touches is a bit dynamic. In particular we're reviewing the
dependencies/interactions between these two modules. We'd prefer to
change code once that revision is complete.

Alberto.

On Thu, Sep 13, 2012 at 5:50 PM, Samuel García Martínez


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alberto Lerner  
View profile  
 More options Sep 14 2012, 9:29 pm
From: Alberto Lerner <aler...@10gen.com>
Date: Fri, 14 Sep 2012 21:29:24 -0400
Local: Fri, Sep 14 2012 9:29 pm
Subject: Re: [mongodb-dev] Re: Pull request feedback
Print | Individual message | Show original | Report this message | Find messages by this author
Erich,

This list is a good forum to discuss changes, so feel free to use it.

Performance instrumentation, in particular on the level that you
suggested, is something very useful. It is very helpful to know how a
given platform can support performance counters. However, besides
Win32/64, we support a number of other platforms. A feature at this
level should consider how the same functionality could be ported. It's
very helpful that you have a solid implementation for Win32/64 that we
can look at.

One concern about this implementation, though, is upgrade caveats. We
go the extra mile to make these easy and it seems that, even if very
well documented in your README, there are quite some pitfalls here.

Alberto.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Justin Dearing  
View profile  
 More options Sep 15 2012, 10:15 pm
From: Justin Dearing <zippy1...@gmail.com>
Date: Sat, 15 Sep 2012 22:15:57 -0400
Local: Sat, Sep 15 2012 10:15 pm
Subject: Re: [mongodb-dev] Re: Pull request feedback
Print | Individual message | Show original | Report this message | Find messages by this author

Erich,

I will try to check this out on my systems. Performance counters are
something I want to understand in general. Probably better to aqquire that
knowledge with MongoDB than SQL Server.

Justin


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google