$string, but using $_

[Ярослав Косьмина]

Mojo/JSON.pm: line 69: sub decode:

sub decode {
my ($self, $string) = @_;

# Cleanup
$self->error(undef);

# Missing input
$self->error('Missing or empty input.') and return unless $string;

# Remove BOM
$string =~ s/^$BOM_RE//go;

# Wide characters
$self->error('Wide character in input.') and return
unless utf8::downgrade($_, 1); # not
$_ - using $string!!!

...

[Анатолий Шарифулин]

I fixed this in my fork, but Sebastian ignored

https://github.com/sharifulin/mojo/commit/e9826a30e6fdea56ad5b347ccb03193d1fb61eeb

2011/8/23 Ярослав Косьмина <half...@gmail.com>

--
You received this message because you are subscribed to the Google Groups "Mojolicious" group.
To post to this group, send email to mojol...@googlegroups.com.
To unsubscribe from this group, send email to mojolicious...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mojolicious?hl=en.

--
С уважением,
 Анатолий Шарифулин.

[Sebastian Riedel]

I fixed this in my fork, but Sebastian ignored

I'm not ignoring you, you are ignoring me!

Here's the pull request… https://github.com/kraih/mojo/pull/202

-- 
Sebastian Riedel

http://twitter.com/kraih

http://mojolicio.us 

[Анатолий Шарифулин]

Sorry, I haven't tests.

1. $_ vs. $string — it's typo, no test.
   
   
2. A string may be empty after decode, I don't know any test string for this test suite.

--

You received this message because you are subscribed to the Google Groups "Mojolicious" group.
To post to this group, send email to mojol...@googlegroups.com.
To unsubscribe from this group, send email to mojolicious...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/mojolicious?hl=en.

[Sebastian Riedel]

Sorry, I haven't tests.

1. $_ vs. $string — it's typo, no test.
   
   
2. A string may be empty after decode, I don't know any test string for this test suite.

Maybe i didn't make it clear enough, fixing a typo is fine, but you can't add new error messages without tests.

Anyway, the typo has been fixed on GitHub.