Websockets patch

[Richard Jones]

I've updated my mochiweb repo with a "clean" branch that shows my
websockets patch against the current version from mochi/mochiweb

https://github.com/RJ/mochiweb-websockets/commit/ef8aadd936bf927ee724651c9849eba8e9b78bd6

It has an async API, supports origin validation, and my example app is
currently configured to use https:
https://github.com/RJ/mochiweb-websockets/blob/ef8aadd936bf927ee724651c9849eba8e9b78bd6/examples/websockets/websockets_demo.erl

To try it out:

cd examples/websockets
erlc websockets_demo.erl
erl -boot start_sasl -pa ../../ebin/
websockets_demo:start().

then visit https://localhost:8080/ (excuse the ugly html/javascript..)

It's behaving fine so far during my testing.
I'd love to see websockets support in the official repo soon. To that
end, any testing, suggestions on how to improve it, stylistic
concerns, bugs, patches, comments, etc are very welcome :)

RJ

[Bob Ippolito]

Looking at this now. In the future it's more convenient for us to look
at an issue than a mailing list post for something like this.

> --
> You received this message because you are subscribed to the Google Groups "MochiWeb" group.
> To post to this group, send email to moch...@googlegroups.com.
> To unsubscribe from this group, send email to mochiweb+u...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/mochiweb?hl=en.
>
>

[Bob Ippolito]

I'd like to see the % comments switched to %% comments because Emacs
doesn't indent % properly.

I'd also like to see some tests, there aren't any at all.

With these two things sorted, I'd happily merge websockets support upstream :)

[Richard Jones]

Thanks, I'll file an issue with an update next week.
RJ