Re: [Mifos-developer] Utils Module

[Dion Dodgen]

Hi All,

Just starting up a thread for discussion around the refactoring and
reuse of Util type classes.

There is very useful fine grained util type code in multiple modules.
Now one can either access this functionality and end up tightly
coupling the various modules
possibly creating cyclic dependency in the process or factor it out in
to a util commons type package.

Otherwise create redundant code in your specific module.

Later things may move toward a more modular, pluggable design etc with
minimal interdependency between them.

Thanks
Dion

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[Adam Monsen]

On Fri, 2008-01-25 at 02:00 -0800, Dion Dodgen wrote:
> Just starting up a thread for discussion around the refactoring and
> reuse of Util type classes.

I'm glad you brought this up, Dion. The more we do this on a day-to-day
basis, the easier it will become to fix bugs in and add features to
Mifos.

Another good thing to keep in mind for aspect-oriented code is to use
well-established 3rd party code whenever possible. Here's one issue that
addresses this need, and touches on your comments as well:
https://mifos.dev.java.net/issues/show_bug.cgi?id=1543

> Later things may move toward a more modular, pluggable design etc with
> minimal interdependency between them.

Perhaps an example of code before/after the kind of refactoring you
mention would give developers a good example to follow.

--
Adam Monsen

[Keith Pierce]

Sounds like a good candidate for a future refactoring story. Dion, can you point to specific examples of what you've found to be "very useful fine-grained util type code"?

Keith Pierce

[Dion Dodgen]

Hi,

An example candidate would be something like
AccountBO.removeSign(Money amount) line 514,
and other validation type methods.

Cheers,
Dion