[Mifos-developer] PATCH: story #24 (misc config item refactor), part B (session timeout)

[Adam Monsen]

summary:
Moved session timeout from the CONFIG_KEY_VALUE_INTEGER table into
application-wide configuration,
applicationConfiguration.default.properties

In the database upgrade/downgrade scripts, I'm modifying a particular
row in the CONFIG_KEY_VALUE_INTEGER table by ID. I wouldn't be surprised
if this is a very bad idea, but I couldn't figure out another way to
deprecate sessionTimeout in the database. Please advise.

--
Adam Monsen

[Adam Monsen]

On Fri, 2007-12-14 at 17:47 -0800, Adam Monsen wrote:
> summary:
> Moved session timeout from the CONFIG_KEY_VALUE_INTEGER table into
> application-wide configuration,
> applicationConfiguration.default.properties

[...]

A unit test is failing.

java.lang.RuntimeException: org.hibernate.HibernateException: Session is
closed

Any ideas?

Here's the full error file:
http://tinyurl.com/2a5e3b

--
Adam Monsen

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Adam Monsen]

On Fri, 2007-12-14 at 18:44 -0800, Adam Monsen wrote:
[...]
> A unit test is failing.

[...]

To be precise, I broke the unit tests. I must not have run the full unit
test suite before submitting. My bad! Van, thanks for your help
isolating the problem. I try to always run all unit tests, and do a
quick deployment before posting a patch.

Here's an updated summary and patch superseding others on this thread:

* Moved session timeout from the CONFIG_KEY_VALUE_INTEGER table into
application-wide configuration,
applicationConfiguration.default.properties
* SystemConfiguration.java: cleaned up formatting and license, removed
commented dead code

--
Adam Monsen

[Van Mittal-Henkle]

Hi Adam,

Thanks fo the patch! It looks good and has been committed as revision
12230.

Cheers,
--Van