[Mifos-developer] [PATCH] build-findbugs.xml made findbugs task use more properties, instead of hardcodes

[Derek Jean-Baptiste]

Parameterized the findbugs task a bit, and used test.memory property for
the jvm size:

Thanks
Derek

Index: C:/Users/Derek/Documents/workspace/mifos/build-findbugs.xml
===================================================================
--- C:/Users/Derek/Documents/workspace/mifos/build-findbugs.xml
(revision 12246)
+++ C:/Users/Derek/Documents/workspace/mifos/build-findbugs.xml
(working copy)
@@ -13,16 +13,19 @@
<property name="tools.dir" value="${basedir}/tools/" />
<property name="findbugs.reportlevel" value="low" />
<property name="findbugs.home" value="${tools.dir}/findbugs-1.1.1" />
+ <property name="findbugs.output" value="xml"/>
+ <property name="findbugs.timeout" value="600000" />

<target name="findbugs"
depends="compile,compile_test,copy_files,copy_test_files"
description="Runs Findbugs on the MIFOS application and unit
test class files." >
<findbugs home="${findbugs.home}"
- jvmargs="-Xmx512m"
- output="xml"
+ jvmargs="-Xmx${test.memory}"
+ output="${findbugs.output}"
warningsProperty="findbugs.generated.warnings"
reportlevel="${findbugs.reportlevel}"
excludefilter="${conf.dir}/findbugs.filter.xml"
- outputFile="${dist.dir}/mifos.findbugs.output.xml" >
+
outputFile="${dist.dir}/mifos.findbugs.output.${findbugs.output}"
+ timeout="${findbugs.timeout}" >
<auxClasspath>
<fileset dir="${basedir}">
<include name="**/*.jar"/>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Adam Monsen]

On Jan 7, 9:47 pm, Derek Jean-Baptiste <derek.jeanbapti...@gmail.com>
wrote:

> Parameterized the findbugs task a bit, and used test.memory property for
> the jvm size:

Thanks for the patch, Derek! It is in the queue for review.

Would you mind attaching it to issue #1619?

https://mifos.dev.java.net/issues/show_bug.cgi?id=1619

--
Adam Monsen

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[Derek Jean-Baptiste]

Adam Monsen wrote:
> On Jan 7, 9:47 pm, Derek Jean-Baptiste <derek.jeanbapti...@gmail.com>
> wrote:
>
>> Parameterized the findbugs task a bit, and used test.memory property for
>> the jvm size:
>>
>
> Thanks for the patch, Derek! It is in the queue for review.
>
> Would you mind attaching it to issue #1619?
>
> https://mifos.dev.java.net/issues/show_bug.cgi?id=1619
>
>

Done,
thanks
Derek