[Mifos-developer] PATCH: story #24 (misc config item refactor), part C

[Adam Monsen]

This patch is against the trunk at svn revision 12236.

summary:
* moved configuration for allowance of back dated transactions out
of SYSTEM_CONFIGURATION table into application-wide configuration,
applicationConfiguration.default.properties. SYSTEM_CONFIGURATION
is now obselete and has been dropped, along with ConfigEntity
class and hibernate mapping.
* Moved CollectionSheetHelper.daysInAdvance out of the
CONFIG_KEY_VALUE_INTEGER table into application-wide configuration,
applicationConfiguration.default.properties.
* refactored relevant unit tests
* removed no-argument constructor from MeetingConfig since there is
no need nor reason for it
* removed now unnecessary OfficeConfigConstants class

All unit tests passed.

After deploying, there is one startup error, but I didn't see anything
breaking as a result. Full stack trace attached. Here's a snippet:

ERROR, org.apache.commons.digester.Digester, ?, ? , ?, Parse Error at
line 312 column 17: The content of element type "struts-config" must
match
"(display-name?,description?,data-sources?,form-beans?,global-exceptions?,global-forwards?,action-mappings?,controller?,message-resources*,plug-in*)"., 21 Dec 2007 15:40:05
org.xml.sax.SAXParseException: The content of element type
"struts-config" must match
"(display-name?,description?,data-sources?,form-beans?,global-exceptions?,global-forwards?,action-mappings?,controller?,message-resources*,plug-in*)".

--
Adam Monsen

[Adam Monsen]

On Fri, 2007-12-21 at 16:16 -0800, Adam Monsen wrote:
> This patch is against the trunk at svn revision 12236.

[...]

I forgot to mention a few things.

1. This patch completes the work on story #24 in mingle: Miscellaneous
Configuration items. See the following URLs for more information:
http://mifos.org/knowledge/functional-specs/configuration-options#3_4_Miscellaneous
( http://tinyurl.com/3db5ve )
http://mifos.org/developers/wiki/MifosConfigurationProjectStories#misc-config
( http://tinyurl.com/ysol5u )

2. This patch should actually delete the following files:
src/org/mifos/framework/components/configuration/business/ConfigEntity.java
src/org/mifos/framework/components/configuration/business/ConfigEntity.hbm.xml
src/org/mifos/framework/components/configuration/util/helpers/OfficeConfigConstants.java

3. The error mentioned in my previous post seems to be related to the
struts-config, and I have not locally edited any of the struts
configuration files. The error appears to be from Tomcat. I'm running
version 5.5.25. Anyone have any ideas on what might be the trouble here?

--
Adam Monsen

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[Van Mittal-Henkle]

Hi Adam,

Thanks for the patch and update. The patch looks good and has been
committed as revision 12240. Nice work cleaning up the tables and
classes that were no longer needed.

The error you mention was resolved in a commit previous to the one for
your patch.

--Van

> On Fri, 2007-12-21 at 16:16 -0800, Adam Monsen wrote:
>> This patch is against the trunk at svn revision 12236. [...]
>
> I forgot to mention a few things.
>
> 1. This patch completes the work on story #24 in mingle:
> Miscellaneous Configuration items. See the following URLs for more
> information:
>
http://mifos.org/knowledge/functional-specs/configuration-options#3_4_Mi
scellaneous
> ( http://tinyurl.com/3db5ve )
>
http://mifos.org/developers/wiki/MifosConfigurationProjectStories#misc-c
onfig
> ( http://tinyurl.com/ysol5u )
>
> 2. This patch should actually delete the following files:
>
src/org/mifos/framework/components/configuration/business/ConfigEntity.j
ava
>
src/org/mifos/framework/components/configuration/business/ConfigEntity.h
bm.xml
>
src/org/mifos/framework/components/configuration/util/helpers/OfficeConf
igConstants.java
>
> 3. The error mentioned in my previous post seems to be related to the
> struts-config, and I have not locally edited any of the struts
> configuration files. The error appears to be from Tomcat. I'm running
> version 5.5.25. Anyone have any ideas on what might be the trouble
> here?