dropdown menu caret - Mezzanine Users

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion dropdown menu caret
Received-SPF: pass (google.com: domain of stephen...@gmail.com designates 209.85.217.169 as permitted sender) client-ip=209.85.217.169;
MIME-Version: 1.0
Sender: stephen...@gmail.com
In-Reply-To: <25F45664-A29E-498D-A56F-F8738BAEE...@nimbisservices.com>
References: <CADtpeMz6DnUyuenthnREs2OEr478U4U2DWAbz9Vh78LztTB...@mail.gmail.com>
 <CAFDn9NYfKfzBsEDhBzebaUysNa4NM1TZZ0i3JW+HiAk6ZVh...@mail.gmail.com>
 <CADtpeMy4_oFZ00dT0H0OBoqNnWYKzwAKTYfV-wMwDioSTuO...@mail.gmail.com>
 <CAFDn9NZikxkOH+ke9_2+yxgvT50Xn8M4rdyqUdPARYN1FH2...@mail.gmail.com> <25F45664-A29E-498D-A56F-F8738BAEE...@nimbisservices.com>
From: Stephen McDonald <st...@jupo.org>
Date: Wed, 19 Sep 2012 06:36:17 +1000
Message-ID: <CAFDn9NYaYE3VvL0odPA3tmiB5XqwH5J8FX2C5UKu-usg6xH...@mail.gmail.com>
Subject: Re: [mezzanine-users] dropdown menu caret
To: mezzanine-users@googlegroups.com
Content-Type: multipart/alternative; boundary=bcaec554dc1ac57e8a04c9ffd8a9

--bcaec554dc1ac57e8a04c9ffd8a9
Content-Type: text/plain; charset=UTF-8

On Wed, Sep 19, 2012 at 12:40 AM, Brian Schott <
brian.sch...@nimbisservices.com> wrote:

> Are num_children and has_children attributes used by templates outside of
> the menu generation context?  Just concerned about side effects where those
> values change depending on what menu you happen to be processing.
>

They're only designed for use within menus, so I see this as a bug that
needs to be fixed.


>
> Also, I notice that the version of bootstrap in mezzanine is pre 2.0.  It
> might be time to think about updating bootstrap support, as there have been
> a lot of fixes and features added with 2.0.  I've upgraded our own site to
> 2.1, and it is working pretty well, but would love if we could just drop in
> templates from bootswatch an have everything just work style-wise.
>

Agreed. Hopefully it's just a matter of dropping in the new version.


>
> On Sep 17, 2012, at 7:44 PM, Stephen McDonald <st...@jupo.org> wrote:
>
> Right that makes sense. It'll need a bit of a refactor in the page_menu
> template tag where it all happens - doesn't look like a simple change, but
> it definitely needs to be fixed.
>
> On Tue, Sep 18, 2012 at 7:35 AM, Josh Cartmell <joshcar...@gmail.com>wrote:
>
>> Thanks Steve, I actually had seen that.  Right now page.has_children
>> evaluates to true even if the children aren't in the current menu (so if
>> about has a single child name team, but team doesn't show in the dropdown,
>> about still gets the caret).
>>
>> As an example if you look at the demo site right now, the 2nd item in the
>> drop down menu has a title of "The home page."  It has the little dropdown
>> caret next to it, even though it's only child is set to not show in any
>> menus.
>>
>>
>> On Mon, Sep 17, 2012 at 1:56 PM, Stephen McDonald <st...@jupo.org> wrote:
>>
>>> There's already a helper for it that's used and appear to work correctly
>>> for me:
>>>
>>>
>>> https://github.com/stephenmcd/mezzanine/blob/master/mezzanine/pages/templates/pages/menus/dropdown.html#L19
>>>
>>>
>>>
>>> On Tue, Sep 18, 2012 at 6:49 AM, Josh Cartmell <joshcar...@gmail.com>wrote:
>>>
>>>> I noticed that the caret in the dropdown shows up indicating a
>>>> dropdown, even if none of a page's children show in the menu.  I'm not
>>>> exactly sure how to go about it of the top of my head, but it seems that we
>>>> may need another helper, something like has_children_in_menu.  Am I missing
>>>> anything and/or does anyone have any ideas or comments?
>>>>
>>>> Thanks,
>>>> Josh
>>>>
>>>
>>>
>>>
>>> --
>>> Stephen McDonald
>>> http://jupo.org
>>>
>>
>>
>
>
> --
> Stephen McDonald
> http://jupo.org
>
>
>


-- 
Stephen McDonald
http://jupo.org

--bcaec554dc1ac57e8a04c9ffd8a9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Wed, Sep 19, 2012 at 12:40 AM, Brian =
Schott <span dir=3D"ltr">&lt;<a href=3D"mailto:brian.schott@nimbisservices.=
com" target=3D"_blank">brian.sch...@nimbisservices.com</a>&gt;</span> wrote=
:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div style=3D"word-wrap:break-word">Are num_=
children and has_children attributes used by templates outside of the menu =
generation context? =C2=A0Just concerned about side effects where those val=
ues change depending on what menu you happen to be processing. =C2=A0</div>

</blockquote><div><br></div><div>They&#39;re only designed for use within m=
enus, so I see this as a bug that needs to be fixed.</div><div>=C2=A0</div>=
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">

<div style=3D"word-wrap:break-word"><div><br></div><div>Also, I notice that=
 the version of bootstrap in mezzanine is pre 2.0. =C2=A0It might be time t=
o think about updating bootstrap support, as there have been a lot of fixes=
 and features added with 2.0. =C2=A0I&#39;ve upgraded our own site to 2.1, =
and it is working pretty well, but would love if we could just drop in temp=
lates from bootswatch an have everything just work style-wise.</div>

</div></blockquote><div><br></div><div>Agreed. Hopefully it&#39;s just a ma=
tter of dropping in the new version.</div><div>=C2=A0</div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex">

<div style=3D"word-wrap:break-word"><div><div><div class=3D"h5"><div>
<br><div><div>On Sep 17, 2012, at 7:44 PM, Stephen McDonald &lt;<a href=3D"=
mailto:st...@jupo.org" target=3D"_blank">st...@jupo.org</a>&gt; wrote:</div=
><br><blockquote type=3D"cite">Right that makes sense. It&#39;ll need a bit=
 of a refactor in the page_menu template tag where it all happens - doesn&#=
39;t look like a simple change, but it definitely needs to be fixed.<br>

<br><div class=3D"gmail_quote">On Tue, Sep 18, 2012 at 7:35 AM, Josh Cartme=
ll <span dir=3D"ltr">&lt;<a href=3D"mailto:joshcar...@gmail.com" target=3D"=
_blank">joshcar...@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Thanks Steve, I actually had seen that.=C2=
=A0 Right now page.has_children evaluates to true even if the children aren=
&#39;t in the current menu (so if about has a single child name team, but t=
eam doesn&#39;t show in the dropdown, about still gets the caret).<br>




<br>As an example if you look at the demo site right now, the 2nd item in t=
he drop down menu has a title of &quot;The home page.&quot;=C2=A0 It has th=
e little dropdown caret next to it, even though it&#39;s only child is set =
to not show in any menus.<div>



<div><br>
<br><div class=3D"gmail_quote">On Mon, Sep 17, 2012 at 1:56 PM, Stephen McD=
onald <span dir=3D"ltr">&lt;<a href=3D"mailto:st...@jupo.org" target=3D"_bl=
ank">st...@jupo.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
>




There&#39;s already a helper for it that&#39;s used and appear to work corr=
ectly for me:<div><br></div><div><a href=3D"https://github.com/stephenmcd/m=
ezzanine/blob/master/mezzanine/pages/templates/pages/menus/dropdown.html#L1=
9" target=3D"_blank">https://github.com/stephenmcd/mezzanine/blob/master/me=
zzanine/pages/templates/pages/menus/dropdown.html#L19</a></div>






<div><br></div><div><br><div><div><br><div class=3D"gmail_quote">On Tue, Se=
p 18, 2012 at 6:49 AM, Josh Cartmell <span dir=3D"ltr">&lt;<a href=3D"mailt=
o:joshcar...@gmail.com" target=3D"_blank">joshcar...@gmail.com</a>&gt;</spa=
n> wrote:<br>






<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">I noticed that the caret in the dropdown sho=
ws up indicating a dropdown, even if none of a page&#39;s children show in =
the menu.=C2=A0 I&#39;m not exactly sure how to go about it of the top of m=
y head, but it seems that we may need another helper, something like has_ch=
ildren_in_menu.=C2=A0 Am I missing anything and/or does anyone have any ide=
as or comments?<br>







<br>Thanks,<br>Josh<br>
</blockquote></div><br><br clear=3D"all"><div><br></div></div><span><font c=
olor=3D"#888888">-- <br>Stephen McDonald<br><a href=3D"http://jupo.org/" ta=
rget=3D"_blank">http://jupo.org</a><br>
</font></span></div></div>
</blockquote></div><br>
</div></div></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>=
Stephen McDonald<br><a href=3D"http://jupo.org/" target=3D"_blank">http://j=
upo.org</a><br>
</blockquote></div><br></div></div></div></div></div></blockquote></div><br=
><br clear=3D"all"><div><br></div>-- <br>Stephen McDonald<br><a href=3D"htt=
p://jupo.org" target=3D"_blank">http://jupo.org</a><br>

--bcaec554dc1ac57e8a04c9ffd8a9--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
