Reek v1.2 and metric_fu

11 views
Skip to first unread message

Kevin Rutherford

unread,
Sep 21, 2009, 3:33:45 PM9/21/09
to jake.s...@gmail.com, metr...@googlegroups.com, ruby...@googlegroups.com
Hi,
If you use metric_fu together with Reek, yesterday's release of Reek
1.2 will affect you.

Reek's report format has changed in release 1.2, which means that if
you update your Reek gem, metric_fu will no longer parse Reek's
reports correctly (everything else in metric_fu continues to work
correctly).

@Jake, I've coded up a patch for metric_fu that allows it to recognise
and parse both versions of Reek reports; there's a pull request
waiting for you on github.

Regards,
Kevin
--
http://www.kevinrutherford.co.uk -- agile, TDD, XP, lean, TOC

jaredonline

unread,
Oct 19, 2009, 5:18:45 PM10/19/09
to metric_fu
Has your fix been pulled into metric_fu's main branch? I'm getting a
No Data response for the Reek results when used with metric_fu

On Sep 21, 12:33 pm, Kevin Rutherford <ke...@rutherford-software.com>
wrote:
> --http://www.kevinrutherford.co.uk-- agile, TDD, XP, lean, TOC

Kevin Rutherford

unread,
Oct 21, 2009, 5:06:27 AM10/21/09
to metr...@googlegroups.com
On Mon, Oct 19, 2009 at 10:18 PM, jaredonline <jared....@gmail.com> wrote:
>
> Has your fix been pulled into metric_fu's main branch?  I'm getting a
> No Data response for the Reek results when used with metric_fu

Doesn't appear to be there.
Cheers,
Kevin
--
http://www.kevinrutherford.co.uk -- agile, TDD, XP, lean, TOC

Chris

unread,
Dec 4, 2009, 11:54:32 AM12/4/09
to metric_fu
I'm still seeing this problem with metric_fu 1.1.5 and reek version
1.2.6.

On Oct 21, 4:06 am, Kevin Rutherford <ke...@rutherford-software.com>
wrote:
> On Mon, Oct 19, 2009 at 10:18 PM, jaredonline <jared.onl...@gmail.com> wrote:
>
> > Has your fix been pulled into metric_fu's main branch?  I'm getting a
> > No Data response for the Reek results when used with metric_fu
>
> Doesn't appear to be there.
> Cheers,
>     Kevin
> --http://www.kevinrutherford.co.uk-- agile, TDD, XP, lean, TOC

John Griffin

unread,
Dec 11, 2009, 11:31:36 AM12/11/09
to metric_fu
Still having the same issues with the new version of reek here.

Kevin Rutherford

unread,
Dec 13, 2009, 8:46:00 AM12/13/09
to metr...@googlegroups.com
> Still having the same issues with the new version of reek here.

This has been fixed for a while in my fork:
http://github.com/kevinrutherford/metric_fu (I believe the fix makes
metric_fu work with all versions of reek).
Cheers,
Kevin

Jake Scruggs

unread,
Dec 14, 2009, 8:48:25 PM12/14/09
to metric_fu
Merging your changes in now, Kevin. Thanks.

-Jake

On Dec 13, 7:46 am, Kevin Rutherford <ke...@rutherford-software.com>
wrote:
> > Still having the same issues with the new version of reek here.
>
> This has been fixed for a while in my fork:http://github.com/kevinrutherford/metric_fu(I believe the fix makes
Reply all
Reply to author
Forward
0 new messages