pfinish prototype

14 views
Skip to first unread message

Peer Sommerlund

unread,
Mar 11, 2011, 4:31:02 PM3/11/11
to Peter Arrenbrecht, Mercurial Devel
Hi Peter

I have a prototype for the pfinish command at
https://bitbucket.org/peso/hg-pbranch-pfinish

Since I'm new to both mercurial extensions and pbranch internals there
are lots of things I haven't fully understood.

Would you mind reviewing the patch?

Regards,
Peer
_______________________________________________
Mercurial-devel mailing list
Mercuri...@selenic.com
http://selenic.com/mailman/listinfo/mercurial-devel

Peter Arrenbrecht

unread,
Mar 12, 2011, 4:22:09 AM3/12/11
to Peer Sommerlund, Mercurial Devel
On Fri, Mar 11, 2011 at 10:31 PM, Peer Sommerlund
<peer.so...@gmail.com> wrote:
> Hi Peter
>
> I have a prototype for the pfinish command at
> https://bitbucket.org/peso/hg-pbranch-pfinish
>
> Since I'm new to both mercurial extensions and pbranch internals there
> are lots of things I haven't fully understood.
>
> Would you mind reviewing the patch?

Sure, shall look at it this weekend. Thanks for working on this.
-parren

Peter Arrenbrecht

unread,
Mar 12, 2011, 6:04:19 AM3/12/11
to Peer Sommerlund, Mercurial Devel
On Fri, Mar 11, 2011 at 10:31 PM, Peer Sommerlund
<peer.so...@gmail.com> wrote:
> Hi Peter
>
> I have a prototype for the pfinish command at
> https://bitbucket.org/peso/hg-pbranch-pfinish
>
> Since I'm new to both mercurial extensions and pbranch internals there
> are lots of things I haven't fully understood.
>
> Would you mind reviewing the patch?

Peer, this looks like a good approach to me (yes, I think I finally
see your point). I need to see if I can find the time to try to work
this into the tutorial tests this weekend. I would also like to add an
option that rewrites the .hg/pgraph file with the finished patch
removed.
-parren

Peer Sommerlund

unread,
Jun 22, 2011, 12:22:34 AM6/22/11
to peter.ar...@gmail.com, Mercurial Devel


On 12 March 2011 12:04, Peter Arrenbrecht <peter.ar...@gmail.com> wrote:
On Fri, Mar 11, 2011 at 10:31 PM, Peer Sommerlund
<peer.so...@gmail.com> wrote:
> Hi Peter
>
> I have a prototype for the pfinish command at
> https://bitbucket.org/peso/hg-pbranch-pfinish
>
> Since I'm new to both mercurial extensions and pbranch internals there
> are lots of things I haven't fully understood.
>
> Would you mind reviewing the patch?

Peer, this looks like a good approach to me (yes, I think I finally
see your point). I need to see if I can find the time to try to work
this into the tutorial tests this weekend. I would also like to add an
option that rewrites the .hg/pgraph file with the finished patch
removed.
-parren

 
Hi Peter


Have you had time to look further at this?

Regards,
Peer

Reply all
Reply to author
Forward
0 new messages