[PATCH] Fix for Cache::Memcached breakage w/ unix domain support caused by IPv6 changes.

4 views
Skip to first unread message

Nathan Neulinger

unread,
Feb 10, 2010, 9:51:03 AM2/10/10
to memc...@googlegroups.com

I just happened to bump up one of my boxes to latest Cache::Memcached version from CPAN and noticed that it breaks unix domain socket support - or rather, dumps a warning. Here's a fix - it just moves some udp/tcp specific code into the non-unixdomain code block.

Technically, to resolve this warning, only the IPv6 line needs to be moved, but there's no point in having the pattern match and proto lookup run outside the block since they aren't used, and putting inside the block doesn't change code path for non unixdomain sockets.

Thanks!

-- Nathan

mc-ipv6-unixdomain.diff

Nathan Neulinger

unread,
Feb 20, 2010, 10:53:06 PM2/20/10
to memcached
Haven't heard anything back on this... any chance of getting this
patch applied to the CPAN perl module for memcached? Brad indicates
that he no longer maintains it and to ask here about getting the patch
applied. As it currently stands, the module breaks web applications
that use it due to the spurious warnings it generates.

-- Nathan

On Feb 10, 8:51 am, Nathan Neulinger <nathan.neulin...@gmail.com>
wrote:

>  mc-ipv6-unixdomain.diff
> 2KViewDownload

dormando

unread,
Feb 20, 2010, 11:35:13 PM2/20/10
to memcached
Er, I'm heading out the door atm, I'll get it when I get back in a few
hours. Thanks for the patch!
Reply all
Reply to author
Forward
0 new messages