[Midnight Commander] #2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory

73 views
Skip to first unread message

Ticket System

unread,
Dec 19, 2011, 4:59:48 PM12/19/11
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
----------------------------------+--------------------------------
Reporter: slavazanko | Owner:
Type: task | Status: new
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Keywords: | Blocked By:
Blocking: 62, 2454 | Branch state: no branch
Votes for changeset: |
----------------------------------+--------------------------------
For unification of the work with patches, we need to expand the vfs_path_t
usage to sources related to UI (not only to lib/ subdir).

--
Ticket URL: <www.midnight-commander.org/ticket/2695>
Midnight Commander <http://www.midnight-commander.org>
Midnight Development Center

Ticket System

unread,
Dec 19, 2011, 5:00:08 PM12/19/11
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+---------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking: 62, 2454
Branch state: no branch | Votes for changeset:
---------------------------+---------------------------------------
Changes (by slavazanko):

* owner: => slavazanko
* status: new => accepted


--
Ticket URL: <www.midnight-commander.org/ticket/2695#comment:1>

Ticket System

unread,
Dec 19, 2011, 5:05:08 PM12/19/11
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+---------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking: 62, 2454
Branch state: on review | Votes for changeset:
---------------------------+---------------------------------------
Changes (by slavazanko):

* branch_state: no branch => on review


Comment:

Created branch 2695_expansion_to_src
Initial changeset:7f0d3b42f8bd782a3a0667edb7259c66fc69ef8b


Review, please.

--
Ticket URL: <www.midnight-commander.org/ticket/2695#comment:2>

Ticket System

unread,
Jan 10, 2012, 2:19:05 AM1/10/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+---------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking: 62, 2454
Branch state: on rework | Votes for changeset:
---------------------------+---------------------------------------
Changes (by andrew_b):

* branch_state: on review => on rework


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:3>

Ticket System

unread,
Jan 13, 2012, 3:08:57 AM1/13/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+---------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking: 62, 2451, 2454
Branch state: on review | Votes for changeset:
---------------------------+---------------------------------------
Changes (by slavazanko):

* branch_state: on rework => on review


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:5>

Ticket System

unread,
Jan 13, 2012, 3:36:31 AM1/13/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 62, 2451, 2454
Branch state: on review | Votes for changeset:
---------------------------+----------------------------------------
Changes (by slavazanko):

* keywords: => stable-candidate


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:6>

Ticket System

unread,
Feb 24, 2012, 12:44:50 AM2/24/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 62, 2454
Branch state: on review | Votes for changeset:
---------------------------+----------------------------------------
Changes (by andrew_b):

* blocking: 62, 2451, 2454 => 62, 2454


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:7>

Ticket System

unread,
Feb 27, 2012, 12:40:08 PM2/27/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 62, 2454
Branch state: on review | Votes for changeset: andrew_b
---------------------------+----------------------------------------
Changes (by andrew_b):

* votes: => andrew_b


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:8>

Ticket System

unread,
Mar 6, 2012, 2:24:45 AM3/6/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+-----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking: 62, 2454
Branch state: approved | Votes for changeset: andrew_b angel_il
---------------------------+-----------------------------------------
Changes (by angel_il):

* keywords: stable-candidate =>
* votes: andrew_b => andrew_b angel_il
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:9>

Ticket System

unread,
Mar 6, 2012, 4:14:51 AM3/6/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: testing
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: fixed | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: committed-master
---------------------------+----------------------------------------
Changes (by slavazanko):

* status: accepted => testing
* votes: andrew_b angel_il => committed-master
* milestone: Future Releases => 4.8.2
* keywords: => stable-candidate
* resolution: => fixed
* blocking: 62, 2454 =>


Comment:

Merged to master:
{{{
git log --pretty=oneline 963ee34...4047403
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:10>

Ticket System

unread,
Mar 7, 2012, 2:36:55 PM3/7/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: reopened
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 2608
Branch state: approved | Votes for changeset: committed-master
---------------------------+----------------------------------------
Changes (by slavazanko):

* status: testing => reopened
* resolution: fixed =>
* blocking: => 2608


Comment:

Have bug with branch:
* run mc
* press Shift-F4 (create new file in editor)
* type any char

segfault here

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:11>

Ticket System

unread,
Mar 7, 2012, 2:37:06 PM3/7/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 2608
Branch state: approved | Votes for changeset: committed-master
---------------------------+----------------------------------------
Changes (by slavazanko):

* status: reopened => accepted


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:12>

Ticket System

unread,
Mar 7, 2012, 2:46:02 PM3/7/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 2608
Branch state: on review | Votes for changeset:
---------------------------+----------------------------------------
Changes (by slavazanko):

* votes: committed-master =>
* branch_state: approved => on review


Comment:

Created branch [changeset:f3352a16af98f9d1265b021bc549f33ca7cd2010
2695_editor_segfault]

Review, please.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:13>

Ticket System

unread,
Mar 7, 2012, 3:13:01 PM3/7/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 2608
Branch state: on review | Votes for changeset: angel_il
---------------------------+----------------------------------------
Changes (by angel_il):

* votes: => angel_il


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:14>

Ticket System

unread,
Mar 7, 2012, 11:50:17 PM3/7/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+-----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking: 2608
Branch state: approved | Votes for changeset: angel_il andrew_b
---------------------------+-----------------------------------------
Changes (by andrew_b):

* votes: angel_il => angel_il andrew_b

* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:15>

Ticket System

unread,
Mar 8, 2012, 1:37:17 AM3/8/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
---------------------------+----------------------------------------
Changes (by andrew_b):

* votes: angel_il andrew_b => committed-master
* blocking: 2608 =>
* branch_state: approved => merged


Comment:

Merged to master: [8451286bb5367c6cf270e5081785e0f351079225]

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:16>

Ticket System

unread,
Mar 10, 2012, 6:36:35 AM3/10/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on rework | Votes for changeset: committed-master
---------------------------+----------------------------------------
Changes (by slyfox):

* branch_state: merged => on rework


Comment:

This change likely led to newly appeared regression.
mc enters busy loop when someone deletes current directory:

{{{
$ cd /tmp
$ mkdir x
$ cd x
$ mc
$ rmdir ../x
<black screen. mc 100% busy loops>
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:17>

Ticket System

unread,
Mar 10, 2012, 8:30:50 AM3/10/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on rework | Votes for changeset: committed-master
---------------------------+----------------------------------------

Comment (by andrew_b):

Fixed in 2740_cleanup.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:18>

Ticket System

unread,
Mar 12, 2012, 10:11:57 AM3/12/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on rework | Votes for changeset: committed-master
---------------------------+----------------------------------------

Comment (by slavazanko):

* mkdir ro_dir
* chmod 555 ro_dir
* Shift+F4
* type any symbols
* press ESC, try to save
Segfault here.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:19>

Ticket System

unread,
Mar 12, 2012, 10:46:33 AM3/12/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
---------------------------+----------------------------------------
Changes (by slavazanko):

* votes: committed-master =>
* branch_state: on rework => on review


Comment:

Created branch 2695_editor_segfault
Initial changeset:5b787f35899d6e9120992a860614d7db4e614518

Review, please.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:20>

Ticket System

unread,
Mar 14, 2012, 6:26:33 AM3/14/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on review | Votes for changeset: slavazanko
---------------------------+----------------------------------------
Changes (by slavazanko):

* votes: => slavazanko


Comment:

Branch rebased to current master.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:21>

Ticket System

unread,
Mar 14, 2012, 10:07:14 AM3/14/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on review | Votes for changeset: angel_il
---------------------------+----------------------------------------
Changes (by angel_il):

* votes: => angel_il


Ticket System

unread,
Mar 14, 2012, 1:36:39 PM3/14/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+-----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: accepted
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: angel_il andrew_b
---------------------------+-----------------------------------------
Changes (by andrew_b):

* votes: angel_il => angel_il andrew_b

* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:22>

Ticket System

unread,
Mar 15, 2012, 5:50:03 AM3/15/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: testing
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: fixed | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
---------------------------+----------------------------------------
Changes (by slavazanko):

* status: accepted => testing

* votes: angel_il andrew_b => committed-master

* resolution: => fixed

* branch_state: approved => merged


Comment:

merged to master:
{{{
git log --pretty=oneline 61ee9ce...0f9083f
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:23>

Ticket System

unread,
Mar 20, 2012, 8:51:02 AM3/20/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: testing
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: fixed | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
---------------------------+----------------------------------------

Comment (by andrew_b):

Since this ticket is stable-candidate, following commits must be cherry-
picked to 4.8.1-stable after porting this ticket to 4.8.1-stable:
[62bbe532056a0b2d0c075a8232f2c0721c863cac]
[8b8c9a4f348439bc11bdaa3ce9f3c9f1032d6825]
[c2406adfce138444ad842f75b65d64c2668a24fc]

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:24>

Ticket System

unread,
Mar 25, 2012, 9:46:41 AM3/25/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
---------------------------+----------------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: testing
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: fixed | Keywords: stable-candidate
Blocked By: | Blocking: 2753, 2758, 2759, 2762
Branch state: merged | Votes for changeset: committed-master
---------------------------+----------------------------------------------
Changes (by andrew_b):

* blocking: 2753, 2758, 2759 => 2753, 2758, 2759, 2762


--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:28>

Ticket System

unread,
Apr 2, 2012, 4:49:44 PM4/2/12
to slava...@gmail.com, mc-...@googlegroups.com
#2695: VFS reorganization: the vfs_path_t expansion to 'src/' subdirectory
-------------------------------------+-------------------------------------
Reporter: slavazanko | Owner: slavazanko
Type: task | Status: closed
Priority: major | Milestone: 4.8.2
Component: mc-vfs | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking: 2753, 2758,
Branch state: merged | 2759, 2762
| Votes for changeset: committed-
| master committed-stable
-------------------------------------+-------------------------------------
Changes (by slavazanko):

* keywords: stable-candidate =>
* status: testing => closed
* votes: committed-master => committed-master committed-stable


Comment:

Cherry-picked to stable:
{{{
git log --pretty=oneline 50a146ce...1e92692
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/2695#comment:29>

Reply all
Reply to author
Forward
0 new messages