[Midnight Commander] #2926: [PATCH] fix --with-ncurses-libs

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
-----------------------------------------+--------------------------------
Reporter: and | Owner:
Type: defect | Status: new
Priority: minor | Milestone: Future Releases
Component: mc-core | Version: master
Keywords: with-ncurses-libs | Blocked By:
Blocking: | Branch state: no branch
Votes for changeset: |
-----------------------------------------+--------------------------------
if using external ncurses with
#./configure --with-ncurses-inc=... --with-ncurses-libs=...
it failed with:
configure: error: Cannot find ncurses library

because --with-ncurses-libs is not proper evaluated.

Attached patch will fix it.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926>
Midnight Commander <http://www.midnight-commander.org>
Midnight Development Center

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
--------------------------+-----------------------------------------

Reporter: and | Owner:
Type: defect | Status: new
Priority: minor | Milestone: Future Releases
Component: mc-core | Version: master

Resolution: | Keywords: with-ncurses-libs

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:

--------------------------+-----------------------------------------

Comment (by andrew_b):

Unfortunately, patch is not correct. CPPFLAGS is not proper place for
libs. LDFLAGS should be used for.

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926#comment:1>

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
--------------------------+----------------------------------------
Reporter: and | Owner: andrew_b
Type: defect | Status: accepted
Priority: minor | Milestone: 4.8.7
Component: mc-core | Version: master
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
--------------------------+----------------------------------------
Changes (by andrew_b):

* keywords: with-ncurses-libs => stable-candidate
* owner: => andrew_b
* status: new => accepted
* branch_state: no branch => on review
* milestone: Future Releases => 4.8.7

Comment:

Branch: 2926_screen_lib_flags (parent: master).
Initial changeset:f2dea328908b5cc8e134cc748744372e992646e1

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926#comment:2>

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
--------------------------+----------------------------------------
Reporter: and | Owner: andrew_b
Type: defect | Status: accepted
Priority: minor | Milestone: 4.8.7
Component: mc-core | Version: master
Resolution: | Keywords: stable-candidate

Blocked By: | Blocking:
Branch state: on review | Votes for changeset: angel_il
--------------------------+----------------------------------------
Changes (by angel_il):

* votes: => angel_il

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926#comment:3>

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
-------------------------+-------------------------------------------

Reporter: and | Owner: andrew_b
Type: defect | Status: accepted
Priority: minor | Milestone: 4.8.7
Component: mc-core | Version: master
Resolution: | Keywords: stable-candidate

Blocked By: | Blocking:
Branch state: approved | Votes for changeset: angel_il slavazanko
-------------------------+-------------------------------------------
Changes (by slavazanko):

* votes: angel_il => angel_il slavazanko
* branch_state: on review => approved

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926#comment:4>

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
------------------------+----------------------------------------
Reporter: and | Owner: andrew_b
Type: defect | Status: testing

Priority: minor | Milestone: 4.8.7
Component: mc-core | Version: master

Resolution: fixed | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
------------------------+----------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: angel_il slavazanko => committed-master
* resolution: => fixed
* branch_state: approved => merged

Comment:

Merged to master: [177f1dc5ba2c65ccadb93c8b7bb5fec37e29df48].
{{{
git log --pretty=oneline f0d1d91..177f1dc
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926#comment:5>

[Ticket System]

#2926: [PATCH] fix --with-ncurses-libs
-------------------------------------+-------------------------------------
Reporter: and | Owner: andrew_b
Type: defect | Status: closed

Priority: minor | Milestone: 4.8.7
Component: mc-core | Version: master
Resolution: fixed | Keywords:

Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-
| master committed-stable
-------------------------------------+-------------------------------------
Changes (by andrew_b):

* keywords: stable-candidate =>
* status: testing => closed
* votes: committed-master => committed-master committed-stable

Comment:

Merged to 4.8.1-stable: [c8af535907848b6dad76437566e1fc9b2768c109].
{{{
git log --pretty=oneline 65569af..c8af535
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/2926#comment:6>