Re: [Midnight Commander] #1535: Feature: support SCP/SFTP
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+----------------------------------
Changes (by slavazanko):
* owner: => slavazanko
* status: new => accepted
* branch_state: on rework => on review
* milestone: 4.8 => 4.8.4
Comment:
Created branch [changeset:f2ff8d6dff01b892b9470214e7b5661252b2bc4e
1535_vfs_sftp]
Review, please.
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:7>
Midnight Commander <http://www.midnight-commander.org>
Midnight Development Center
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+----------------------------------
Comment (by replika):
I checked out the branch 1535_vfs_sftp but got this error:
{{{
make[3]: Entering directory `/mnt/src/mc/src/filemanager'
CC libmcfilemanager_la-achown.lo
CC libmcfilemanager_la-boxes.lo
CC libmcfilemanager_la-chmod.lo
CC libmcfilemanager_la-chown.lo
CC libmcfilemanager_la-cmd.lo
cmd.c: In function 'sftplink_cmd':
cmd.c:1520:14: error: too few arguments to function 'nice_cd'
cmd.c:524:1: note: declared here
make[3]: *** [libmcfilemanager_la-cmd.lo] Error 1
make[3]: Leaving directory `/mnt/src/mc/src/filemanager'
}}}
{{{
./configure --enable-vfs-smb --enable-vfs-sftp --with-screen=ncurses
}}}
Which branch should I used to test this feature?
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:8>
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+----------------------------------
Comment (by slavazanko):
This happens as result of rebasing. Fixed.
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:9>
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+----------------------------------
* cc: replika (added)
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:10>
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+----------------------------------
Comment (by replika):
Thanks for your working on this feature. It works great so far.
BTW, how to disconnect a connection?
Tried `cd` but it is still connected; `cd -` will go back to sftp
directory.
In "Active VFS list", it is displayed as `//sftp://`, but cannot change
directory nor free the VFS.
Currently, I have to exit `mc` to close the connection.
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:11>
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+----------------------------------
Changes (by angel_il):
* votes: => angel_il
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:12>
Ticket System
----------------------------+-----------------------------------------
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+-----------------------------------------
Changes (by andrew_b):
* votes: angel_il => angel_il andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:13>
Ticket System
----------------------------+----------------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: testing
Component: mc-vfs | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by slavazanko):
* status: accepted => testing
* votes: angel_il andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Merged to master:
{{{
git log --pretty=oneline 7893cbf..da03697
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:14>
Ticket System
----------------------------+----------------------------------------
Reporter: bilbo | Owner: slavazanko
Component: mc-vfs | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by slavazanko):
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:15>
Ticket System
----------------------------+----------------------------------------
Reporter: bilbo | Owner: slavazanko
Component: mc-vfs | Version: master
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
* status: closed => reopened
* resolution: fixed =>
Comment:
Stock '''./configure fails''' if user does not have libssh2 headers.
The default behaviour is not to enable plugin unless user explicitly
requests is with --enable-vfs-sftp.
Attaching the patch to retain user friendly behaviour.
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:16>
Ticket System
----------------------------+----------------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: reopened
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Comment (by IceMan):
Midnight Commander from current git origin/master doesn't mention SFTP
support in mc -V output.
$ LC_ALL=C mc -V
GNU Midnight Commander 4.8.3-95-g8ca27aa
Built with GLib 2.24.2
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, fish
Data types: char: 8; int: 32; long: 64; void *: 64; size_t: 64; off_t: 64;
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:17>
Ticket System
----------------------------+----------------------------------
Type: enhancement | Status: reopened
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+----------------------------------
Changes (by andrew_b):
* votes: committed-master =>
* branch_state: merged => no branch
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:18>
Ticket System
----------------------------+----------------------------------
Reporter: bilbo | Owner: slavazanko
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+----------------------------------
Changes (by slavazanko):
* status: reopened => accepted
* votes: => slavazanko
* branch_state: no branch => on review
Comment:
Created branch [changeset:2056c025f530cccdcd756ff68b6b7fcfe70e674d
1535_vfs_sftp_fixes]
Review, please.
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:19>
Ticket System
----------------------------+-------------------------------------------
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+-------------------------------------------
Changes (by andrew_b):
* votes: slavazanko => slavazanko andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:20>
Ticket System
----------------------------+----------------------------------------
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+----------------------------------------
* votes: slavazanko andrew_b => committed-master
* branch_state: approved => merged
Comment:
Merged to master:
{{{
git log --pretty=oneline a343070..3786051
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:21>
Ticket System
----------------------------+----------------------------------------
Reporter: bilbo | Owner: slavazanko
Component: mc-vfs | Version: master
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by slavazanko):
* status: accepted => testing
* resolution: => fixed
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:22>
Ticket System
----------------------------+----------------------------------------
Reporter: bilbo | Owner: slavazanko
Type: enhancement | Status: testing
Priority: major | Milestone: 4.8.4
Component: mc-vfs | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Comment (by IceMan):
When opening SFTP link to the remote server by using host alias from
~/.ssh/config MC start more than one sftp-server instance on the target
server. If you use user...@1.2.3.4 instead of host alias - MC works fine.
{{{
GNU Midnight Commander 4.8.3-121-g54b2b2f
Built with GLib 2.24.2
Using the S-Lang library with terminfo database
With builtin Editor
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support
Virtual File Systems: cpiofs, tarfs, sfs, extfs, ftpfs, sftpfs, fish
Data types: char: 8; int: 32; long: 32; void *: 32; size_t: 32; off_t: 64;
}}}
Expected behaviour:
When open SFTP link by host alias MC must start only single sftp-server
instance per SFTP link on the target server.
How to reproduce:
1) Create host record in ~/.ssh/config like following:
{{{
Host example
HostName 1.2.3.4
User username
}}}
2) Open SFTP link by using example as "Machine name"
3) Login to target server and count sftp-server instances
{{{
pgrep -u username sftp-server | wc -l
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:23>
Ticket System
----------------------------+----------------------------------
Type: enhancement | Status: reopened
Priority: major | Milestone: 4.8.5
Component: mc-vfs | Version: 4.8.4
Resolution: | Keywords:
Blocked By: | Blocking:
----------------------------+----------------------------------
Changes (by andrew_b):
* status: testing => reopened
* votes: committed-master =>
* version: master => 4.8.4
* branch_state: merged => no branch
* milestone: 4.8.4 => 4.8.5
* resolution: fixed =>
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:24>
Ticket System
----------------------------+---------------------------------------
Type: enhancement | Status: reopened
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Changes (by andrew_b):
* milestone: 4.8.5 => Future Releases
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:25>
Ticket System
----------------------------+----------------------------------------
Type: enhancement | Status: closed
Component: mc-vfs | Version: master
Blocked By: | Blocking:
----------------------------+----------------------------------------
* status: reopened => closed
* votes: => committed-master
* version: 4.8.4 => master
* branch_state: no branch => merged
* milestone: Future Releases => 4.8.4
* resolution: => fixed
Comment:
Broken aliases will be fixed in #2923.
--
Ticket URL: <http://www.midnight-commander.org/ticket/1535#comment:26>