[Midnight Commander] #2586: Extended keybingings are broken

27 views
Skip to first unread message

Ticket System

unread,
Aug 2, 2011, 5:08:06 AM8/2/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
--------------------------------+---------------------------
Reporter: andrew_b | Owner:
Type: defect | Status: new
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Keywords: | Blocked By:
Blocking: | Branch state: no branch
Votes for changeset: |
--------------------------------+---------------------------
There are two bugs with extended keybingings in mcedit.

1. ctrl-x in default keymap is used twice:
a. as shotrcut for !WordRight action (see #2404)
a. as shortcut for extended keybindings mode. Because of #2404, we
should change shortcut for editor.ExtendedKeyMap action.
1. Extended shortcuts like '''ctrl-x ctrl-x''' or '''ctrl-x alt-x''' are
available but extended shortcuts like '''ctrl-x x''' are not.

--
Ticket URL: <www.midnight-commander.org/ticket/2586>
Midnight Commander <www.midnight-commander.org>
Midnight Development Center

Ticket System

unread,
Aug 2, 2011, 5:08:27 AM8/2/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
--------------------------+----------------------------------
Reporter: andrew_b | Owner:
Type: defect | Status: new
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+----------------------------------
Description changed by andrew_b:

Old description:

> There are two bugs with extended keybingings in mcedit.
>
> 1. ctrl-x in default keymap is used twice:
> a. as shotrcut for !WordRight action (see #2404)
> a. as shortcut for extended keybindings mode. Because of #2404, we
> should change shortcut for editor.ExtendedKeyMap action.
> 1. Extended shortcuts like '''ctrl-x ctrl-x''' or '''ctrl-x alt-x''' are
> available but extended shortcuts like '''ctrl-x x''' are not.

New description:

There are two bugs with extended keybingings in mcedit.

1. ctrl-x in default keymap is used twice:
a. as shotrcut for !WordRight action (see #2404)
a. as shortcut for extended keybindings mode. Because of #2404, we
should change shortcut for editor.!ExtendedKeyMap action.
1. Extended shortcuts like '''ctrl-x ctrl-x''' or '''ctrl-x alt-x''' are
available but extended shortcuts like '''ctrl-x x''' are not.

--

--
Ticket URL: <www.midnight-commander.org/ticket/2586#comment:1>

Ticket System

unread,
Aug 2, 2011, 6:38:12 AM8/2/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
--------------------------+----------------------------------------
Reporter: andrew_b | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
--------------------------+----------------------------------------
Changes (by andrew_b):

* keywords: => stable-candidate
* owner: => andrew_b
* status: new => accepted
* branch_state: no branch => on review


Comment:

Branch: 2586_mcedit_extended_keybindings (parent: master).
Initial changeset:b0583850c6f58de22ea89e045c7ea24df11fc4e2

--
Ticket URL: <www.midnight-commander.org/ticket/2586#comment:2>

Ticket System

unread,
Aug 15, 2011, 9:05:47 AM8/15/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
--------------------------+----------------------------------------
Reporter: andrew_b | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: on review | Votes for changeset: slavazanko
--------------------------+----------------------------------------
Changes (by slavazanko):

* votes: => slavazanko


--
Ticket URL: <www.midnight-commander.org/ticket/2586#comment:3>

Ticket System

unread,
Aug 24, 2011, 2:58:03 AM8/24/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
-------------------------+-------------------------------------------
Reporter: andrew_b | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Resolution: | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: slavazanko angel_il
-------------------------+-------------------------------------------
Changes (by angel_il):

* votes: slavazanko => slavazanko angel_il
* branch_state: on review => approved


--
Ticket URL: <www.midnight-commander.org/ticket/2586#comment:4>

Ticket System

unread,
Aug 26, 2011, 2:32:16 AM8/26/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
-------------------------+----------------------------------------
Reporter: andrew_b | Owner: andrew_b
Type: defect | Status: testing
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Resolution: fixed | Keywords: stable-candidate
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
-------------------------+----------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: slavazanko angel_il => committed-master
* resolution: => fixed
* branch_state: approved => merged


Comment:

Merged to master.
changeset:eb13abc437323a054a16bbc0c445cfe6b4e61f8d
{{{
git log --pretty=oneline c4af1f2..eb13abc
}}}

--
Ticket URL: <www.midnight-commander.org/ticket/2586#comment:5>

Ticket System

unread,
Sep 8, 2011, 6:51:15 AM9/8/11
to andrew....@gmail.com, mc-...@googlegroups.com
#2586: Extended keybingings are broken
-------------------------------------+-------------------------------------
Reporter: andrew_b | Owner: andrew_b
Type: defect | Status: closed
Priority: major | Milestone: 4.8.0-pre2
Component: mcedit | Version: 4.8.0-pre1
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-
| master committed-stable
-------------------------------------+-------------------------------------
Changes (by andrew_b):

* keywords: stable-candidate =>
* status: testing => closed
* votes: committed-master => committed-master committed-stable


Comment:

Cherry-picked to 4.7.5-stable.
Initial changeset:5f0cef1e6e8982cd0503d025d7c08a36f2fece74

--
Ticket URL: <www.midnight-commander.org/ticket/2586#comment:6>

Ladislav Hagara

unread,
Sep 13, 2011, 10:37:57 AM9/13/11
to mc-bugs
Fixed by removing ctrl-x as shortcut for extended keybindings mode?
What about removing it as shotrcut for !WordRight action?

Seems users are confused
http://mail.gnome.org/archives/mc/2011-September/msg00002.html
Reply all
Reply to author
Forward
0 new messages