should mvn clean -Ppurge clean solr indexes?

14 views
Skip to first unread message

Bindu Wavell

unread,
Apr 29, 2013, 12:07:55 AM4/29/13
to maven-a...@googlegroups.com
I think it should and I think it is not. I've got my poms all hacked up so it could just be that, but looking at the parent pom it looks like this was missed?

P.S. are you all interested in having folks (me) fork this stuff and send in pull requests? If so, where is this all hosted?

Thanks,


-- Bindu

Bindu Wavell

unread,
May 5, 2013, 7:21:07 PM5/5/13
to maven-a...@googlegroups.com
Answering my own question about where the sources are for these items: https://code.google.com/p/maven-alfresco-archetypes/

This info is available in the alfresco-lifecycle-aggregator-1.0.pom file. The code is in subversion so I could check out trunk code, but there doesn't appear to be a way to work or send pull requests with google code / subversion.

Will you accept patches, if so, what format would you like them in? And where should they be posted?

Any thoughts about if the purge profile should be deleting solr indexes? Since the associated contentstore is deleted I assume they should be and they are not.


-- Bindu

Gabriele Columbro

unread,
May 6, 2013, 4:29:40 AM5/6/13
to maven-a...@googlegroups.com
Hi Bindu,

very excited to see you are willing to contribute.

I just added your email address to the project committers in Google Code, so you should be all set to commit to trunk. Not sure though if that's a valid google code account, so feel free to mail me your google apps proper login.

Regarding the purge profile, I certainly agree the purge should remove the indexes as well. 

For implementing this (and in general), if you can open an issue and then document / refer the commit in which you fix it, that would be great. A feel free to push us (in the list) for a release when you feel it's necessary ;)

@All: please join me in welcoming Bindu to the Maven Alfresco community gotha :) 

Thanks for your participation and passion!

Gab
-- 
Gabriele Columbro
Principal Architect, 
Consulting Services



--
You received this message because you are subscribed to the Google Groups "Maven Alfresco Lifecycle Discussion Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to maven-alfresc...@googlegroups.com.
To post to this group, send email to maven-a...@googlegroups.com.
Visit this group at http://groups.google.com/group/maven-alfresco?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Bindu Wavell

unread,
May 9, 2013, 12:44:36 AM5/9/13
to maven-a...@googlegroups.com
Thanks so much Gab,

I was able to checkout the archetype code in way that I think means I have write access. Have not tried committing, will confirm once I get to that point.

It appears that the alfresco-sdk-parent is not included in this google code project? There are a several items in there I'd like to propose we change:

The version check as I indicated previously. Also I'd like to add a maven version check. We had a developer spend about 2 hours trying to figure out why their build was so borked because they were using maven2 :) 

Additionally the purge profile is also defined in there. So that's probably a good place to add the solr purging logic.

In my environment I have these items patched in my module poms. Since I have access to the archetypes I could do this in those... what do you think?

Gabriele Columbro

unread,
May 9, 2013, 6:00:29 AM5/9/13
to maven-a...@googlegroups.com
Hi Bindu.

You are welcome, let me know if you have issues.

The SDK parent is in there at 


I think your changes makes sense, but if you did not do it already, I'd ask you to open an issue at 
http://code.google.com/p/maven-alfresco-archetypes/issues/list for each change so we can discuss it and approve it as a community.

As a general rule, keep the archetypes skinny, so those kind of changes you are talking abut typically go in the sdk-parent.

Thanks for your interest and help,

Gab

Sent from my iPad

Bindu Wavell

unread,
May 9, 2013, 9:29:36 AM5/9/13
to maven-a...@googlegroups.com
I have not made any changes, to this code. I'll post issues and wait for discussion :)
Reply all
Reply to author
Forward
0 new messages