Re: [dev] [commits] Horde branch master updated. d9642d7776410243da77d669c457abec3f5959f2

[Jan Schneider]

> -----------------------------------------------------------------------
>
> commit f91bcfda7919b13cab4ab668411b3f187ad25a8f
> Author: Chuck Hagenbuch <ch...@horde.org>
> Date: Tue May 14 23:38:32 2013 -0400
>
> Add memcache caching of History info - drastically cuts number
> of SQL queries when loading Nag task list, for instance.
>
> Maybe should be reworked to use HashTable now?
>
> framework/Core/lib/Horde/Core/Factory/History.php | 8 +++++-
> framework/History/lib/Horde/History.php | 30
> ++++++++++++++++++++-
> framework/History/lib/Horde/History/Sql.php | 3 ++
> 3 files changed, 39 insertions(+), 2 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/f91bcfda7919b13cab4ab668411b3f187ad25a8f

This should be a generic Horde_Cache instance. And you must bump the
minor version, and add a @since tag. Also, Horde_Core can just require
that version of Horde_Cache and use the setter unconditionally.

> -----------------------------------------------------------------------
>
> commit a46957fbe67ec9410758852fb1f797595d837b5e
> Author: Chuck Hagenbuch <ch...@horde.org>
> Date: Tue May 14 23:40:23 2013 -0400
>
> This specifically needs to be a string, not just not false
>
> framework/Cache/lib/Horde/Cache.php | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/a46957fbe67ec9410758852fb1f797595d837b5e

What about integers?

> -----------------------------------------------------------------------
>
> commit d9642d7776410243da77d669c457abec3f5959f2
> Author: Chuck Hagenbuch <ch...@horde.org>
> Date: Tue May 14 23:40:36 2013 -0400
>
> Handle being passed 'memcache' or 'hashtable'
>
> framework/Cache/lib/Horde/Cache/Storage/Memcache.php | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> http://git.horde.org/horde-git/-/commit/d9642d7776410243da77d669c457abec3f5959f2

This shouldn't happen. Any code that knows about HashTable and still
uses Memcache should map the parameter names. What's the calling code
that made this necessary?
--
Jan Schneider
The Horde Project
http://www.horde.org/

--
dev mailing list
Frequently Asked Questions: http://wiki.horde.org/FAQ
To unsubscribe, mail: dev-uns...@lists.horde.org

[Thomas Jarosch]

On Wednesday, 15. May 2013 11:08:09 Jan Schneider wrote:
> > -----------------------------------------------------------------------
> >
> > commit f91bcfda7919b13cab4ab668411b3f187ad25a8f
> > Author: Chuck Hagenbuch <ch...@horde.org>
> > Date: Tue May 14 23:38:32 2013 -0400
> >
> > Add memcache caching of History info - drastically cuts number
> >
> > of SQL queries when loading Nag task list, for instance.
> >
> > Maybe should be reworked to use HashTable now?
> >
> > framework/Core/lib/Horde/Core/Factory/History.php | 8 +++++-
> > framework/History/lib/Horde/History.php | 30
> >
> > ++++++++++++++++++++-
> >
> > framework/History/lib/Horde/History/Sql.php | 3 ++
> > 3 files changed, 39 insertions(+), 2 deletions(-)
> >
> > http://git.horde.org/horde-git/-/commit/f91bcfda7919b13cab4ab668411b3f18
> > 7ad25a8f
>
> This should be a generic Horde_Cache instance. And you must bump the
> minor version, and add a @since tag. Also, Horde_Core can just require
> that version of Horde_Cache and use the setter unconditionally.

I'm getting unit test failures related to this:

# phpunit --filter testSynchronize -d include_path=/var/www/horde/libs:/usr/share/pear Unit/Data/Query/History/BaseTest.php
PHPUnit 3.7.18 by Sebastian Bergmann.

Configuration read from /datastore/DEVEL/horde/framework/Kolab_Storage/test/Horde/Kolab/Storage/phpunit.xml

E

Time: 1 second, Memory: 5.50Mb

There was 1 error:

1) Horde_Kolab_Storage_Unit_Data_Query_History_BaseTest::testSynchronize
Undefined property: Horde_History_Mock::$_memcache
...


Adding a "protected $_memcache" class member to Horde_History fixes this.

Thomas