Re: [PATCH] Add tests for our NFSv4 ACL code

[Christian Ambach]

On 05/06/2013 08:47 PM, Andrew Bartlett wrote:

> I certainly think we should. Indeed, I think we should similarly always
> build zfsacls if we are on a supporting platform and likewise for all
> the other optional modules.

A patch that makes AIX always compile vfs_aixacl2 has found its way
through autobuild.
I am not familiar enough with ZFS platforms, so I'll leave this for others.

Cheers,
Christian

[Andrew Bartlett]

Thanks. I looked again and it's trickier than I remembered. I'll add a
configure test for the header structures we need, as they reused the old
acl() API, just with different constants and structures (cast to void*!
).

Andrew Bartlett

--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org

[Abhidnya S Joshi]

Hi Andrew,

Can we get the logs again, so that I can have a look?

Thanks
Abhidnya



From: Andrew Bartlett <abar...@samba.org>
To: Abhidnya S Joshi/India/IBM@IBMIN,
Cc: samba-t...@lists.samba.org, j...@samba.org
Date: 05/09/2013 03:00 PM
Subject: Re: [PATCH] Add tests for our NFSv4 ACL code



On Wed, 2013-04-24 at 17:55 +0530, Abhidnya S Joshi wrote:
> Hi Andrew,
>
> Thanks for the review comments. While I take care of these, I would like

> to have one more test which checks inheritance for nfs4:mode
> specialcreator. This test fails currently for mode special and would
pass
> with bug 9467 fix.

I just wanted to let you know that I had to drop these from the patch
set I just built, as they give unexpected success (yes really) on
sn-devel but not locally.

We need to work out why. I lost the logs, but from memory it was:

samba4.raw.acls.*.inherit_creator_group

[Andrew Bartlett]

On Mon, 2013-05-20 at 11:36 +0530, Abhidnya S Joshi wrote:
> Hi Andrew,
>

> Can we get the logs again, so that I can have a look?

Here is what autobuild gives:

TESTING CREATOR GROUP
UNEXPECTED(uxsuccess): samba4.raw.acls.inherit_creator_group(dc)
REASON: Content-Type: text/plain;charset=utf8
reason
0

FAILED (0 failures, 0 errors and 1 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
./bin/ab/summary


But on my laptop (Fedora 18) it gives:

[1/1 in 0s] samba4.raw.acls(dc)
samba: EOF on stdin - terminating
samba child process 10437 exited with value 0

ALL OK (12 tests in 1 testsuites)


Removing the knownfail is the trivial fix, but I would like to know why
it always fails on my laptop, and always succeeds on sn-devel.

[Christian Ambach]

On 05/21/2013 04:08 AM, Andrew Bartlett wrote:
> Here is what autobuild gives:
>
> TESTING CREATOR GROUP
> UNEXPECTED(uxsuccess): samba4.raw.acls.inherit_creator_group(dc)
> REASON: Content-Type: text/plain;charset=utf8
> reason
> 0
>
> FAILED (0 failures, 0 errors and 1 unexpected successes in 0 testsuites)
>
> A summary with detailed information can be found in:
> ./bin/ab/summary

For me, an autobuild of master plus the
4-smbtorture: Test inheritance for specialcreator mode with nfs4 acls patch
resulted in:
==> samba.stdout <==
TESTING NFS4 INHERITANCE
UNEXPECTED(failure): samba3.raw.acls.inheritance-special(s3dc)
REASON: _StringException: _StringException:
../source4/torture/raw/acls.c:2261 No user specified!

Looks like the necessary setup for the test in the patch needs to be
added in the environment to make this run in autobuild.

>
> But on my laptop (Fedora 18) it gives:
>
> [1/1 in 0s] samba4.raw.acls(dc)
> samba: EOF on stdin - terminating
> samba child process 10437 exited with value 0
>
> ALL OK (12 tests in 1 testsuites)
>

Same thing on my F17 box:
TESTING NFS4 INHERITANCE
UNEXPECTED(failure): samba4.raw.acls.inheritance-special(dc)
REASON: _StringException: _StringException:
../source4/torture/raw/acls.c:2261 No user specified!

But this is probably also caused by wrong test setup.

Maybe I did not use the latest version of the patch?

Cheers,
Christian

[Abhidnya S Joshi]

Hi Christian,

Yes, for this test I am trying to add new user in test framework like
pdbtest user. However the problematic test right now is creator_group
which succeeds unexpectedly.

Thanks
Abhidnya

From: Christian Ambach <am...@samba.org>
To: Andrew Bartlett <abar...@samba.org>, Abhidnya S
Joshi/India/IBM@IBMIN,
Cc: samba-t...@lists.samba.org
Date: 05/21/2013 06:16 PM
Subject: Re: [PATCH] Add tests for our NFSv4 ACL code