Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] winbind: Print error code on connection error in ping_dc

7 views
Skip to first unread message

Christof Schmitt

unread,
May 24, 2013, 3:40:49 PM5/24/13
to
For debugging, it is useful to include the error code in the message.
---
source3/winbindd/winbindd_dual_srv.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/source3/winbindd/winbindd_dual_srv.c b/source3/winbindd/winbindd_dual_srv.c
index 744e251..e23d048 100644
--- a/source3/winbindd/winbindd_dual_srv.c
+++ b/source3/winbindd/winbindd_dual_srv.c
@@ -690,7 +690,8 @@ NTSTATUS _wbint_PingDc(struct pipes_struct *p, struct wbint_PingDc *r)
status = cm_connect_netlogon(domain, &netlogon_pipe);
reset_cm_connection_on_error(domain, status);
if (!NT_STATUS_IS_OK(status)) {
- DEBUG(3, ("could not open handle to NETLOGON pipe\n"));
+ DEBUG(3, ("could not open handle to NETLOGON pipe: %s\n",
+ nt_errstr(status)));
return status;
}

--
1.7.1

Jeremy Allison

unread,
May 24, 2013, 8:05:17 PM5/24/13
to
+1 Reviewed-by: Jeremy Allison <j...@samba.org>

Michael Adam

unread,
May 25, 2013, 7:03:42 AM5/25/13
to
I also review+ and would push,
but before pushing, since is currently in discussion:

Christof: Can we add your "signed-off-by" tag?
In the future, could you post patches with sign-off?

I assume that your patches are submitted under personal
copyright. correct?

Cheers - Michael
signature.asc

Christof Schmitt

unread,
May 25, 2013, 2:35:11 PM5/25/13
to
For debugging, it is useful to include the error code in the message.

Signed-off-by: Christof Schmitt <christof...@us.ibm.com>
---
source3/winbindd/winbindd_dual_srv.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/source3/winbindd/winbindd_dual_srv.c b/source3/winbindd/winbindd_dual_srv.c
index 744e251..e23d048 100644
--- a/source3/winbindd/winbindd_dual_srv.c
+++ b/source3/winbindd/winbindd_dual_srv.c
@@ -690,7 +690,8 @@ NTSTATUS _wbint_PingDc(struct pipes_struct *p, struct wbint_PingDc *r)
status = cm_connect_netlogon(domain, &netlogon_pipe);
reset_cm_connection_on_error(domain, status);
if (!NT_STATUS_IS_OK(status)) {
- DEBUG(3, ("could not open handle to NETLOGON pipe\n"));
+ DEBUG(3, ("could not open handle to NETLOGON pipe: %s\n",
+ nt_errstr(status)));
return status;
}

--
1.7.1

Christof Schmitt

unread,
May 25, 2013, 2:37:53 PM5/25/13
to
On Sat, May 25, 2013 at 01:03:42PM +0200, Michael Adam wrote:
> I also review+ and would push,
> but before pushing, since is currently in discussion:
>
> Christof: Can we add your "signed-off-by" tag?
> In the future, could you post patches with sign-off?
>
> I assume that your patches are submitted under personal
> copyright. correct?
>
> Cheers - Michael

Yes, the patches are submitted under my personal copyright. I
resubmitted the patch with the "Signed-off-by" tag:
https://lists.samba.org/archive/samba-technical/2013-May/092689.html

--
Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof...@us.ibm.com || +1-520-799-2469 (T/L: 321-2469)

Christian Ambach

unread,
May 25, 2013, 3:50:51 PM5/25/13
to
Am 25.05.13 20:35, schrieb Christof Schmitt:
> For debugging, it is useful to include the error code in the message.
>
> Signed-off-by: Christof Schmitt <christof...@us.ibm.com>

Pushed, thanks!

Cheers,
Christian

Michael Adam

unread,
May 26, 2013, 6:24:55 AM5/26/13
to
Hi Christof,

On 2013-05-25 at 11:37 -0700, Christof Schmitt wrote:
> On Sat, May 25, 2013 at 01:03:42PM +0200, Michael Adam wrote:
> > I also review+ and would push,
> > but before pushing, since is currently in discussion:
> >
> > Christof: Can we add your "signed-off-by" tag?
> > In the future, could you post patches with sign-off?
> >
> > I assume that your patches are submitted under personal
> > copyright. correct?
>
> Yes, the patches are submitted under my personal copyright. I
> resubmitted the patch with the "Signed-off-by" tag:
> https://lists.samba.org/archive/samba-technical/2013-May/092689.html

Thanks for the confirmation.
The patch has landed in master.

Cheers - Michael

0 new messages