Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] pdbedit.c: the exit code should be 0 when '--policies-reset' is success

2 views
Skip to first unread message

Peng Haitao

unread,
May 22, 2013, 4:47:19 AM5/22/13
to
When '--policies-reset' is success, the exit code should be 0.

Signed-off-by: Peng Haitao <pen...@cn.fujitsu.com>
---
source3/utils/pdbedit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/utils/pdbedit.c b/source3/utils/pdbedit.c
index 908f0ba..8e3a5a5 100644
--- a/source3/utils/pdbedit.c
+++ b/source3/utils/pdbedit.c
@@ -1181,7 +1181,7 @@ int main (int argc, char **argv)
}

if (reset_account_policies) {
- if (!reinit_account_policies()) {
+ if (reinit_account_policies()) {
exit(1);
}

--
1.8.1.4

Jeremy Allison

unread,
May 22, 2013, 2:24:53 PM5/22/13
to
On Wed, May 22, 2013 at 04:47:19PM +0800, Peng Haitao wrote:
> When '--policies-reset' is success, the exit code should be 0.
>
> Signed-off-by: Peng Haitao <pen...@cn.fujitsu.com>

+1

Reviewed-by: Jeremy Allison <j...@samba.org>

> ---
> source3/utils/pdbedit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source3/utils/pdbedit.c b/source3/utils/pdbedit.c
> index 908f0ba..8e3a5a5 100644
> --- a/source3/utils/pdbedit.c
> +++ b/source3/utils/pdbedit.c
> @@ -1181,7 +1181,7 @@ int main (int argc, char **argv)
> }
>
> if (reset_account_policies) {
> - if (!reinit_account_policies()) {
> + if (reinit_account_policies()) {
> exit(1);
> }
>
> --
> 1.8.1.4

Can I get a second Team +1 and I'll push !

Thanks,

Jeremy.

Michael Adam

unread,
May 22, 2013, 4:54:49 PM5/22/13
to
On 2013-05-22 at 11:24 -0700, Jeremy Allison wrote:
> On Wed, May 22, 2013 at 04:47:19PM +0800, Peng Haitao wrote:
> > When '--policies-reset' is success, the exit code should be 0.
> >
> > Signed-off-by: Peng Haitao <pen...@cn.fujitsu.com>
>
> +1
>
> Reviewed-by: Jeremy Allison <j...@samba.org>

Reviewed-by: Michael Adam <ob...@samba.org>


signature.asc
0 new messages