Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 1/2] idl: Add DNS RP record support as per RFC 1183

3 views
Skip to first unread message

Kai Blin

unread,
May 25, 2013, 8:05:21 AM5/25/13
to
Not sure if we need this, bug samba.org specifies it, so this could cause ANY
queries against samba.org to fail.

Signed-off-by: Kai Blin <k...@samba.org>
---
librpc/idl/dns.idl | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/librpc/idl/dns.idl b/librpc/idl/dns.idl
index 984f2b3..7d29278 100644
--- a/librpc/idl/dns.idl
+++ b/librpc/idl/dns.idl
@@ -161,6 +161,12 @@ interface dns
} dns_txt_record;

typedef [public] struct {
+ dns_string mbox;
+ dns_string txt;
+
+ } dns_rp_record;
+
+ typedef [public] struct {
uint16 priority;
uint16 weight;
uint16 port;
@@ -214,6 +220,7 @@ interface dns
[case(DNS_QTYPE_PTR)] dns_string ptr_record;
[case(DNS_QTYPE_MX)] dns_mx_record mx_record;
[case(DNS_QTYPE_TXT)] dns_txt_record txt_record;
+ [case(DNS_QTYPE_RP)] dns_rp_record rp_record;
[case(DNS_QTYPE_AAAA)] ipv6address ipv6_record;
[case(DNS_QTYPE_SRV)] dns_srv_record srv_record;
[case(DNS_QTYPE_TSIG)] dns_tsig_record tsig_record;
--
1.8.1.2

Kai Blin

unread,
May 25, 2013, 8:05:22 AM5/25/13
to
Not sure if we need this, bug samba.org specifies it, so this can cause ANY queries
against samba.org to fail.

Signed-off-by: Kai Blin <k...@samba.org>
---
librpc/idl/dns.idl | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/librpc/idl/dns.idl b/librpc/idl/dns.idl
index 7d29278..28dddad 100644
--- a/librpc/idl/dns.idl
+++ b/librpc/idl/dns.idl
@@ -151,6 +151,13 @@ interface dns
} dns_soa_record;

typedef [public] struct {
+ [value(strlen(cpu))] uint8 cpu_length;
+ [charset(DOS)] uint8 cpu[cpu_length];
+ [value(strlen(os))] uint8 os_length;
+ [charset(DOS)] uint8 os[os_length];
+ } dns_hinfo_record;
+
+ typedef [public] struct {
uint16 preference;
dns_string exchange;
} dns_mx_record;
@@ -218,6 +225,7 @@ interface dns
[case(DNS_QTYPE_CNAME)] dns_string cname_record;
[case(DNS_QTYPE_SOA)] dns_soa_record soa_record;
[case(DNS_QTYPE_PTR)] dns_string ptr_record;
+ [case(DNS_QTYPE_HINFO)] dns_hinfo_record hinfo_record;
[case(DNS_QTYPE_MX)] dns_mx_record mx_record;
[case(DNS_QTYPE_TXT)] dns_txt_record txt_record;
[case(DNS_QTYPE_RP)] dns_rp_record rp_record;
--
1.8.1.2

Andrew Bartlett

unread,
May 26, 2013, 7:12:59 AM5/26/13
to
On Sat, 2013-05-25 at 14:05 +0200, Kai Blin wrote:
> A bug reproducer I recently dealt with used dig @samba -t any samba.org as
> reproducer. This failed on the internal server because the RP and HINFO RR
> types were missing. This adds these types and makes dig -t any samba.org work.
>
> Kai Blin (2):
> idl: Add DNS RP record support as per RFC 1183
> idl: Add DNS HINFO record support
>
> librpc/idl/dns.idl | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)

I was trying to push both this and your other DNS patch, but looking at
your git tree, it's not clear they are ready to be used together (I get
it am conflicts no matter which one I do first). Can you push me a
branch or mail series with both sets applied, so I can get these into
master?

Thanks,

Andrew Bartlett

--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org

0 new messages