Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
[PATCH] Match autoconf build for config.h on FreeBSD for statfs
0 views
Skip to first unread message
Andrew Bartlett
May 21, 2013, 10:19:37 AM5/21/13
to
This patch makes the waf build match the autoconf build.
Björn,
Can you please confirm this still does what you want? Is the autoconf
check correct, or did you want to move to a 'better' solution (and so
have them out of sync).
I've not run these, just compiled them and confirmed the config.h
difference.
Thanks,
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Björn,
Can you please confirm this still does what you want? Is the autoconf
check correct, or did you want to move to a 'better' solution (and so
have them out of sync).
I've not run these, just compiled them and confirmed the config.h
difference.
Thanks,
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Andrew Bartlett
May 21, 2013, 6:27:36 PM5/21/13
to
On Wed, 2013-05-22 at 00:19 +1000, Andrew Bartlett wrote:
> This patch makes the waf build match the autoconf build.
>
> Björn,
>
> Can you please confirm this still does what you want? Is the autoconf
> check correct, or did you want to move to a 'better' solution (and so
> have them out of sync).
>
> I've not run these, just compiled them and confirmed the config.h
> difference.
I've now run with and without this change on FreeBSD, and can't tell the
> This patch makes the waf build match the autoconf build.
>
> Björn,
>
> Can you please confirm this still does what you want? Is the autoconf
> check correct, or did you want to move to a 'better' solution (and so
> have them out of sync).
>
> I've not run these, just compiled them and confirmed the config.h
> difference.
difference (at least with smbclient's du), but it seems important given
the history on the bug to have these two configure tests in line.
Andrew Bartlett
May 23, 2013, 6:56:16 AM5/23/13
to
On Wed, 2013-05-22 at 00:19 +1000, Andrew Bartlett wrote:
> This patch makes the waf build match the autoconf build.
>
> Björn,
>
> Can you please confirm this still does what you want? Is the autoconf
> check correct, or did you want to move to a 'better' solution (and so
> have them out of sync).
>
> I've not run these, just compiled them and confirmed the config.h
> difference.
Richard,
> This patch makes the waf build match the autoconf build.
>
> Björn,
>
> Can you please confirm this still does what you want? Is the autoconf
> check correct, or did you want to move to a 'better' solution (and so
> have them out of sync).
>
> I've not run these, just compiled them and confirmed the config.h
> difference.
Can you review this patch for me? It makes the waf build match the
autoconf build, which seems to have been the intent here, missed only
due to a subtle detail about the way the waf test was constructed. (The
statvfs method was detected first).
Thanks,
0 new messages