Missing attribute from Amavis LDAP schema for LDAP disclaimer support

[Quanah Gibson-Mount]

Hi Mark,

I was reading through the release notes, and it appears you did attempt to
get the dynamic altermime fix into Amavis. However, it appears incomplete.

>From the release notes:

BUG FIXES SINCE 2.6.4

- added LDAP attribute amavisDisclaimerOptions, along with its corresponding
SQL field 'disclaimer_options'. It finds its way to the list of lookup
tables @disclaimer_options_bysender_maps, so the replacement of the
_OPTIONS_ placeholder in @altermime_args_disclaimer could be made dynamic;
suggested by Quanah Gibson-Mount;

However, there is no such attribute in the Amavis LDAP schema. Is this
because there is more work remaining, or is it expected the feature should
work as long as the attribute actually exists?

It is only referenced in amavisd:

@ldap_attrs = qw(amavisLocal amavisMessageSizeLimit
amavisVirusLover amavisSpamLover amavisUncheckedLover
amavisBannedFilesLover amavisBadHeaderLover
amavisBypassVirusChecks amavisBypassSpamChecks
amavisBypassBannedChecks amavisBypassHeaderChecks
amavisSpamTagLevel amavisSpamTag2Level amavisSpamKillLevel
amavisSpamDsnCutoffLevel amavisSpamQuarantineCutoffLevel
amavisSpamSubjectTag amavisSpamSubjectTag2 amavisSpamModifiesSubj
amavisVirusQuarantineTo amavisSpamQuarantineTo amavisBannedQuarantineTo
amavisUncheckedQuarantineTo amavisBadHeaderQuarantineTo
amavisCleanQuarantineTo amavisArchiveQuarantineTo
amavisAddrExtensionVirus amavisAddrExtensionSpam
amavisAddrExtensionBanned amavisAddrExtensionBadHeader
amavisWarnVirusRecip amavisWarnBannedRecip amavisWarnBadHeaderRecip
amavisVirusAdmin amavisNewVirusAdmin amavisSpamAdmin
amavisBannedAdmin amavisBadHeaderAdmin
amavisBannedRuleNames amavisDisclaimerOptions
amavisForwardMethod amavisSaUserConf amavisSaUserName
amavisBlacklistSender amavisWhitelistSender
);

unshift(@Amavis::Conf::disclaimer_options_bysender_maps,

$lf->('amavisDisclaimerOptions', 'S-'));

Thanks,
Quanah


--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra :: the leader in open source messaging and collaboration

[Quanah Gibson-Mount]

--On Friday, June 14, 2013 3:04 PM -0700 Quanah Gibson-Mount

<qua...@zimbra.com> wrote:

> Hi Mark,
>
> I was reading through the release notes, and it appears you did attempt
> to get the dynamic altermime fix into Amavis. However, it appears
> incomplete.

Hi Mark,

I created the attribute in my amavis builds with the following definition.
Not sure how you intended it to be:

olcAttributeTypes: {46}( 1.3.6.1.4.1.15312.2.2.1.47 NAME
'amavisDisclaimerOpti
ons' DESC 'Altermime disclaimer map data' EQUALITY caseIgnoreIA5Match
SUBSTR
caseIgnoreIA5SubstringsMatch SYNTAX 1.3.6.1.4.1.1466.115.121.1.26{256}
SINGLE
-VALUE )

With this in place, I can now enable/disable per-domain disclaimers without
having to restart Amavis, which is great!

--Quanah

[Zhang Huangbin]

On Saturday, June 15, 2013 at 8:58 AM, Quanah Gibson-Mount wrote:

>
> Hi Mark,
>
> I created the attribute in my amavis builds with the following definition.
> Not sure how you intended it to be:
>
> olcAttributeTypes: {46}( 1.3.6.1.4.1.15312.2.2.1.47 NAME
> 'amavisDisclaimerOpti
> ons' DESC 'Altermime disclaimer map data' EQUALITY caseIgnoreIA5Match
> SUBSTR
> caseIgnoreIA5SubstringsMatch SYNTAX 1.3.6.1.4.1.1466.115.121.1.26{256}
> SINGLE
> -VALUE )
>
> With this in place, I can now enable/disable per-domain disclaimers without
> having to restart Amavis, which is great!

Hi Quanah,

Would you mind sharing related Amavisd config about this feature? and what do
you save in "amavisDisclaimerOptions"?

[zhbmail...@gmail.com]

Hi Quanah,

I added LDAP attribute "amavisDisclaimerOption" by copying your schema define, add "amavisDisclaimerOption=domain.ltd" (file name of disclaimer file), Amavisd/AlterMIME find my disclaimer file and it works too.

Hope Mark will add this LDAP attribute in next release of Amavisd-new. :)