Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Re: pf uses freed memory
0 views
Skip to first unread message
Mike Belopuhov
May 8, 2013, 12:05:59 PM5/8/13
to
On 6 May 2013 08:43, Vitaly Sinilin <v...@kp4.ru> wrote:
> On Fri, 3 May 2013 21:26:57 +0200
> Mike Belopuhov <mi...@belopuhov.com> wrote:
>
> [skip]
>
>> Thanks for figuring this out. Unfortunately, I think your diff
>> is slightly wrong. Since skw and sks are distinct pointers you
>> need to keep them in sync when they're equal, otherwise sks will
>> point to the old memory. The diff below resets state keys after
>> pf_state_key_attach.
>
> Yes, you are right. As this branch (*sks == *skw) wasn't the case for
> my problem I didn't pay enough attention to it. My bad.
>
>> Would you be so kind to verify that it still fixes the original
>> problem?
>
> Just tested the kernel with the modified patch applied. It works for me
> as well.
>
I'm looking for OK on this.
> On Fri, 3 May 2013 21:26:57 +0200
> Mike Belopuhov <mi...@belopuhov.com> wrote:
>
> [skip]
>
>> Thanks for figuring this out. Unfortunately, I think your diff
>> is slightly wrong. Since skw and sks are distinct pointers you
>> need to keep them in sync when they're equal, otherwise sks will
>> point to the old memory. The diff below resets state keys after
>> pf_state_key_attach.
>
> Yes, you are right. As this branch (*sks == *skw) wasn't the case for
> my problem I didn't pay enough attention to it. My bad.
>
>> Would you be so kind to verify that it still fixes the original
>> problem?
>
> Just tested the kernel with the modified patch applied. It works for me
> as well.
>
I'm looking for OK on this.
0 new messages