proposal: add --disable-tests to www/firefox3 port

[Eitan Adler]

ac_add_options --disable-tests
By default, many auxiliary test applications are built, which can
help debug and patch the mozilla source. Disabling these tests can speed
build time and reduce disk space considerably [1]

Most users don't need these tests built unless they plan on helping
debug and patch the mozilla source.

I think we should add it to MOZ_OPTIONS in www/firefox3. If it exists
for firefox2 I propose adding it to firefox2 as well (especially since
firefox2 is going to be EOL soon).

[1] https://developer.mozilla.org/en/Configuring_Build_Options
--
Eitan Adler
GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1
_______________________________________________
freebs...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-port...@freebsd.org"

[Doug Barton]

Eitan Adler wrote:
> ac_add_options --disable-tests
> By default, many auxiliary test applications are built, which can
> help debug and patch the mozilla source. Disabling these tests can speed
> build time and reduce disk space considerably [1]
>
> Most users don't need these tests built unless they plan on helping
> debug and patch the mozilla source.
>
> I think we should add it to MOZ_OPTIONS in www/firefox3. If it exists
> for firefox2 I propose adding it to firefox2 as well (especially since
> firefox2 is going to be EOL soon).
>
> [1] https://developer.mozilla.org/en/Configuring_Build_Options

Perhaps this could be part of the WITH_DEBUG option?

Doug

--

This .signature sanitized for your protection

[Garrett Cooper]

On Dec 23, 2008, at 13:39, Doug Barton <do...@FreeBSD.org> wrote:

> Eitan Adler wrote:
>> ac_add_options --disable-tests
>> By default, many auxiliary test applications are built, which can
>> help debug and patch the mozilla source. Disabling these tests can
>> speed
>> build time and reduce disk space considerably [1]
>>
>> Most users don't need these tests built unless they plan on helping
>> debug and patch the mozilla source.
>>
>> I think we should add it to MOZ_OPTIONS in www/firefox3. If it
>> exists
>> for firefox2 I propose adding it to firefox2 as well (especially
>> since
>> firefox2 is going to be EOL soon).
>>
>> [1] https://developer.mozilla.org/en/Configuring_Build_Options
>
> Perhaps this could be part of the WITH_DEBUG option?
>
> Doug

I agree with Doug.
-Garrett

[Eitan Adler]

>> Perhaps this could be part of the WITH_DEBUG option?

Like this?
--- firefox3/Makefile 2008-12-19 15:13:01.000000000 -0500
+++ firefox-new/Makefile 2008-12-23 19:07:09.000000000 -0500
@@ -57,6 +57,10 @@

.include <bsd.port.pre.mk>

+.if defined(WITHOUT_DEBUG)
+MOZ_OPTIONS+= --disable-tests
+.endif
+
GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg:
%{pthread:' | ${SED} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE}

Also
WARN: Makefile: [SMB is listed in OPTIONS, but neither WITH_SMB nor
WITHOUT_SMB appears.]:
WARN: Makefile: [LOGGING is listed in OPTIONS, but neither WITH_LOGGING
nor WITHOUT_LOGGING appears.]:
WARN: Makefile: [OPTIMIZED_CFLAGS is listed in OPTIONS, but neither
WITH_OPTIMIZED_CFLAGS nor WITHOUT_OPTIMIZED_CFLAGS appears.]:

Are they used at all? should they just be removed?

--
Eitan Adler
GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1

[Garrett Cooper]

Looks good. The suggestion to remove those flags first warrants
checking the mozilla include makefile.
Cheers,
-Garrett

[Dmitry Marakasov]

* Eitan Adler (eitanad...@gmail.com) wrote:

I'd suggest
-+.if defined(WITHOUT_DEBUG)
++.if !defined(WITH_DEBUG)

DEBUG knob is assumed to defauly to false, this WITH_DEBUG is checked
everywhere. See `grep -R _DEBUG /usr/ports/Mk`

--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amd...@amdmi3.ru ..: jabber: amd...@jabber.ru http://www.amdmi3.ru