Re: ports/179637: [patch] ports-mgmt/portupdate-scan: add the "-a [date]" option

[ed...@freebsd.org]

Synopsis: [patch] ports-mgmt/portupdate-scan: add the "-a [date]" option

State-Changed-From-To: open->feedback
State-Changed-By: edwin
State-Changed-When: Tue Jun 18 19:07:49 UTC 2013
State-Changed-Why:
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

http://www.freebsd.org/cgi/query-pr.cgi?pr=179637
_______________________________________________
freebsd-p...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-b...@freebsd.org"

[Edwin Groothuis]

The following reply was made to PR ports/179637; it has been noted by GNATS.

From: Edwin Groothuis <ed...@FreeBSD.org>
To: al...@stangl.us
Cc: bug-fo...@FreeBSD.org
Subject: Re: ports/179637: [patch] ports-mgmt/portupdate-scan: add the "-a [date]" option
Date: Tue, 18 Jun 2013 19:07:48 UT

Maintainer of ports-mgmt/portupdate-scan,

Please note that PR ports/179637 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179637

--
Edwin Groothuis via the GNATS Auto Assign Tool
ed...@FreeBSD.org

[Alex Stangl]

The following reply was made to PR ports/179637; it has been noted by GNATS.

From: Alex Stangl <al...@stangl.us>
To: bug-fo...@FreeBSD.org
Cc:
Subject: Re: ports/179637: [patch] ports-mgmt/portupdate-scan: add the "-a
[date]" option

Date: Tue, 18 Jun 2013 18:20:06 -0500

On Tue, Jun 18, 2013 at 07:07:48PM +0000, Edwin Groothuis wrote:
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

I basically agree with this patch, but would like to see changes
made to address a few issues:

1. Need to bump the version # in the Makefile.
2. Spacing inconsistent with existing code and extra space in usage line.
3. Instead of 3 lines to immediately exit, it'd be shorter and cleaner
to use:
last if $res <= $afterDate;

Should I submit an alternate patch?

Alex