ports/126518: Unbroke archivers/lzo2 on i386
Dima Panov
>Number: 126518
>Category: ports
>Synopsis: Unbroke archivers/lzo2 on i386
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Thu Aug 14 00:00:07 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Dima Panov
>Release: FreeBSD 8.0-800042-CURRENT i386
>Organization:
>Environment:
System: FreeBSD 8.0-800042-CURRENT #0: Wed Aug 13 09:33:26 VLAST 2008
ro...@Fluffy.Khv.RU:/usr/obj/usr/src/sys/Spot
>Description:
Yesterday archivers/lzo2 was make BROKEN on i386, which is huge mistake - it is not broken, it loop in optional tests.
Main library is fine, and anything built aganist it run as well.
>How-To-Repeat:
>Fix:
--- archivers::lzo2.diff begins here ---
Index: archivers/lzo2/Makefile
===================================================================
RCS file: /home/ncvs/ports/archivers/lzo2/Makefile,v
retrieving revision 1.43
diff -u -r1.43 Makefile
--- archivers/lzo2/Makefile 13 Aug 2008 14:59:41 -0000 1.43
+++ archivers/lzo2/Makefile 13 Aug 2008 23:47:49 -0000
@@ -24,9 +24,12 @@
CONFIGURE_ARGS= --enable-shared
USE_LDCONFIG= yes
+
+.if defined(ARCH) && ${ARCH} != "i386"
post-build:
@${ECHO_MSG} "===> Running self-tests for ${PKGNAME} (can take a few minutes, without output)"
cd ${WRKSRC} && ${MAKE} test
+.endif
post-install:
.if !defined(NOPORTDOCS)
@@ -45,8 +48,5 @@
.include <bsd.port.pre.mk>
-.if ${ARCH} == i386
-BROKEN= does not build
-.endif
.include <bsd.port.post.mk>
--- archivers::lzo2.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
freebsd-p...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-b...@freebsd.org"
ed...@freebsd.org
State-Changed-From-To: open->feedback
State-Changed-By: edwin
State-Changed-When: Thu Aug 14 00:00:18 UTC 2008
State-Changed-Why:
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
http://www.freebsd.org/cgi/query-pr.cgi?pr=126518
Edwin Groothuis
From: Edwin Groothuis <ed...@FreeBSD.org>
To: matthia...@gmx.de
Cc: bug-fo...@FreeBSD.org
Subject: Re: ports/126518: Unbroke archivers/lzo2 on i386
Date: Thu, 14 Aug 2008 00:00:15 UT
Maintainer of archivers/lzo2,
Please note that PR ports/126518 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126518
--
Edwin Groothuis via the GNATS Auto Assign Tool
ed...@FreeBSD.org
Matthias Andree
From: Matthias Andree <matthia...@gmx.de>
To: bug-fo...@FreeBSD.org
Cc:
Subject: Re: ports/126518: Unbroke archivers/lzo2 on i386
Date: Thu, 14 Aug 2008 10:36:11 +0200
On Thu, 14 Aug 2008, Edwin Groothuis wrote:
> Please note that PR ports/126518 has just been submitted.
Not my business. I didn't mark lzo2 broken and wouldn't have approved of
it. lzo2 builds fine on my 6-STABLE and 7-STABLE i386 machines.
And if ports are marked broken behind my back, I'll just stop
maintaining ports and do not want to be bothered with the fallout.
I'd suggest to revert ports/archivers/lzo2/Makefile rev 1.43 to 1.42.
I know I have a virtual 8-CURRENT machine to log into so I can
investigate, but I have a real-life job to do as well, so I cannot
always respond "over night".
--
Matthias Andree
Matthias Andree
From: Matthias Andree <matthia...@gmx.de>
To: bug-fo...@FreeBSD.org
Cc:
Subject: Re: ports/126518: Unbroke archivers/lzo2 on i386
Date: Thu, 14 Aug 2008 10:56:45 +0200
Alternatively and untested, just try what happens if you commit the
patch from this PR. I simply don't want to be bothered with unnecessary
extra work, I have sufficiently little time to be rather annoyed by
erwin's marking the port broken while security/* ports depend on it.
Rick van der Zwet
From: "Rick van der Zwet" <ri...@wzoeterwoude.net>
To: bug-fo...@FreeBSD.org, flu...@fluffy.khv.ru
Cc: lin...@lonesome.com
Subject: Re: ports/126518: Unbroke archivers/lzo2 on i386
Date: Fri, 15 Aug 2008 13:27:13 +0200
I truly think the maintainer is right about this, the problem is a
false negative of the automated build/test grid. The maintainer
clearly notes a might take a few minutes to complete (without any
output):
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.8.20080809105349/lzo2-2.03_1.log
===> Running self-tests for lzo2-2.03_1 (can take a few minutes,
without output)
But the testgrid only allows it 7200 seconds:
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.8.20080809105349/lzo2-2.03_1.log
/pnohang: killing make build (lzo2-2.03_1, pid 40244 and 40242) since
no output in 7200 seconds since Sat Aug 9 17:12:37 2008
Just disabling the test, as suggested in the patch of ports/126518
will I my opinion not be the right choice. As no time limits are given
into the porters handbook (and properly never will), best to adjust
the test system. Included linimon, who should shine his brilliant
lights on the matter :-) I guess.
/Rick
--
http://rickvanderzwet.nl