Please pay attention to fix bug kern/141285

Prokofyev S.P.

unread,

Mar 19, 2010, 10:40:44 AM3/19/10

to

Hi ALL !

Please pay attention to fix bug kern/141285(kern/141843) !

Thank you very much!
_______________________________________________
freeb...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net...@freebsd.org"

Xin LI

unread,

Mar 19, 2010, 12:47:45 PM3/19/10

to

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2010/03/19 07:40, Prokofyev S.P. wrote:
> Hi ALL !
>
> Please pay attention to fix bug kern/141285(kern/141843) !

Looking at the PR, it seems that Pyun have a patch against em(4) and
there is some confirmation that it has fixed the issue. Did it solved
your problem?

Cheers,
- --
Xin LI <del...@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iQEcBAEBAgAGBQJLo6qxAAoJEATO+BI/yjfBX4cIAMvBqAMLSuSDIZYy4F2thDdq
Niv4Phq7Ob9xrmpC6368fknZu/w+/4Z9I6Bpwx/On67JCHuIcmCezaOVuulLFn0Z
We3Hq0CbGw4hS/rASjEMGHAVfiM1+gc88ohSxLMY2iCzDJ5kXId3O/+gpnZUGi3A
aGgOq7jrZtYgW7gyL6KLVzw8I0pK68QZN+4CBmeD7jczNAPNXH35qARgeJEbpXWY
q8Z81/ibtVaU+jfMjQvkULCE3+9+muklM2lcjHnobYLWzFqsP27sYazCW4TmDV6n
IqXJdt5KrZqUsAg6EeTrOCNtjTO6b+b6Jb3zE+CNThvozhWsWah5IQcmhdFt8qE=
=JlNN
-----END PGP SIGNATURE-----

Prokofyev S.P.

unread,

Mar 19, 2010, 1:02:28 PM3/19/10

to

I tested that patch, but it has been fixed kern/141843
http://lists.freebsd.org/pipermail/freebsd-net/2010-January/024173.html

Pyun YongHyeon

unread,

Mar 19, 2010, 1:44:50 PM3/19/10

to

On Fri, Mar 19, 2010 at 04:40:44PM +0200, Prokofyev S.P. wrote:
> Hi ALL !
>
> Please pay attention to fix bug kern/141285(kern/141843) !
>

igb(4) also has a similar issue but it seems igb(4) does not even
advertise IFCAP_VLAN_HWFILTER capability. igb(4) may have to remove
VLAN event handler or should implement IFCAP_VLAN_HWFILTER to
support VLAN hardware filtering.

I have a patch for the hardware VLAN filtering of em(4). But it
wouldn't address the issue reported in the PR. The root cause of
issue was em(4) wants to reset controller whenever new VLAN is
registered/unregistered. I'm not sure this is requirement of
hardware. If this is requirement of hardware there is no way to
avoid the controller reset unless you disable vlanhwfilter feature.

#ifconfig em0 -vlanhwfilter

em(4) in HEAD disabled VLAN hardware filtering by default so if you
use that version you wouldn't encounter the issue again. Attached
patch is small diff for VLAN hardware filtering which tries to
avoid unnecessary controller reset and added missing lock. If
hardware allows dynamic changing of VLAN filtering table we could
completely bypass the controller reset. Jack may know the details.

em.vlan_hwfilter.patch

Pyun YongHyeon

unread,

Mar 19, 2010, 1:47:09 PM3/19/10

to

Oops, posted old patch. Here is new one.

em.vlan_hwfilter.patch2

Prokofyev S.P.

unread,

Mar 22, 2010, 9:40:13 AM3/22/10

to

Thank you Pyun.
I have applied your patch (rebuild/reinstall kernel) and have lost
access to test server after reboot.

ping Test Server from Server A
Server A (10.25.223.4) -> Test Server(10.25.223.2)

tcpdump -enp -i em0 (via console on Test Server):
14:39:44.752754 00:1b:fc:af:a1:b4 > ff:ff:ff:ff:ff:ff, ethertype 802.1Q
(0x8100), length 64: vlan 77, p 0, ethertype ARP, Request who-has
10.25.223.2 tell 10.25.223.4, length 46
14:39:44.752765 00:30:48:96:cc:56 > 00:1b:fc:af:a1:b4, ethertype 802.1Q
(0x8100), length 46: vlan 77, p 0, ethertype ARP, Reply 10.25.223.2
is-at 00:30:48:96:cc:56, length 28
.........
but do not see reply on Server A.

I "see" the TestServer after ifconfig em0 down/up. The problem with bug
kern/141285 disappear.

If write ifconfig_em0="up -vlanhwtag" in /etc/rc.conf, then after
reboot I have network access to TestServer, but this is not very nice
decision of a problem.